From patchwork Fri Oct 26 05:04:10 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Paul Walmsley X-Patchwork-Id: 1649891 Return-Path: X-Original-To: patchwork-linux-omap@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 87E68DF2F6 for ; Fri, 26 Oct 2012 05:04:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756164Ab2JZFEN (ORCPT ); Fri, 26 Oct 2012 01:04:13 -0400 Received: from utopia.booyaka.com ([74.50.51.50]:39031 "EHLO utopia.booyaka.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756128Ab2JZFEM (ORCPT ); Fri, 26 Oct 2012 01:04:12 -0400 Received: (qmail 31624 invoked by uid 1019); 26 Oct 2012 05:04:10 -0000 Date: Fri, 26 Oct 2012 05:04:10 +0000 (UTC) From: Paul Walmsley To: Afzal Mohammed , Tony Lindgren cc: Artem Bityutskiy , Jon Hunter , David Woodhouse , Ivan Djelic , linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org Subject: Re: [PATCH v2 06/14] mtd: onenand: omap: use pdata info instead of cpu_is In-Reply-To: Message-ID: References: <860ba92c34cbb490beccd5442087087c1751a6a2.1349672877.git.afzal@ti.com> User-Agent: Alpine 2.00 (DEB 1167 2008-08-23) MIME-Version: 1.0 Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org On Fri, 26 Oct 2012, Paul Walmsley wrote: > On Mon, 8 Oct 2012, Afzal Mohammed wrote: > > > platform data now contains a field to indicate whether > > soc belongs to omap34xx family, use it instead of > > cpu_is_* check. > > > > This helps in removing dependency of platform specific > > header file - cpu.h > > > > Signed-off-by: Afzal Mohammed > > This one breaks an N800 multi-OMAP build here: It also breaks an OMAP3+4 config: drivers/built-in.o: In function `omap2_onenand_probe': /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:742: undefined reference to `omap2_onenand_read_bufferram' /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:743: undefined reference to `omap2_onenand_write_bufferram' /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:742: undefined reference to `omap2_onenand_read_bufferram' /home/paul/test_build/temp/test_cleanup_prcm_8634155e_with_fixes/20121025214236/linux/drivers/mtd/onenand/omap2.c:743: undefined reference to `omap2_onenand_write_bufferram' Fix below. - Paul --- drivers/mtd/onenand/omap2.c | 18 ++++++++++++------ 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/mtd/onenand/omap2.c b/drivers/mtd/onenand/omap2.c index f87cf39..99f96e1 100644 --- a/drivers/mtd/onenand/omap2.c +++ b/drivers/mtd/onenand/omap2.c @@ -555,13 +555,19 @@ static int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area, #else -int omap2_onenand_read_bufferram(struct mtd_info *mtd, int area, - unsigned char *buffer, int offset, - size_t count); +static int omap2_onenand_read_bufferram(struct mtd_info *mtd, int area, + unsigned char *buffer, int offset, + size_t count) +{ + return -ENOSYS; +} -int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area, - const unsigned char *buffer, - int offset, size_t count); +static int omap2_onenand_write_bufferram(struct mtd_info *mtd, int area, + const unsigned char *buffer, + int offset, size_t count) +{ + return -ENOSYS; +} #endif