| Message ID | d5a132d3-d391-bc13-3820-c11d123ac6bf@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/19/2016 03:27 PM, Peter Ujfalusi wrote: > On 05/19/16 14:35, Matthijs van Duin wrote: >> On 19 May 2016 at 13:02, Matthijs van Duin <matthijsvanduin@gmail.com> wrote: >>> On 19 May 2016 at 12:19, Peter Ujfalusi <peter.ujfalusi@ti.com> wrote: >>>> Can you try to apply this patch: >>>> https://lkml.org/lkml/2016/5/10/315 >>> >>> Thanks for the pointer, I'll give it a spin. >> >> Took far more reboots than I expected, but eventually I caught it: > > I'm over 30 reboots on my am335x-evmsk and was not able to reproduce. > Now building the kernel with your config, I hope it boots on my board. > >> [ 4.375423] edma 49000000.edma: dma_ccerr_handler: Error interrupt >> without error event! >> >> The occurrence had no adverse effect on the console or rest of system >> as far as I could tell. The patch indeed solves the stuck irq :-) > > So it does work ;) > I'm still unable to reproduce even with your config on BBW, but keep trying ;) > > Meanwhile can you try this as well: > diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c > index 7c76b558cf82..31ea5d986eb0 100644 > --- a/drivers/dma/edma.c > +++ b/drivers/dma/edma.c > @@ -2285,8 +2285,8 @@ static int edma_probe(struct platform_device *pdev) > if (irq >= 0) { > irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint", > dev_name(dev)); > - ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name, > - ecc); > + ret = devm_request_irq(dev, irq, dma_irq_handler, IRQF_ONESHOT, > + irq_name, ecc); > if (ret) { > dev_err(dev, "CCINT (%d) failed --> %d\n", irq, ret); > return ret; > @@ -2300,8 +2300,8 @@ static int edma_probe(struct platform_device *pdev) > if (irq >= 0) { > irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint", > dev_name(dev)); > - ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name, > - ecc); > + ret = devm_request_irq(dev, irq, dma_ccerr_handler, > + IRQF_ONESHOT, irq_name, ecc); This is not going to help as we are not using threaded interrupts in the eDMA driver... > if (ret) { > dev_err(dev, "CCERRINT (%d) failed --> %d\n", irq, ret); > return ret; > >
diff --git a/drivers/dma/edma.c b/drivers/dma/edma.c index 7c76b558cf82..31ea5d986eb0 100644 --- a/drivers/dma/edma.c +++ b/drivers/dma/edma.c @@ -2285,8 +2285,8 @@ static int edma_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccint", dev_name(dev)); - ret = devm_request_irq(dev, irq, dma_irq_handler, 0, irq_name, - ecc); + ret = devm_request_irq(dev, irq, dma_irq_handler, IRQF_ONESHOT, + irq_name, ecc); if (ret) { dev_err(dev, "CCINT (%d) failed --> %d\n", irq, ret); return ret; @@ -2300,8 +2300,8 @@ static int edma_probe(struct platform_device *pdev) if (irq >= 0) { irq_name = devm_kasprintf(dev, GFP_KERNEL, "%s_ccerrint", dev_name(dev)); - ret = devm_request_irq(dev, irq, dma_ccerr_handler, 0, irq_name, - ecc); + ret = devm_request_irq(dev, irq, dma_ccerr_handler, + IRQF_ONESHOT, irq_name, ecc); if (ret) { dev_err(dev, "CCERRINT (%d) failed --> %d\n", irq, ret); return ret;