| Message ID | f66cd508-fe53-af58-bda5-822c8213cf7d@ti.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 05/09/16 15:32, Peter Ujfalusi wrote: > On 05/09/16 15:10, Peter Ujfalusi wrote: > >>>> finally I found some time to apply your patches. Sorry for the long time. >>>> >>>> Unfortunately, it does not work. Neither on omap5evm nor on our omap5 hardware. >>>> I get no sound on the twl6040 - just white noise (which can be controlled in >>>> level through >>>> amixer so it is created on the digital input side of the twl6040). >>>> >>>> So I think your patch is missing a detail compared to my simple solution. >>> >>> Did you implement anything on the audio driver side? The audio driver must >>> enable the clock implemented by this patch. >> >> I did, can test it in 10 minutes or so... > > might work, but linux-next is not booting on omap5-uevm :o I don't know why... Applying Tero's alone makes the board not to boot, so something there... I can not see anything even with low-level debugging enabled :( I can not debug it further today, will look at this tomorrow. > In any case I have attached the 3 patches I have for this, including Tero's > ported to linux-next. > > Patch 3 might need to be done per board probably, but this should be good for > testing. > > > > _______________________________________________ > Kernel mailing list > Kernel@pyra-handheld.com > http://pyra-handheld.com/cgi-bin/mailman/listinfo/kernel >
On 05/09/16 15:46, Peter Ujfalusi wrote: > On 05/09/16 15:32, Peter Ujfalusi wrote: >> On 05/09/16 15:10, Peter Ujfalusi wrote: >> >>>>> finally I found some time to apply your patches. Sorry for the long time. >>>>> >>>>> Unfortunately, it does not work. Neither on omap5evm nor on our omap5 hardware. >>>>> I get no sound on the twl6040 - just white noise (which can be controlled in >>>>> level through >>>>> amixer so it is created on the digital input side of the twl6040). >>>>> >>>>> So I think your patch is missing a detail compared to my simple solution. >>>> >>>> Did you implement anything on the audio driver side? The audio driver must >>>> enable the clock implemented by this patch. >>> >>> I did, can test it in 10 minutes or so... >> >> might work, but linux-next is not booting on omap5-uevm :o I don't know why... > > Applying Tero's alone makes the board not to boot, so something there... I can > not see anything even with low-level debugging enabled :( I can not debug it > further today, will look at this tomorrow. The crash is in arch/arm/mach-omap2/control.c:omap_control_init() the syscon_node_to_regmap() returns with error for the new omap5_scm_wkup_pad_conf node. The other syscon was OK, but becasue of the return PTR_ERR(syscon) the board will not boot... Tero: any idea? >> In any case I have attached the 3 patches I have for this, including Tero's >> ported to linux-next. >> >> Patch 3 might need to be done per board probably, but this should be good for >> testing. >> >> >> >> _______________________________________________ >> Kernel mailing list >> Kernel@pyra-handheld.com >> http://pyra-handheld.com/cgi-bin/mailman/listinfo/kernel >> > >
On 09/05/16 16:52, Peter Ujfalusi wrote: > On 05/09/16 15:46, Peter Ujfalusi wrote: >> On 05/09/16 15:32, Peter Ujfalusi wrote: >>> On 05/09/16 15:10, Peter Ujfalusi wrote: >>> >>>>>> finally I found some time to apply your patches. Sorry for the long time. >>>>>> >>>>>> Unfortunately, it does not work. Neither on omap5evm nor on our omap5 hardware. >>>>>> I get no sound on the twl6040 - just white noise (which can be controlled in >>>>>> level through >>>>>> amixer so it is created on the digital input side of the twl6040). >>>>>> >>>>>> So I think your patch is missing a detail compared to my simple solution. >>>>> >>>>> Did you implement anything on the audio driver side? The audio driver must >>>>> enable the clock implemented by this patch. >>>> >>>> I did, can test it in 10 minutes or so... >>> >>> might work, but linux-next is not booting on omap5-uevm :o I don't know why... >> >> Applying Tero's alone makes the board not to boot, so something there... I can >> not see anything even with low-level debugging enabled :( I can not debug it >> further today, will look at this tomorrow. > > The crash is in arch/arm/mach-omap2/control.c:omap_control_init() > > the syscon_node_to_regmap() returns with error for the new > omap5_scm_wkup_pad_conf node. The other syscon was OK, but becasue of the > return PTR_ERR(syscon) the board will not boot... > > Tero: any idea? I can check this tomorrow at my end. -Tero > >>> In any case I have attached the 3 patches I have for this, including Tero's >>> ported to linux-next. >>> >>> Patch 3 might need to be done per board probably, but this should be good for >>> testing. >>> >>> >>> >>> _______________________________________________ >>> Kernel mailing list >>> Kernel@pyra-handheld.com >>> http://pyra-handheld.com/cgi-bin/mailman/listinfo/kernel >>> >> >> > > -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 05/09/2016 05:09 PM, Tero Kristo wrote: >>> Applying Tero's alone makes the board not to boot, so something there... I can >>> not see anything even with low-level debugging enabled :( I can not debug it >>> further today, will look at this tomorrow. >> >> The crash is in arch/arm/mach-omap2/control.c:omap_control_init() >> >> the syscon_node_to_regmap() returns with error for the new >> omap5_scm_wkup_pad_conf node. The other syscon was OK, but becasue of the >> return PTR_ERR(syscon) the board will not boot... >> >> Tero: any idea? > > I can check this tomorrow at my end. Aargh, I think I know why, I have placed the omap5_scm_wkup_pad_conf node to a wrong place. The inline patch did not applied so I did it by hand... I can boot test it tomorrow. > > -Tero > >> >>>> In any case I have attached the 3 patches I have for this, including Tero's >>>> ported to linux-next. >>>> >>>> Patch 3 might need to be done per board probably, but this should be good for >>>> testing. >>>> >>>> >>>> >>>> _______________________________________________ >>>> Kernel mailing list >>>> Kernel@pyra-handheld.com >>>> http://pyra-handheld.com/cgi-bin/mailman/listinfo/kernel >>>> >>> >>> >> >> >
On 05/09/2016 03:32 PM, Peter Ujfalusi wrote: > On 05/09/16 15:10, Peter Ujfalusi wrote: > >>>> finally I found some time to apply your patches. Sorry for the long time. >>>> >>>> Unfortunately, it does not work. Neither on omap5evm nor on our omap5 hardware. >>>> I get no sound on the twl6040 - just white noise (which can be controlled in >>>> level through >>>> amixer so it is created on the digital input side of the twl6040). >>>> >>>> So I think your patch is missing a detail compared to my simple solution. >>> >>> Did you implement anything on the audio driver side? The audio driver must >>> enable the clock implemented by this patch. >> >> I did, can test it in 10 minutes or so... > > might work, but linux-next is not booting on omap5-uevm :o I don't know why... > > In any case I have attached the 3 patches I have for this, including Tero's > ported to linux-next. > > Patch 3 might need to be done per board probably, but this should be good for > testing. Please ignore these patches, I got HPPLL mode working, I need to clean the patches up first and I will send it for testing tomorrow.
From 87714553b1f803f9c08d32c2c61dc980ddbb1b78 Mon Sep 17 00:00:00 2001 From: Peter Ujfalusi <peter.ujfalusi@ti.com> Date: Mon, 9 May 2016 15:26:11 +0300 Subject: [PATCH 3/3] ARM: dts: omap5-board-common: Add phandle for mclk clock for twl6040 it is used for hppll. Signed-off-by: Peter Ujfalusi <peter.ujfalusi@ti.com> --- arch/arm/boot/dts/omap5-board-common.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/omap5-board-common.dtsi b/arch/arm/boot/dts/omap5-board-common.dtsi index a3a631fb77aa..4caad4dc5d41 100644 --- a/arch/arm/boot/dts/omap5-board-common.dtsi +++ b/arch/arm/boot/dts/omap5-board-common.dtsi @@ -649,8 +649,8 @@ v2v1-supply = <&smps9_reg>; enable-active-high; - clocks = <&clk32kgaudio>; - clock-names = "clk32k"; + clocks = <&clk32kgaudio>, <&fref_xtal_ck>; + clock-names = "clk32k", "mclk"; }; }; -- 2.8.2