From patchwork Wed Nov 15 21:37:57 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "H. Nikolaus Schaller" X-Patchwork-Id: 10060367 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3709F60231 for ; Wed, 15 Nov 2017 21:38:44 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 261152A2DA for ; Wed, 15 Nov 2017 21:38:44 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 1A2042A31E; Wed, 15 Nov 2017 21:38:44 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DAB3E2A2DA for ; Wed, 15 Nov 2017 21:38:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759585AbdKOVij (ORCPT ); Wed, 15 Nov 2017 16:38:39 -0500 Received: from mo4-p00-ob.smtp.rzone.de ([81.169.146.160]:29432 "EHLO mo4-p00-ob.smtp.rzone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758970AbdKOVig (ORCPT ); Wed, 15 Nov 2017 16:38:36 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; t=1510781913; s=domk; d=goldelico.com; h=References:In-Reply-To:References:In-Reply-To:Date:Subject:Cc:To: From; bh=Ex8pVJ/Atfk9cV2ZAAEY4PW/sRUGUEkXOlsiQ19ypzc=; b=eJ+nfhct/RhmmGyux8Wotz9igO9LL0mnpy2C+Kl3/9Hurx2jtDoG6BJy9jZdcIs893 N20luTVLu6Bampx4PKk9AiDQwglaoZr8YIFeKdAZUuwktFkF6mVylRsNCK31fPUaTKOL FyL23GVkqHY4B09g9WIAmXswh36or9cOJ7Rx8= X-RZG-AUTH: :JGIXVUS7cutRB/49FwqZ7WcJeFKiMgPgp8VKxflSZ1P34KBj4Qpw87WivtN1GT2Y X-RZG-CLASS-ID: mo00 Received: from localhost.localdomain (p57AE06C1.dip0.t-ipconnect.de [87.174.6.193]) by smtp.strato.de (RZmta 42.9 DYNA|AUTH) with ESMTPSA id f05bb6tAFLc1euO (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (curve secp521r1 with 521 ECDH bits, eq. 15360 bits RSA)) (Client did not present a certificate); Wed, 15 Nov 2017 22:38:01 +0100 (CET) From: "H. Nikolaus Schaller" To: Rob Herring , Mark Rutland , =?UTF-8?q?Beno=C3=AEt=20Cousson?= , Tony Lindgren , Russell King , Arnd Bergmann , Greg Kroah-Hartman , "H. Nikolaus Schaller" , Kevin Hilman , =?UTF-8?q?Andreas=20F=C3=A4rber?= , Thierry Reding , Jonathan Cameron Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, letux-kernel@openphoenux.org, kernel@pyra-handheld.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 5/5] misc serdev: w2sg0004: add debugging code and Kconfig Date: Wed, 15 Nov 2017 22:37:57 +0100 Message-Id: X-Mailer: git-send-email 2.12.2 In-Reply-To: References: In-Reply-To: References: Sender: linux-omap-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-omap@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This allows to set CONFIG_W2SG0004_DEBUG which will make the driver report more activities and it will turn on the GPS module during boot while the driver assumes that it is off. This can be used to debug the correct functioning of the hardware. Therefore we add it as an option to the driver because we think it is of general use (and a little tricky to add by system testers). Normally it should be off. Signed-off-by: H. Nikolaus Schaller --- drivers/misc/Kconfig | 8 ++++++++ drivers/misc/w2sg0004.c | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 45 insertions(+) diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig index 09d171d68408..f15ff5a97e42 100644 --- a/drivers/misc/Kconfig +++ b/drivers/misc/Kconfig @@ -528,4 +528,12 @@ config W2SG0004 is opened/closed. It also provides a rfkill gps name to control the LNA power. +config W2SG0004_DEBUG + bool "W2SG0004 on/off debugging" + depends on W2SG0004 + help + Enable driver debugging mode of W2SG0004 GPS. If you say y here + this will turn on the module and you can check if it is turned + off by the driver. + endmenu diff --git a/drivers/misc/w2sg0004.c b/drivers/misc/w2sg0004.c index 12e14b5e0a99..51ddc807eac5 100644 --- a/drivers/misc/w2sg0004.c +++ b/drivers/misc/w2sg0004.c @@ -22,6 +22,10 @@ * */ +#ifdef CONFIG_W2SG0004_DEBUG +#define DEBUG 1 +#endif + #include #include #include @@ -253,6 +257,7 @@ static int w2sg_tty_install(struct tty_driver *driver, struct tty_struct *tty) pr_debug("%s() tty = %p\n", __func__, tty); data = w2sg_get_by_minor(tty->index); + pr_debug("%s() data = %p\n", __func__, data); if (!data) return -ENODEV; @@ -333,6 +338,8 @@ static int w2sg_probe(struct serdev_device *serdev) w2sg_by_minor[minor] = data; + pr_debug("w2sg serdev_device_set_drvdata\n"); + serdev_device_set_drvdata(serdev, data); data->on_off_gpio = of_get_named_gpio_flags(serdev->dev.of_node, @@ -366,6 +373,8 @@ static int w2sg_probe(struct serdev_device *serdev) INIT_DELAYED_WORK(&data->work, toggle_work); + pr_debug("w2sg devm_gpio_request\n"); + err = devm_gpio_request(&serdev->dev, data->on_off_gpio, "w2sg0004-on-off"); if (err < 0) @@ -379,6 +388,8 @@ static int w2sg_probe(struct serdev_device *serdev) serdev_device_set_baudrate(data->uart, 9600); serdev_device_set_flow_control(data->uart, false); + pr_debug("w2sg rfkill_alloc\n"); + rf_kill = rfkill_alloc("GPS", &serdev->dev, RFKILL_TYPE_GPS, &w2sg0004_rfkill_ops, data); if (rf_kill == NULL) { @@ -386,6 +397,8 @@ static int w2sg_probe(struct serdev_device *serdev) goto err_rfkill; } + pr_debug("w2sg register rfkill\n"); + err = rfkill_register(rf_kill); if (err) { dev_err(&serdev->dev, "Cannot register rfkill device\n"); @@ -394,6 +407,8 @@ static int w2sg_probe(struct serdev_device *serdev) data->rf_kill = rf_kill; + pr_debug("w2sg alloc_tty_driver\n"); + /* allocate the tty driver */ data->tty_drv = alloc_tty_driver(1); if (!data->tty_drv) @@ -419,6 +434,8 @@ static int w2sg_probe(struct serdev_device *serdev) */ tty_set_operations(data->tty_drv, &w2sg_serial_ops); + pr_debug("w2sg tty_register_driver\n"); + /* register the tty driver */ err = tty_register_driver(data->tty_drv); if (err) { @@ -428,16 +445,34 @@ static int w2sg_probe(struct serdev_device *serdev) goto err_rfkill; } + pr_debug("w2sg call tty_port_init\n"); + tty_port_init(&data->port); data->port.ops = &w2sg_port_ops; pr_debug("w2sg call tty_port_register_device\n"); + pr_debug("w2sg call tty_port_register_device\n"); + data->dev = tty_port_register_device(&data->port, data->tty_drv, minor, &serdev->dev); + pr_debug("w2sg tty_port_register_device -> %p\n", data->dev); + pr_debug("w2sg port.tty = %p\n", data->port.tty); + pr_debug("w2sg probed\n"); +#ifdef CONFIG_W2SG0004_DEBUG + pr_debug("w2sg DEBUGGING MODE enabled\n"); + /* turn on for debugging rx notifications */ + pr_debug("w2sg power gpio ON\n"); + gpio_set_value_cansleep(data->on_off_gpio, 1); + mdelay(100); + pr_debug("w2sg power gpio OFF\n"); + gpio_set_value_cansleep(data->on_off_gpio, 0); + mdelay(300); +#endif + /* keep off until user space requests the device */ w2sg_set_power(data, false); @@ -447,6 +482,8 @@ static int w2sg_probe(struct serdev_device *serdev) rfkill_destroy(rf_kill); serdev_device_close(data->uart); out: + pr_debug("w2sg error %d\n", err); + return err; }