| Message ID | fe9b4aed7a13f673cbc9419c43840443052ebaa8.1500441685.git.arvind.yadav.cs@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wednesday, July 19, 2017 10:53:11 AM Arvind Yadav wrote: > attribute_group are not supposed to change at runtime. All functions > working with attribute_group provided by <linux/sysfs.h> work > with const attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2673 368 0 3041 be1 panel-tpo-td043mtea1.o > > File size After adding 'const': > text data bss dec hex filename > 2737 304 0 3041 be1 panel-tpo-td043mtea1.o > > Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Patch queued for 4.14, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c index 51e628b..ea8c79a 100644 --- a/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c +++ b/drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c @@ -282,7 +282,7 @@ static DEVICE_ATTR(gamma, S_IRUGO | S_IWUSR, NULL, }; -static struct attribute_group tpo_td043_attr_group = { +static const struct attribute_group tpo_td043_attr_group = { .attrs = tpo_td043_attrs, };
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const. File size before: text data bss dec hex filename 2673 368 0 3041 be1 panel-tpo-td043mtea1.o File size After adding 'const': text data bss dec hex filename 2737 304 0 3041 be1 panel-tpo-td043mtea1.o Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> --- drivers/video/fbdev/omap2/omapfb/displays/panel-tpo-td043mtea1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)