| Message ID | 20200915042452.26155-1-mdf@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | First bunch of Tulip cleanups | expand |
From: Moritz Fischer <mdf@kernel.org> Date: Mon, 14 Sep 2020 21:24:49 -0700 > This series is the first bunch of minor cleanups for the de2104x driver > to make it look and behave more like a modern driver. > > These changes replace some of the non-devres versions with devres > versions of functions to simplify the error paths. > > Next up after this will be the ioremap part. I really don't consider a "conversion" over to devres for older drivers a suitable cleanup. There are no resource handling bugs you are fixing, the driver uses the APIs it uses correctly, and the coding style is reasonable. Therefore, I'm sorry I'm not applying these changes.
This series is the first bunch of minor cleanups for the de2104x driver to make it look and behave more like a modern driver. These changes replace some of the non-devres versions with devres versions of functions to simplify the error paths. Next up after this will be the ioremap part. Changes from v1: - Fix issue with the pci_enable_device patch. Moritz Fischer (3): net: dec: tulip: de2104x: Replace alloc_etherdev by devm_alloc_etherdev net: dec: tulip: de2104x: Replace pci_enable_device with devres version net: dec: tulip: de2104x: Replace kmemdup() with devm_kmempdup() drivers/net/ethernet/dec/tulip/de2104x.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-)