From patchwork Fri Mar 21 19:48:39 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Andrey Albershteyn X-Patchwork-Id: 14025974 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0FF481EA7C1 for ; Fri, 21 Mar 2025 19:49:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742586556; cv=none; b=jnyYbmffkOxufowfMai0J0+gXjzZsA43BNeUiwuFEs6W+mAppZi9hBsrE6LNEQeoHcvFF9uvVKBuzYR+lpaZiD0z1NGGKH8/JsCpm6j+Qwc0B6M8A1qiHGiLI9JnVBCb/+EAa9C8mdQxvpAzeF1W9whH1VuQTGHPIyC31xDjgIQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742586556; c=relaxed/simple; bh=FQVoAK1grhAv3nZByLs+uzRSU6UsJz/ykU8hQy3B+S4=; h=From:Subject:Date:Message-Id:MIME-Version:Content-Type:To:Cc; b=dAQ83hMvEJG3+ZOR7WOWAZcXAxb5x69/BlQIVL9PfE0skms2f91fWfT1aWmSxwrFIfwIKM86JTjZ2yTa5VrsAgMm8+LEGvPxtWVu8koMBv759HBHEpx9BUwjtiV1xx59mYznX+q/zbZUXqK5u2n1nLr/e72HnBZlDIvFzxvah+0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ciSuoVaE; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ciSuoVaE" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1742586554; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=1wNhBnm2ReGLfeaXSKjzDT3Sr3/X+7bRy4uy/8cmkEY=; b=ciSuoVaE6N1WV8YtBXP+6K/yWsJPKs6Cb4vhCoubwUKPGVxb4deKf62yWSbjJy6DivOTkP C8RrTnj4+jhEEEjwj/l/XrumE1ipPpoDISb8JU3xXaAR25AVcEucAhqEGOa2INlztRG1v4 zaCCLt5R/qGdvUUAMDTdAOBO24q8mU8= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-423-fKHaaT9VM-6mP29luX-PwA-1; Fri, 21 Mar 2025 15:49:12 -0400 X-MC-Unique: fKHaaT9VM-6mP29luX-PwA-1 X-Mimecast-MFC-AGG-ID: fKHaaT9VM-6mP29luX-PwA_1742586552 Received: by mail-ej1-f71.google.com with SMTP id a640c23a62f3a-ac27f00a8a5so181662966b.3 for ; Fri, 21 Mar 2025 12:49:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742586548; x=1743191348; h=cc:to:content-transfer-encoding:mime-version:message-id:date :subject:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1wNhBnm2ReGLfeaXSKjzDT3Sr3/X+7bRy4uy/8cmkEY=; b=Arbqsa8SAtbsu2mxrzQFkXCzWhfeiclRRyJnsE0AAr7p55pHgnkOPc1WtJhXzSLgdl btLfYI8WdiQOhrWa5vDJQvnbs52MYEQ62JU0aXnejyogcQxbIKI+DCLPFjXFoaB6JIFe eS6zH/EvU+kXqh+s1Ky6WrCLZX8DTBHVelk6n4WKC1ddLDN8pT8e93iMo/Olbd6npA2r TN4sJKHicFckJj7Pvnxg5G4B+b1j+om8bBO18pNpM+4mwiutb+WKcqSA09vuxrHOtmZh cfiQ13xoMLpcoUmG6VafL9YM9nQc5EP+/Z+qXsgGPEdzrtgn4oJJmOCzRT3mMeYMb1T7 k5OA== X-Forwarded-Encrypted: i=1; AJvYcCWuu1E4qyPAG9B+gdaGGuWnCUGHoupM1Y7TbvGv4eR2JtjdD5iYAf+E4V1TM2oinEuzfHGYJ9AKI4ByzVM=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgsrn/hNt9Bfiq4/EYzu8ruIHvwT3PIdXnYSIwOqbtYW1Ue+xT QCVntSmeVQpbpeP2d++X9cPC01eKBAtsI40pSsgehXbthbwNhOlCXeps3l7VYguX3eQYtLqoJrz kCtsytOcXKVVPuyS7BhZe+gkM0Rr5EqdiVsk70Z7CeaH9pN8CRZGUI1g4Yne6 X-Gm-Gg: ASbGncvrESeP8mz7F7oj7dSneFPtwfFkZCCJOPk6UraBLkUKnJ2ehbiDemWWqqpDFsH kWQPafBbL4YWPs5+4Y67Y7vLh20HrbnUpodBIxwSC74kFY+mOpqEgqSk2nV9b98E9UOQdn3xsjl f7CjyKAyotGweyw0Av8tQvoxVCYLyhWBbZpCWkLpJ5/QZyThGrkeP35rV64pmFEZrSHdzQS3j/X QWa6z7NbLGWVkScTCfNUEMg3sBhChQR2eGOy62BbauXq526ulwk3WaNuNt2o88qsjAHTAB+XqQo c4/JYJbK1nLU80kqt8YRpWg69nylRaN1MROj3Vt2yw== X-Received: by 2002:a17:907:7dab:b0:ac2:7a6d:c927 with SMTP id a640c23a62f3a-ac3f251f252mr442163966b.50.1742586547723; Fri, 21 Mar 2025 12:49:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFIuU8NfxIMB+ef2e3eKHAzCm35NOLlzxTP1nDtQXGYf88xl+hzf++88iNdtamLPujW3TPHjA== X-Received: by 2002:a17:907:7dab:b0:ac2:7a6d:c927 with SMTP id a640c23a62f3a-ac3f251f252mr442156966b.50.1742586547062; Fri, 21 Mar 2025 12:49:07 -0700 (PDT) Received: from [127.0.0.2] (ip-217-030-074-039.aim-net.cz. [217.30.74.39]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ac3ef8d3d38sm204412266b.39.2025.03.21.12.49.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 12:49:06 -0700 (PDT) From: Andrey Albershteyn X-Google-Original-From: Andrey Albershteyn Subject: [PATCH v4 0/3] fs: introduce getfsxattrat and setfsxattrat syscalls Date: Fri, 21 Mar 2025 20:48:39 +0100 Message-Id: <20250321-xattrat-syscall-v4-0-3e82e6fb3264@kernel.org> Precedence: bulk X-Mailing-List: linux-parisc@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-B4-Tracking: v=1; b=H4sIAJjC3WcC/2XN0QqDIBTG8VcJr+fwHLPVrvYeYxeaVrKoUJEie vdZDAbr8v/B+Z2VeOOs8eSercSZaL0dhxT5JSN1J4fWUKtTE2QoGEBOZxmCk4H6xdey72khAXi hUStRkXQ1OdPY+RCfr9Sd9WF0y/Eg4r5+LcSTFZECFYoXTOeNqhU+3sYNpr+OriU7FvkPQIAzw BMg2U2DaMqq/AO2bfsAGIg0CfAAAAA= X-Change-ID: 20250114-xattrat-syscall-6a1136d2db59 To: Richard Henderson , Matt Turner , Russell King , Catalin Marinas , Will Deacon , Geert Uytterhoeven , Michal Simek , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Madhavan Srinivasan , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Chris Zankel , Max Filippov , Alexander Viro , Christian Brauner , Jan Kara , =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= , =?utf-8?q?G=C3=BCnt?= =?utf-8?q?her_Noack?= , Arnd Bergmann , =?utf-8?q?Pali_Roh=C3=A1r?= , Paul Moore , James Morris , "Serge E. Hallyn" Cc: linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, selinux@vger.kernel.org, Andrey Albershteyn , Andrey Albershteyn , linux-xfs@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=7149; i=aalbersh@kernel.org; h=from:subject:message-id; bh=FQVoAK1grhAv3nZByLs+uzRSU6UsJz/ykU8hQy3B+S4=; b=owJ4nJvAy8zAJea2/JXEGuOHHIyn1ZIY0u8e2vB17Ur5VW0+Gx1C7pyq2fjopYGGydO9y6YW+ c/4/jCiIG1rRykLgxgXg6yYIss6aa2pSUVS+UcMauRh5rAygQxh4OIUgIlcSGZkaAtVCfd2P3uU cQdTt4coF6++p8WE+2wb8xhWObiyr2E8y8jQURZRWfY081TjgR7tSktm7c+nv4iv0W9lm1se/Wa T5xkGAGijRuY= X-Developer-Key: i=aalbersh@kernel.org; a=openpgp; fpr=AE1B2A9562721A6FC4307C1F46A7EA18AC33E108 This patchset introduced two new syscalls getfsxattrat() and setfsxattrat(). These syscalls are similar to FS_IOC_FSSETXATTR ioctl() except they use *at() semantics. Therefore, there's no need to open the file to get an fd. These syscalls allow userspace to set filesystem inode attributes on special files. One of the usage examples is XFS quota projects. XFS has project quotas which could be attached to a directory. All new inodes in these directories inherit project ID set on parent directory. The project is created from userspace by opening and calling FS_IOC_FSSETXATTR on each inode. This is not possible for special files such as FIFO, SOCK, BLK etc. Therefore, some inodes are left with empty project ID. Those inodes then are not shown in the quota accounting but still exist in the directory. This is not critical but in the case when special files are created in the directory with already existing project quota, these new inodes inherit extended attributes. This creates a mix of special files with and without attributes. Moreover, special files with attributes don't have a possibility to become clear or change the attributes. This, in turn, prevents userspace from re-creating quota project on these existing files. Christian, if this get in some mergeable state, please don't merge it yet. Amir suggested these syscalls better to use updated struct fsxattr with masking from Pali Rohár patchset, so, let's see how it goes. NAME getfsxattrat/setfsxattrat - get/set filesystem inode attributes SYNOPSIS #include /* Definition of SYS_* constants */ #include long syscall(SYS_getfsxattrat, int dirfd, const char *pathname, struct fsxattr *fsx, size_t size, unsigned int at_flags); long syscall(SYS_setfsxattrat, int dirfd, const char *pathname, struct fsxattr *fsx, size_t size, unsigned int at_flags); Note: glibc doesn't provide for getfsxattrat()/setfsxattrat(), use syscall(2) instead. DESCRIPTION The syscalls take fd and path to the child together with struct fsxattr. If path is absolute, fd is not used. If path is empty, inode under fd is used to get/set attributes on. This is an alternative to FS_IOC_FSGETXATTR/FS_IOC_FSSETXATTR ioctl with a difference that file don't need to be open as we can reference it with a path instead of fd. By having this we can manipulated filesystem inode attributes not only on regular files but also on special ones. This is not possible with FS_IOC_FSSETXATTR ioctl as with special files we can not call ioctl() directly on the filesystem inode using file descriptor. RETURN VALUE On success, 0 is returned. On error, -1 is returned, and errno is set to indicate the error. ERRORS EINVAL Invalid at_flag specified (only AT_SYMLINK_NOFOLLOW and AT_EMPTY_PATH is supported). EINVAL Size was smaller than any known version of struct fsxattr. EINVAL Invalid combination of parameters provided in fsxattr for this type of file. E2BIG Size of input argument **struct fsxattr** is too big. EBADF Invalid file descriptor was provided. EPERM No permission to change this file. EOPNOTSUPP Filesystem does not support setting attributes on this type of inode HISTORY Added in Linux 6.14. EXAMPLE Create directory and file "mkdir ./dir && touch ./dir/foo" and then execute the following program: #include #include #include #include #include #include #include int main(int argc, char **argv) { int dfd; int error; struct fsxattr fsx; dfd = open("./dir", O_RDONLY); if (dfd == -1) { printf("can not open ./dir"); return dfd; } error = syscall(467, dfd, "./foo", &fsx, 0); if (error) { printf("can not call 467: %s", strerror(errno)); return error; } printf("dir/foo flags: %d\n", fsx.fsx_xflags); fsx.fsx_xflags |= FS_XFLAG_NODUMP; error = syscall(468, dfd, "./foo", &fsx, 0); if (error) { printf("can not call 468: %s", strerror(errno)); return error; } printf("dir/foo flags: %d\n", fsx.fsx_xflags); return error; } SEE ALSO ioctl(2), ioctl_iflags(2), ioctl_xfs_fsgetxattr(2) --- Changes in v4: - Use getname_maybe_null() for correct handling of dfd + path semantic - Remove restriction for special files on which flags are allowed - Utilize copy_struct_from_user() for better future compatibility - Add draft man page to cover letter - Convert -ENOIOCTLCMD to -EOPNOSUPP as more appropriate for syscall - Add missing __user to header declaration of syscalls - Link to v3: https://lore.kernel.org/r/20250211-xattrat-syscall-v3-1-a07d15f898b2@kernel.org Changes in v3: - Remove unnecessary "dfd is dir" check as it checked in user_path_at() - Remove unnecessary "same filesystem" check - Use CLASS() instead of directly calling fdget/fdput - Link to v2: https://lore.kernel.org/r/20250122-xattrat-syscall-v2-1-5b360d4fbcb2@kernel.org v1: https://lore.kernel.org/linuxppc-dev/20250109174540.893098-1-aalbersh@kernel.org/ Previous discussion: https://lore.kernel.org/linux-xfs/20240520164624.665269-2-aalbersh@redhat.com/ --- Andrey Albershteyn (3): lsm: introduce new hooks for setting/getting inode fsxattr fs: split fileattr/fsxattr converters into helpers fs: introduce getfsxattrat and setfsxattrat syscalls arch/alpha/kernel/syscalls/syscall.tbl | 2 + arch/arm/tools/syscall.tbl | 2 + arch/arm64/tools/syscall_32.tbl | 2 + arch/m68k/kernel/syscalls/syscall.tbl | 2 + arch/microblaze/kernel/syscalls/syscall.tbl | 2 + arch/mips/kernel/syscalls/syscall_n32.tbl | 2 + arch/mips/kernel/syscalls/syscall_n64.tbl | 2 + arch/mips/kernel/syscalls/syscall_o32.tbl | 2 + arch/parisc/kernel/syscalls/syscall.tbl | 2 + arch/powerpc/kernel/syscalls/syscall.tbl | 2 + arch/s390/kernel/syscalls/syscall.tbl | 2 + arch/sh/kernel/syscalls/syscall.tbl | 2 + arch/sparc/kernel/syscalls/syscall.tbl | 2 + arch/x86/entry/syscalls/syscall_32.tbl | 2 + arch/x86/entry/syscalls/syscall_64.tbl | 2 + arch/xtensa/kernel/syscalls/syscall.tbl | 2 + fs/inode.c | 130 ++++++++++++++++++++++++++++ fs/ioctl.c | 39 ++++++--- include/linux/fileattr.h | 2 + include/linux/lsm_hook_defs.h | 4 + include/linux/security.h | 16 ++++ include/linux/syscalls.h | 6 ++ include/uapi/asm-generic/unistd.h | 8 +- include/uapi/linux/fs.h | 3 + security/security.c | 32 +++++++ 25 files changed, 259 insertions(+), 13 deletions(-) --- base-commit: ffd294d346d185b70e28b1a28abe367bbfe53c04 change-id: 20250114-xattrat-syscall-6a1136d2db59 Best regards,