From patchwork Fri Jun 14 18:55:42 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: James Bottomley X-Patchwork-Id: 2723001 Return-Path: X-Original-To: patchwork-linux-parisc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 17282C0AB1 for ; Fri, 14 Jun 2013 18:55:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 38993202DD for ; Fri, 14 Jun 2013 18:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5ECB820290 for ; Fri, 14 Jun 2013 18:55:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753835Ab3FNSzp (ORCPT ); Fri, 14 Jun 2013 14:55:45 -0400 Received: from bedivere.hansenpartnership.com ([66.63.167.143]:34596 "EHLO bedivere.hansenpartnership.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752973Ab3FNSzn (ORCPT ); Fri, 14 Jun 2013 14:55:43 -0400 Received: from localhost (localhost [127.0.0.1]) by bedivere.hansenpartnership.com (Postfix) with ESMTP id 42F678EE10E; Fri, 14 Jun 2013 11:55:43 -0700 (PDT) Received: from bedivere.hansenpartnership.com ([127.0.0.1]) by localhost (bedivere.hansenpartnership.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rwpuErGIn-sL; Fri, 14 Jun 2013 11:55:43 -0700 (PDT) Received: from [10.0.0.6] (c-24-18-112-117.hsd1.wa.comcast.net [24.18.112.117]) by bedivere.hansenpartnership.com (Postfix) with ESMTPSA id BE8948EE0C6; Fri, 14 Jun 2013 11:55:42 -0700 (PDT) Message-ID: <1371236142.2726.43.camel@dabdike> Subject: [PATCH RESEND] fix WARNING: at kernel/cpu/idle.c:96 From: James Bottomley To: Parisc List Cc: Thomas Gleixner , linux-kernel , Andrew Morton Date: Fri, 14 Jun 2013 11:55:42 -0700 X-Mailer: Evolution 3.8.2 Mime-Version: 1.0 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From 48bbf44a96676ce6f520a408378730c976e9a11e Mon Sep 17 00:00:00 2001 From: James Bottomley Date: Wed, 8 May 2013 14:05:34 -0700 Subject: [PATCH] [PARISC] fix WARNING: at kernel/cpu/idle.c:96 On PA-RISC (and presumably any other arch that doesn't implement its own arch_cpu_idle), we get this spurious boot warning. The problem is that the way the idle task is selected initially using the weak arch_cpu_idle() in idle.c causes us to enter this place once with interrupts enabled. Fix this by disabling interrupts in the weak arch_cpu_idle() code. Reviewed-by: Srivatsa S. Bhat Cc: stable@vger.kernel.org Signed-off-by: James Bottomley --- Thomas, I'm getting a bit impatient: this is a clear bug in the cpu idle code and we keep getting reports of this as a boot crash on parisc. If you don't push it through your tree, I'll take it through the parisc one. -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c index d5585f5..0a4d11e 100644 --- a/kernel/cpu/idle.c +++ b/kernel/cpu/idle.c @@ -58,6 +58,7 @@ void __weak arch_cpu_idle_dead(void) { } void __weak arch_cpu_idle(void) { cpu_idle_force_poll = 1; + local_irq_enable(); } /*