From patchwork Mon Sep 23 01:24:10 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Felipe Pena X-Patchwork-Id: 2925561 Return-Path: X-Original-To: patchwork-linux-parisc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7553CBFF05 for ; Mon, 23 Sep 2013 01:24:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 766AB20529 for ; Mon, 23 Sep 2013 01:24:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A678520503 for ; Mon, 23 Sep 2013 01:24:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752872Ab3IWBYN (ORCPT ); Sun, 22 Sep 2013 21:24:13 -0400 Received: from mail-yh0-f52.google.com ([209.85.213.52]:54812 "EHLO mail-yh0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752611Ab3IWBYM (ORCPT ); Sun, 22 Sep 2013 21:24:12 -0400 Received: by mail-yh0-f52.google.com with SMTP id v1so1063813yhn.25 for ; Sun, 22 Sep 2013 18:24:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=EV3ehThmhOHGZ/u/AJuWJrYc2OpBTb9roUqywExbadg=; b=txfbjtT70X3CRFgwbTeqBkKydA5I1Riw/8B1WV+l12rgcShunXC0cFv5WPlF0HuQTL kYOUAN8OZjvA4tzZCMKdkDpbOm5h8AdAMvEXGmDxOiKrPGZS5swtL8L7sUBzSSxRYWec mYcCIZIVmJghC3enzfIhcplF5siM3xwHFDoGuUcdrKgdHhxLDWc6vd1bE1CK7TvUvSNl ivIz/a6lphyOu0w2LPjN+c1dBlryd194UBlBhU5tWG2oEMj330RmyR2uMx3Mc9UqwDbE ZcEu8FuJVxi48nHeoFDWRJrSUcnUuu+CvMT2oNOuxL4OEeM1ASrzMjNR+UJIakP9FS4B IjnA== X-Received: by 10.236.54.232 with SMTP id i68mr21021161yhc.0.1379899452231; Sun, 22 Sep 2013 18:24:12 -0700 (PDT) Received: from localhost.localdomain (189-105-138-142.user.veloxzone.com.br. [189.105.138.142]) by mx.google.com with ESMTPSA id g25sm33740276yhg.6.1969.12.31.16.00.00 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 22 Sep 2013 18:24:11 -0700 (PDT) From: Felipe Pena To: "James E.J. Bottomley" , Michal Hocko , Johannes Weiner , Kautuk Consul , Andrew Morton , Helge Deller Cc: linux-parisc@vger.kernel.org, linux-kernel@vger.kernel.org, Felipe Pena Subject: [PATCHv2 1/1] arch/parisc: mm: fix uninitialized variable usage Date: Sun, 22 Sep 2013 22:24:10 -0300 Message-Id: <1379899450-27552-1-git-send-email-felipensp@gmail.com> X-Mailer: git-send-email 1.7.10.4 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Spam-Status: No, score=-9.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The FAULT_FLAG_WRITE flag has been set based on uninitialized variable Signed-off-by: Felipe Pena --- arch/parisc/mm/fault.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/parisc/mm/fault.c b/arch/parisc/mm/fault.c index d10d27a..00c0ed3 100644 --- a/arch/parisc/mm/fault.c +++ b/arch/parisc/mm/fault.c @@ -182,6 +182,9 @@ void do_page_fault(struct pt_regs *regs, unsigned long code, if (user_mode(regs)) flags |= FAULT_FLAG_USER; + + acc_type = parisc_acctyp(code, regs->iir); + if (acc_type & VM_WRITE) flags |= FAULT_FLAG_WRITE; retry: @@ -196,8 +199,6 @@ retry: good_area: - acc_type = parisc_acctyp(code,regs->iir); - if ((vma->vm_flags & acc_type) != acc_type) goto bad_area;