| Message ID | 1410285991-24833-1-git-send-email-ricardo.ribalda@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Tue, Sep 09, 2014 at 08:06:31PM +0200, Ricardo Ribalda Delgado wrote: > Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add > support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on > all the archs. Unfortunaltely the definition of TIOCSRS485 and > TIOCGRS485 was missing on the ioctls.h file > > Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> > --- > arch/parisc/include/uapi/asm/ioctls.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/parisc/include/uapi/asm/ioctls.h b/arch/parisc/include/uapi/asm/ioctls.h > index 66719c3..3af2d02 100644 > --- a/arch/parisc/include/uapi/asm/ioctls.h > +++ b/arch/parisc/include/uapi/asm/ioctls.h > @@ -50,6 +50,8 @@ > #define TCSETS2 _IOW('T',0x2B, struct termios2) > #define TCSETSW2 _IOW('T',0x2C, struct termios2) > #define TCSETSF2 _IOW('T',0x2D, struct termios2) > +#define TIOCGRS485 0x542E > +#define TIOCSRS485 0x542F As David pointed out with the sparc patch, please use the proper ioctl macros for these numbers. Please redo all of these patches and resend. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Greg. I have just resend one for sparc. Are we sure that we prefer the macros instead of using the same value on all arches? Thanks On Tue, Sep 9, 2014 at 8:43 PM, Greg KH <greg@kroah.com> wrote: > On Tue, Sep 09, 2014 at 08:06:31PM +0200, Ricardo Ribalda Delgado wrote: >> Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add >> support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on >> all the archs. Unfortunaltely the definition of TIOCSRS485 and >> TIOCGRS485 was missing on the ioctls.h file >> >> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> >> --- >> arch/parisc/include/uapi/asm/ioctls.h | 2 ++ >> 1 file changed, 2 insertions(+) >> >> diff --git a/arch/parisc/include/uapi/asm/ioctls.h b/arch/parisc/include/uapi/asm/ioctls.h >> index 66719c3..3af2d02 100644 >> --- a/arch/parisc/include/uapi/asm/ioctls.h >> +++ b/arch/parisc/include/uapi/asm/ioctls.h >> @@ -50,6 +50,8 @@ >> #define TCSETS2 _IOW('T',0x2B, struct termios2) >> #define TCSETSW2 _IOW('T',0x2C, struct termios2) >> #define TCSETSF2 _IOW('T',0x2D, struct termios2) >> +#define TIOCGRS485 0x542E >> +#define TIOCSRS485 0x542F > > As David pointed out with the sparc patch, please use the proper ioctl > macros for these numbers. > > Please redo all of these patches and resend. > > thanks, > > greg k-h
On Tue, Sep 09, 2014 at 08:46:48PM +0200, Ricardo Ribalda Delgado wrote: > Hello Greg. > > I have just resend one for sparc. Are we sure that we prefer the > macros instead of using the same value on all arches? Why would using a macro preclude the value being the same on all arches? -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Hello Greg, I have just resend the macros for the two other arches using the proper macros. Thanks On Tue, Sep 9, 2014 at 8:58 PM, Greg KH <greg@kroah.com> wrote: > On Tue, Sep 09, 2014 at 08:46:48PM +0200, Ricardo Ribalda Delgado wrote: >> Hello Greg. >> >> I have just resend one for sparc. Are we sure that we prefer the >> macros instead of using the same value on all arches? > > Why would using a macro preclude the value being the same on all arches?
diff --git a/arch/parisc/include/uapi/asm/ioctls.h b/arch/parisc/include/uapi/asm/ioctls.h index 66719c3..3af2d02 100644 --- a/arch/parisc/include/uapi/asm/ioctls.h +++ b/arch/parisc/include/uapi/asm/ioctls.h @@ -50,6 +50,8 @@ #define TCSETS2 _IOW('T',0x2B, struct termios2) #define TCSETSW2 _IOW('T',0x2C, struct termios2) #define TCSETSF2 _IOW('T',0x2D, struct termios2) +#define TIOCGRS485 0x542E +#define TIOCSRS485 0x542F #define TIOCGPTN _IOR('T',0x30, unsigned int) /* Get Pty Number (of pty-mux device) */ #define TIOCSPTLCK _IOW('T',0x31, int) /* Lock/unlock Pty */ #define TIOCGDEV _IOR('T',0x32, int) /* Get primary device node of /dev/console */
Commit: e676253b19b2d269cccf67fdb1592120a0cd0676 (serial/8250: Add support for RS485 IOCTLs), adds support for RS485 ioctls for 825_core on all the archs. Unfortunaltely the definition of TIOCSRS485 and TIOCGRS485 was missing on the ioctls.h file Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com> --- arch/parisc/include/uapi/asm/ioctls.h | 2 ++ 1 file changed, 2 insertions(+)