| Message ID | 1410980419-5326-2-git-send-email-fabf@skynet.be (mailing list archive) |
|---|---|
| State | Awaiting Upstream, archived |
| Headers | show |
Hi, On 17/09/14 22:00, Fabian Frederick wrote: > Use container_of instead of casting first structure member. > > Signed-off-by: Fabian Frederick <fabf@skynet.be> > --- > PARISC cross-compiled but untested. > > drivers/video/fbdev/stifb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c > index cfe8a2f..86621fa 100644 > --- a/drivers/video/fbdev/stifb.c > +++ b/drivers/video/fbdev/stifb.c > @@ -918,7 +918,7 @@ static int > stifb_setcolreg(u_int regno, u_int red, u_int green, > u_int blue, u_int transp, struct fb_info *info) > { > - struct stifb_info *fb = (struct stifb_info *) info; > + struct stifb_info *fb = container_of(info, struct stifb_info, info); > u32 color; > > if (regno >= NR_PALETTE) > @@ -978,7 +978,7 @@ stifb_setcolreg(u_int regno, u_int red, u_int green, > static int > stifb_blank(int blank_mode, struct fb_info *info) > { > - struct stifb_info *fb = (struct stifb_info *) info; > + struct stifb_info *fb = container_of(info, struct stifb_info, info); > int enable = (blank_mode == 0) ? ENABLE : DISABLE; > > switch (fb->id) { > Thanks, queuing the series for 3.18. Tomi
diff --git a/drivers/video/fbdev/stifb.c b/drivers/video/fbdev/stifb.c index cfe8a2f..86621fa 100644 --- a/drivers/video/fbdev/stifb.c +++ b/drivers/video/fbdev/stifb.c @@ -918,7 +918,7 @@ static int stifb_setcolreg(u_int regno, u_int red, u_int green, u_int blue, u_int transp, struct fb_info *info) { - struct stifb_info *fb = (struct stifb_info *) info; + struct stifb_info *fb = container_of(info, struct stifb_info, info); u32 color; if (regno >= NR_PALETTE) @@ -978,7 +978,7 @@ stifb_setcolreg(u_int regno, u_int red, u_int green, static int stifb_blank(int blank_mode, struct fb_info *info) { - struct stifb_info *fb = (struct stifb_info *) info; + struct stifb_info *fb = container_of(info, struct stifb_info, info); int enable = (blank_mode == 0) ? ENABLE : DISABLE; switch (fb->id) {
Use container_of instead of casting first structure member. Signed-off-by: Fabian Frederick <fabf@skynet.be> --- PARISC cross-compiled but untested. drivers/video/fbdev/stifb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)