From patchwork Sat Jun 20 22:46:13 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Grant Grundler X-Patchwork-Id: 31626 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n5KMih6D010795 for ; Sat, 20 Jun 2009 22:46:15 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751147AbZFTWqL (ORCPT ); Sat, 20 Jun 2009 18:46:11 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751200AbZFTWqL (ORCPT ); Sat, 20 Jun 2009 18:46:11 -0400 Received: from complete.lackof.org ([198.49.126.79]:47603 "EHLO complete.lackof.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751147AbZFTWqK (ORCPT ); Sat, 20 Jun 2009 18:46:10 -0400 Received: from localhost (localhost [127.0.0.1]) by complete.lackof.org (Postfix) with ESMTP id 965BD33E005A; Sat, 20 Jun 2009 16:46:13 -0600 (MDT) X-Virus-Scanned: Debian amavisd-new at lackof.org Received: from complete.lackof.org ([127.0.0.1]) by localhost (complete.lackof.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id RTA4dwvOsKkz; Sat, 20 Jun 2009 16:46:13 -0600 (MDT) Received: by complete.lackof.org (Postfix, from userid 27253) id 38DB133E0066; Sat, 20 Jun 2009 16:46:13 -0600 (MDT) Date: Sat, 20 Jun 2009 16:46:13 -0600 From: Grant Grundler To: Kyle McMartin , Helge Deller Cc: linux-parisc@vger.kernel.org Subject: [PATCH][linux-2.6] Fix gcc 4.4 warning in lba_pci.c Message-ID: <20090620224613.GB853@lackof.org> MIME-Version: 1.0 Content-Disposition: inline X-Home-Page: http://www.parisc-linux.org/ User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org gcc 4.4 warns about: drivers/parisc/lba_pci.c: In function 'lba_pat_resources': drivers/parisc/lba_pci.c:1099: warning: the frame size of 8280 bytes is larger than 4096 bytes The problem is we declare two large structures on the stack. They don't need to be on the stack since they are only used during LBA initialization (which is serialized). Moving to be "static". Signed-off-by: Grant Grundler --- -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c index 59fbbf1..7535cb3 100644 --- a/drivers/parisc/lba_pci.c +++ b/drivers/parisc/lba_pci.c @@ -980,13 +980,17 @@ static void lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev) { unsigned long bytecnt; - pdc_pat_cell_mod_maddr_block_t pa_pdc_cell; /* PA_VIEW */ - pdc_pat_cell_mod_maddr_block_t io_pdc_cell; /* IO_VIEW */ long io_count; long status; /* PDC return status */ long pa_count; int i; + /* We don't need additional locking around the use of pdc_pat_cell + ** since init time PDC device discovery is already serialized. + */ + static pdc_pat_cell_mod_maddr_block_t pa_pdc_cell; /* PA_VIEW */ + static pdc_pat_cell_mod_maddr_block_t io_pdc_cell; /* IO_VIEW */ + /* return cell module (IO view) */ status = pdc_pat_cell_module(&bytecnt, pa_dev->pcell_loc, pa_dev->mod_index, PA_VIEW, & pa_pdc_cell);