From patchwork Thu Aug 2 15:02:09 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fengguang Wu X-Patchwork-Id: 1267651 Return-Path: X-Original-To: patchwork-linux-parisc@patchwork.kernel.org Delivered-To: patchwork-process-083081@patchwork2.kernel.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by patchwork2.kernel.org (Postfix) with ESMTP id 8C52FDF223 for ; Thu, 2 Aug 2012 15:02:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751215Ab2HBPC3 (ORCPT ); Thu, 2 Aug 2012 11:02:29 -0400 Received: from mga01.intel.com ([192.55.52.88]:54740 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750786Ab2HBPC1 (ORCPT ); Thu, 2 Aug 2012 11:02:27 -0400 Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP; 02 Aug 2012 08:02:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.71,315,1320652800"; d="scan'208";a="192495593" Received: from unknown (HELO wfg-t420.sh.intel.com) ([10.255.20.172]) by fmsmga001.fm.intel.com with ESMTP; 02 Aug 2012 08:02:13 -0700 Received: from wfg by wfg-t420.sh.intel.com with local (Exim 4.77) (envelope-from ) id 1Swwuf-00073v-K4; Thu, 02 Aug 2012 23:02:09 +0800 Date: Thu, 2 Aug 2012 23:02:09 +0800 From: Fengguang Wu To: linux-alpha@vger.kernel.org Cc: Richard Henderson , Ivan Kokshaysky , Matt Turner , Tony Luck , James Bottomley , John David Anglin , Mel Gorman , kernel-janitors@vger.kernel.org, Kyle McMartin , Andrew Morton , LKML , Parisc List Subject: Re: [next:akpm 129/309] net/core/sock.c:274:36: error: initializer element is not constant Message-ID: <20120802150209.GA26601@localhost> References: <20120722163058.GB13376@localhost> <20120723111619.GT9222@suse.de> <1343042420.3027.11.camel@dabdike.int.hansenpartnership.com> <20120723114258.GV9222@suse.de> <20120723122905.GA22476@localhost> <20120724074844.GA9519@localhost> <1343193053.3139.6.camel@dabdike> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org On Thu, Jul 26, 2012 at 10:06:41AM -0700, Tony Luck wrote: > On Tue, Jul 24, 2012 at 10:10 PM, James Bottomley > wrote: > >> Here is the line in sock.i: > >> > >> struct static_key memalloc_socks = ((struct static_key) { .enabled = > >> ((atomic_t) { (0) }) }); > > > > The above line contains two compound literals. It also uses a designated > > initializer to initialize the field enabled. A compound literal is not a > > constant expression. > > Seeing the same thing on ia64 building next-20120726. Same fix works > for me ... so I'll steal this whole changelog and attributes. I got the same error for alpha, the same fix applies. --- From: Mel Gorman Subject: [PATCH] [ALPHA] Redefine ATOMIC_INIT and ATOMIC64_INIT to drop the casts The following build error occurred during an alpha build: net/core/sock.c:274:36: error: initializer element is not constant Dave Anglin says: > Here is the line in sock.i: > > struct static_key memalloc_socks = ((struct static_key) { .enabled = > ((atomic_t) { (0) }) }); The above line contains two compound literals. It also uses a designated initializer to initialize the field enabled. A compound literal is not a constant expression. The location of the above statement isn't fully clear, but if a compound literal occurs outside the body of a function, the initializer list must consist of constant expressions. Reported-by: Fengguang Wu Signed-off-by: Mel Gorman Cc: --- arch/alpha/include/asm/atomic.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux.orig/arch/alpha/include/asm/atomic.h 2012-05-24 19:03:06.000000000 +0800 +++ linux/arch/alpha/include/asm/atomic.h 2012-08-02 23:01:02.243224220 +0800 @@ -14,8 +14,8 @@ */ -#define ATOMIC_INIT(i) ( (atomic_t) { (i) } ) -#define ATOMIC64_INIT(i) ( (atomic64_t) { (i) } ) +#define ATOMIC_INIT(i) ( { (i) } ) +#define ATOMIC64_INIT(i) ( { (i) } ) #define atomic_read(v) (*(volatile int *)&(v)->counter) #define atomic64_read(v) (*(volatile long *)&(v)->counter)