diff mbox

libseccomp/tests: Report if test was skipped because of missing valgrind

Message ID 20160415150941.GA11180@ls3530.dhcp.wdf.sap.corp (mailing list archive)
State Not Applicable
Headers show

Commit Message

Helge Deller April 15, 2016, 3:09 p.m. UTC
Print a message if a regression test was skipped just because valgrind isn't
installed.

This additional info is useful for architectures (e.g. parisc) which aren't as
fast as x86_64. On parisc it seemed that the whole testcase was hanging, now
people know what's actually happening.

Signed-off-by: Helge Deller <deller@gmx.de>

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Comments

Paul Moore April 18, 2016, 10:37 p.m. UTC | #1
On Friday, April 15, 2016 05:09:41 PM Helge Deller wrote:
> Print a message if a regression test was skipped just because valgrind isn't
> installed.
> 
> This additional info is useful for architectures (e.g. parisc) which aren't
> as fast as x86_64. On parisc it seemed that the whole testcase was hanging,
> now people know what's actually happening.
> 
> Signed-off-by: Helge Deller <deller@gmx.de>

Merged, thanks!

> diff --git a/tests/regression b/tests/regression
> index 53d26b2..5949459 100755
> --- a/tests/regression
> +++ b/tests/regression
> @@ -772,6 +773,7 @@ function run_test() {
>  		if check_deps valgrind; then
>  			run_test_bpf_valgrind "$testnumstr" "$3"
>  		else
> +			print_result $testnumstr "SKIPPED" "(valgrind not installed)"
>  			stats_skipped=$(($stats_skipped+1))
>  		fi
>  	elif [[ "$4" == "live" ]]; then
diff mbox

Patch

diff --git a/tests/regression b/tests/regression
index 53d26b2..5949459 100755
--- a/tests/regression
+++ b/tests/regression
@@ -772,6 +773,7 @@  function run_test() {
 		if check_deps valgrind; then
 			run_test_bpf_valgrind "$testnumstr" "$3"
 		else
+			print_result $testnumstr "SKIPPED" "(valgrind not installed)"
 			stats_skipped=$(($stats_skipped+1))
 		fi
 	elif [[ "$4" == "live" ]]; then