From patchwork Fri Jun 3 17:22:31 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helge Deller X-Patchwork-Id: 9153791 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D42BF6082E for ; Fri, 3 Jun 2016 17:22:52 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C183826E39 for ; Fri, 3 Jun 2016 17:22:52 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B5CFE28304; Fri, 3 Jun 2016 17:22:52 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,FREEMAIL_FROM, RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E437A26E39 for ; Fri, 3 Jun 2016 17:22:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbcFCRWv (ORCPT ); Fri, 3 Jun 2016 13:22:51 -0400 Received: from mout.gmx.net ([212.227.17.22]:63804 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751814AbcFCRWu (ORCPT ); Fri, 3 Jun 2016 13:22:50 -0400 Received: from ls3530.box ([92.203.38.178]) by mail.gmx.com (mrgmx103) with ESMTPSA (Nemesis) id 0MHH3P-1bDVdp15D1-00E1gv; Fri, 03 Jun 2016 19:22:34 +0200 Date: Fri, 3 Jun 2016 19:22:31 +0200 From: Helge Deller To: Aaro Koskinen Cc: Mikulas Patocka , linux-parisc@vger.kernel.org Subject: Re: invalid printk time during boot on PA-RISC Message-ID: <20160603172231.GA4592@ls3530.box> References: <20160601211248.GA15061@p100.box> <20160601213628.GC5218@raspberrypi.musicnaut.iki.fi> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20160601213628.GC5218@raspberrypi.musicnaut.iki.fi> User-Agent: Mutt/1.5.23 (2014-03-12) X-Provags-ID: V03:K0:sGihnU0Tns7Qu6d+sbGWF/HVd1L94A98tkNJngY7Y0p0QUOuOyW XbhGMob7mcBGh6QsseZeFbIit9KFThCGTN+39NFRH44rSLNzV5HqsKyCrKlq9zLuItDrZup hYC/Jrqhgq51y2nLVo9GNCEQaX/AJdqz9O7D5u/m/mWFAO+fQ0jbNdk5tyMVdyCfPqahwvt 3XyjBXgUhk10WzfWrfO6Q== X-UI-Out-Filterresults: notjunk:1; V01:K0:6vhNxKQg3WU=:NuehCY7ktbvHh8iPU0FLqB ARi0cW+QELqP8EI+sz00MiFIiFSYwNksVUNQG/eh4+qX7DiDdvVVpm+fT5LaPSetv0QcSH/yI WKKnQbc4uLvPLKyltYDJPCyaoSrYwh/c7VlbMF24S8FxbJX4aEQJzUQ+gMhY67JvYImOliXXs fmWzMEaTP2NIC9hqreQtOx55U2wl/+naAisgWdtP7juZRDj/bqbXMVfrHMGMrA2z8wPQUmZrS OBrr4BrKm92+vWRVeCiY6qobqt7qoLy7Livu0Hne8IXBnmLgkUSZQW8fQjEZS+WLbJGXhfylK U5Q7BJSoBClMHHcbFQlwJ18dItCPcVH9y7Cgwk6114rewJzgpNO/NFo89Wrpuglu7vXTYLsLr x3RWfxOQO8OgZ8DRPrYb+aJ7/LxWQmvJWmMarWBT9tEbzQsgV/5RCOKNqQLglMW1lcvaI5Lbz bOY2pa/nrarL3TNGHtEUIu4ct8HzEqs6y5z8NPqY8XziwOTl+Z/NTUdQ6AdC5b4/TLBbB2qri pU2yvte1K38lZom1NxiyGweIjqwFPHNFMP4hb2YV+50sLTpq7AwKOlRZEesp1qYVgKvVCcaWb DLBBw3eAltxablvyzMvaavyYajh8FHCSyWgeFFLQUxpBExaOQW/HT0XFZ85SU+AkHoQZx3VNc ecj0B04kDHz4U77F9s8zJSF3kMIKlVlE6Hpk4VHSOvPAvC2gN3AHSeCZ80ozr04bp/+Z2OA5S 8WluknaG0f0XYiojKUPDbwJ5DA6YlYLmqKXkhI42gMND7VjJfR+6XkL/LAY= Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP * Aaro Koskinen : > Hi, > > On Wed, Jun 01, 2016 at 11:12:48PM +0200, Helge Deller wrote: > > It fixes the problem mostly for me, there is just one little glitch > > left, which is that the lines "FP[x] enabled" will still print an > > invalid time. I assume it's because when this text is printed, the > > clock/interrupts for the just booted CPU aren't enabled yet. > > > > I'm not sure it's worth trying to fix that. > > One could print out that info at a later time, or just disabled it. > > > > Helge > > > > [ 5.720014] Enabling PDC_PAT chassis codes support v0.05 > > [ 6.644542] Releasing cpu 1 now, hpa=fffffffffe781000 > > [ 0.196000] FP[1] enabled: Rev 1 Model 20 > > [ 7.088432] CPU(s): 2 out of 2 PA8800 (Mako) at 900.000000 MHz online > > Some tools that analyze boot time based on dmesg might get confused. Yes, valid point. Updated patch below. Helge Reviewed-by: Aaro Koskinen diff --git a/arch/parisc/kernel/processor.c b/arch/parisc/kernel/processor.c index e81ccf1..5adc339 100644 --- a/arch/parisc/kernel/processor.c +++ b/arch/parisc/kernel/processor.c @@ -324,8 +324,9 @@ int init_per_cpu(int cpunum) per_cpu(cpu_data, cpunum).fp_rev = coproc_cfg.revision; per_cpu(cpu_data, cpunum).fp_model = coproc_cfg.model; - printk(KERN_INFO "FP[%d] enabled: Rev %ld Model %ld\n", - cpunum, coproc_cfg.revision, coproc_cfg.model); + if (cpunum == 0) + printk(KERN_INFO "FP[%d] enabled: Rev %ld Model %ld\n", + cpunum, coproc_cfg.revision, coproc_cfg.model); /* ** store status register to stack (hopefully aligned) diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c index 58dd680..31ec99a 100644 --- a/arch/parisc/kernel/time.c +++ b/arch/parisc/kernel/time.c @@ -309,11 +309,6 @@ void __init time_init(void) clocks_calc_mult_shift(&cyc2ns_mul, &cyc2ns_shift, current_cr16_khz, NSEC_PER_MSEC, 0); -#if defined(CONFIG_HAVE_UNSTABLE_SCHED_CLOCK) && defined(CONFIG_64BIT) - /* At bootup only one 64bit CPU is online and cr16 is "stable" */ - set_sched_clock_stable(); -#endif - start_cpu_itimer(); /* get CPU 0 started */ /* register at clocksource framework */