| Message ID | 20161029215243.GA24444@ls3530.box (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
Helge Deller wrote:
> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it.
value value?
On 30.10.2016 11:23, Rolf Eike Beer wrote: > Helge Deller wrote: > >> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it. > > value value? I do see huge value in being able to see where this value is being used. A new developer who uses grep will find the relevant assembler code as well. Helge -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, 31 Oct 2016 10:26:37 +0100 Helge Deller <deller@gmx.de> wrote: > On 30.10.2016 11:23, Rolf Eike Beer wrote: > > Helge Deller wrote: > > > >> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it. > > > > value value? > > I do see huge value in being able to see where this value is being > used. A new developer who uses grep will find the relevant assembler > code as well. Yes, but "value value"! ;-) Regards, jer -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 01.11.2016 19:25, Jeroen Roovers wrote: > On Mon, 31 Oct 2016 10:26:37 +0100 > Helge Deller <deller@gmx.de> wrote: > >> On 30.10.2016 11:23, Rolf Eike Beer wrote: >>> Helge Deller wrote: >>> >>>> LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it. >>> >>> value value? >> >> I do see huge value in being able to see where this value is being >> used. A new developer who uses grep will find the relevant assembler >> code as well. > > Yes, but "value value"! ;-) Yes, I'm blind :-) It took me quite some time (and one additional off-list reminder from Rolf Eike) to understand that you both meant the commit title :-) I'll fix it before I send upstream. Thanks! Helge -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/arch/parisc/kernel/syscall.S b/arch/parisc/kernel/syscall.S index d03422e..d3407cf 100644 --- a/arch/parisc/kernel/syscall.S +++ b/arch/parisc/kernel/syscall.S @@ -100,7 +100,7 @@ set_thread_pointer: .endr /* This address must remain fixed at 0x100 for glibc's syscalls to work */ - .align 256 + .align LINUX_GATEWAY_ADDR linux_gateway_entry: gate .+8, %r0 /* become privileged */ mtsp %r0,%sr4 /* get kernel space into sr4 */
LINUX_GATEWAY_ADDR is defined in unistd.h. Let's use it. Signed-off-by: Helge Deller <deller@gmx.de> -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html