diff mbox series

[04/12] parisc: Move start_cpu_itimer() into __cpuinit section

Message ID 20220325143833.402631-4-deller@gmx.de (mailing list archive)
State Superseded
Headers show
Series [01/12] parisc: Switch from GENERIC_CPU_DEVICES to GENERIC_ARCH_TOPOLOGY | expand

Commit Message

Helge Deller March 25, 2022, 2:38 p.m. UTC
Signed-off-by: Helge Deller <deller@gmx.de>
---
 arch/parisc/kernel/time.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--
2.35.1

Comments

Rolf Eike Beer March 25, 2022, 4:53 p.m. UTC | #1
Am Freitag, 25. März 2022, 15:38:25 CET schrieb Helge Deller:
> Signed-off-by: Helge Deller <deller@gmx.de>
> ---
>  arch/parisc/kernel/time.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
> index 061119a56fbe..4101392bf74d 100644
> --- a/arch/parisc/kernel/time.c
> +++ b/arch/parisc/kernel/time.c
> @@ -150,7 +150,7 @@ static struct clocksource clocksource_cr16 = {
>  	.flags			= CLOCK_SOURCE_IS_CONTINUOUS,
>  };
> 
> -void __init start_cpu_itimer(void)
> +void __cpuinit start_cpu_itimer(void)
>  {
>  	unsigned int cpu = smp_processor_id();
>  	unsigned long next_tick = mfctl(16) + clocktick;

I would have squashed this and 5, 7, and 8 together. None of these patches 
adds any sensible description and all do the same.
Helge Deller March 25, 2022, 5:13 p.m. UTC | #2
On 3/25/22 17:53, Rolf Eike Beer wrote:
> Am Freitag, 25. März 2022, 15:38:25 CET schrieb Helge Deller:
>> Signed-off-by: Helge Deller <deller@gmx.de>
>> ---
>>  arch/parisc/kernel/time.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
>> index 061119a56fbe..4101392bf74d 100644
>> --- a/arch/parisc/kernel/time.c
>> +++ b/arch/parisc/kernel/time.c
>> @@ -150,7 +150,7 @@ static struct clocksource clocksource_cr16 = {
>>  	.flags			= CLOCK_SOURCE_IS_CONTINUOUS,
>>  };
>>
>> -void __init start_cpu_itimer(void)
>> +void __cpuinit start_cpu_itimer(void)
>>  {
>>  	unsigned int cpu = smp_processor_id();
>>  	unsigned long next_tick = mfctl(16) + clocktick;
>
> I would have squashed this and 5, 7, and 8 together. None of these patches
> adds any sensible description and all do the same.

Yes, maybe I'll do that. Keeping them seperate makes handling easier for me.

Helge
diff mbox series

Patch

diff --git a/arch/parisc/kernel/time.c b/arch/parisc/kernel/time.c
index 061119a56fbe..4101392bf74d 100644
--- a/arch/parisc/kernel/time.c
+++ b/arch/parisc/kernel/time.c
@@ -150,7 +150,7 @@  static struct clocksource clocksource_cr16 = {
 	.flags			= CLOCK_SOURCE_IS_CONTINUOUS,
 };

-void __init start_cpu_itimer(void)
+void __cpuinit start_cpu_itimer(void)
 {
 	unsigned int cpu = smp_processor_id();
 	unsigned long next_tick = mfctl(16) + clocktick;