| Message ID | 20240704045133.32400-2-thorsten.blum@toblux.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | parisc: Use max() to improve code | expand |
On 7/4/24 06:51, Thorsten Blum wrote: > Use max() to reduce 4 lines of code to a single line and improve its > readability. > > Fixes the following Coccinelle/coccicheck warning reported by > minmax.cocci: > > WARNING opportunity for max() > > Compile-tested only. > > Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> applied. Thanks! Helge
diff --git a/arch/parisc/kernel/cache.c b/arch/parisc/kernel/cache.c index 483bfafd930c..db531e58d70e 100644 --- a/arch/parisc/kernel/cache.c +++ b/arch/parisc/kernel/cache.c @@ -611,11 +611,7 @@ void __init parisc_setup_cache_timing(void) threshold/1024); set_tlb_threshold: - if (threshold > FLUSH_TLB_THRESHOLD) - parisc_tlb_flush_threshold = threshold; - else - parisc_tlb_flush_threshold = FLUSH_TLB_THRESHOLD; - + parisc_tlb_flush_threshold = max(threshold, FLUSH_TLB_THRESHOLD); printk(KERN_INFO "TLB flush threshold set to %lu KiB\n", parisc_tlb_flush_threshold/1024); }
Use max() to reduce 4 lines of code to a single line and improve its readability. Fixes the following Coccinelle/coccicheck warning reported by minmax.cocci: WARNING opportunity for max() Compile-tested only. Signed-off-by: Thorsten Blum <thorsten.blum@toblux.com> --- arch/parisc/kernel/cache.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)