| Message ID | Pine.LNX.4.64.0907271813310.2682@ask.diku.dk (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, Jul 27, 2009 at 06:13:48PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > pa_pdc_cell has already been tested. It seems that this test should be on the > recently returned value io_pdc_cell. > > A simplified version of the semantic match that finds this problem is as > follows: (http://www.emn.fr/x-info/coccinelle/) > > // <smpl> > @r exists@ > local idexpression x; > expression E; > @@ > > if (x == NULL || ...) { ... when forall > return ...; } > ... when != \(x=E\|x--\|x++\|--x\|++x\|x-=E\|x+=E\|x|=E\|x&=E\|&x\) > ( > *x == NULL > | > *x != NULL > ) > // </smpl> > > Signed-off-by: Julia Lawall <julia@diku.dk> Good catch! Reviewed-by: Grant Grundler <grundler@parisc-linux.org> thanks, grant > --- > drivers/parisc/lba_pci.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c > index ede6146..3aeb327 100644 > --- a/drivers/parisc/lba_pci.c > +++ b/drivers/parisc/lba_pci.c > @@ -992,7 +992,7 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev) > return; > > io_pdc_cell = kzalloc(sizeof(pdc_pat_cell_mod_maddr_block_t), GFP_KERNEL); > - if (!pa_pdc_cell) { > + if (!io_pdc_cell) { > kfree(pa_pdc_cell); > return; > } > -- > To unsubscribe from this list: send the line "unsubscribe linux-parisc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Aug 03, 2009 at 02:33:57PM -0600, Grant Grundler wrote: > Good catch! > > Reviewed-by: Grant Grundler <grundler@parisc-linux.org> > Thanks to both of you. --Kyle -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c index ede6146..3aeb327 100644 --- a/drivers/parisc/lba_pci.c +++ b/drivers/parisc/lba_pci.c @@ -992,7 +992,7 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev) return; io_pdc_cell = kzalloc(sizeof(pdc_pat_cell_mod_maddr_block_t), GFP_KERNEL); - if (!pa_pdc_cell) { + if (!io_pdc_cell) { kfree(pa_pdc_cell); return; }