| Message ID | YUNi6hTcS8nUrrpF@ls3530 (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | [GIT,PULL] parisc architecture warning fix for kernel v5.15-rc2 | expand |
The pull request you sent on Thu, 16 Sep 2021 17:29:46 +0200:
> http://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git tags/for-5.15/parisc-4
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/5fe983d3f1a5b103fc00a24f9e0408302e60c39c
Thank you!
On 9/16/21 8:29 AM, Helge Deller wrote: > Hi Linus, > > please pull one parisc architecture warning fix for kernel 5.15-rc2 from: > > http://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git tags/for-5.15/parisc-4 > > One patch which fixes a build warning when using the PAGE0 pointer. > Grumble: Building parisc:allmodconfig ... failed -------------- Error log: In file included from drivers/net/phy/dp83640.c:23: drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined [-Werror] 8 | #define PAGE0 0x0000 No, I didn't see that coming either. It _was_ there before, I just didn't notice. Looks like that define isn't even used anywhere. I'll send a patch to remove it. Guenter
On 9/16/21 12:45 PM, Guenter Roeck wrote: > On 9/16/21 8:29 AM, Helge Deller wrote: >> Hi Linus, >> >> please pull one parisc architecture warning fix for kernel 5.15-rc2 from: >> >> http://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git tags/for-5.15/parisc-4 >> >> One patch which fixes a build warning when using the PAGE0 pointer. >> > > Grumble: > > Building parisc:allmodconfig ... failed > -------------- > Error log: > In file included from drivers/net/phy/dp83640.c:23: > drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined [-Werror] > 8 | #define PAGE0 0x0000 > > No, I didn't see that coming either. It _was_ there before, I just didn't notice. > > Looks like that define isn't even used anywhere. > I'll send a patch to remove it. Already merged in the net tree.
On 9/16/21 1:03 PM, Randy Dunlap wrote: > On 9/16/21 12:45 PM, Guenter Roeck wrote: >> On 9/16/21 8:29 AM, Helge Deller wrote: >>> Hi Linus, >>> >>> please pull one parisc architecture warning fix for kernel 5.15-rc2 from: >>> >>> http://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git tags/for-5.15/parisc-4 >>> >>> One patch which fixes a build warning when using the PAGE0 pointer. >>> >> >> Grumble: >> >> Building parisc:allmodconfig ... failed >> -------------- >> Error log: >> In file included from drivers/net/phy/dp83640.c:23: >> drivers/net/phy/dp83640_reg.h:8: error: "PAGE0" redefined [-Werror] >> 8 | #define PAGE0 0x0000 >> >> No, I didn't see that coming either. It _was_ there before, I just didn't notice. >> >> Looks like that define isn't even used anywhere. >> I'll send a patch to remove it. > > Already merged in the net tree. > > Ah, ok. Sorry for the noise (I already sent that patch). Guenter
On Thu, Sep 16, 2021 at 1:10 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On 9/16/21 1:03 PM, Randy Dunlap wrote: > > > > Already merged in the net tree. > > Ah, ok. Sorry for the noise (I already sent that patch). Well, I _just_ got the networking pull, so now that particular problem is solved in my tree too. There's a few more from your list, but I _think_ they are at least mostly pending in other trees and patch queues, so I'll ignore them unless told otherwise. But I've literally set aside this week to just get this mess sorted out. Not only do I think it's time to just *fix* these damn warning issues, but usually the week after rc1 is somewhat quiet since it takes a while for people to find regressions. So I have actually spent more time than I would normally consider healthy on code that I in any normal situation wouldn't care about at all. (I realize that Arnd and Guenther are now scoffing at my "normally consider healthy" since they have put even more time into this, but hey, I usually actively try to avoid reading grotty code in areas I don't actually care for). So if somebody is aware of some warning situation that still remains and doesn't seem to have any movement, please point me at all. Maybe we can't force-enable -Wall, but I want us to be really really close. Linus
On Thu, Sep 16, 2021 at 01:25:32PM -0700, Linus Torvalds wrote: > On Thu, Sep 16, 2021 at 1:10 PM Guenter Roeck <linux@roeck-us.net> wrote: > > > > On 9/16/21 1:03 PM, Randy Dunlap wrote: > > > > > > Already merged in the net tree. > > > > Ah, ok. Sorry for the noise (I already sent that patch). > > Well, I _just_ got the networking pull, so now that particular problem > is solved in my tree too. > > There's a few more from your list, but I _think_ they are at least > mostly pending in other trees and patch queues, so I'll ignore them > unless told otherwise. > > But I've literally set aside this week to just get this mess sorted out. > > Not only do I think it's time to just *fix* these damn warning issues, > but usually the week after rc1 is somewhat quiet since it takes a > while for people to find regressions. > > So I have actually spent more time than I would normally consider > healthy on code that I in any normal situation wouldn't care about at > all. > > (I realize that Arnd and Guenther are now scoffing at my "normally > consider healthy" since they have put even more time into this, but > hey, I usually actively try to avoid reading grotty code in areas I > don't actually care for). > > So if somebody is aware of some warning situation that still remains > and doesn't seem to have any movement, please point me at all. Maybe > we can't force-enable -Wall, but I want us to be really really close. > Let's say the list is getting small enough to be able to keep track. Below is my current list of -Werror related build errors, as of v5.15-rc1-164-gbdb575f87217. Guenter --- drivers/spi/spi-tegra20-slink.c:1200:12: error: 'tegra_slink_runtime_resume' defined but not used [-Werror=unused-function] 1200 | static int tegra_slink_runtime_resume(struct device *dev) | ^~~~~~~~~~~~~~~~~~~~~~~~~~ drivers/spi/spi-tegra20-slink.c:1188:12: error: 'tegra_slink_runtime_suspend' defined but not used [-Werror=unused-function] 1188 | static int tegra_slink_runtime_suspend(struct device *dev) Affected builds: alpha:allmodconfig m68k:allmodconfig parisc:allmodconfig s390:allmodconfig Patch: https://lore.kernel.org/lkml/20210907045358.2138282-1-linux@roeck-us.net/ Status: Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next [ I hope that doesn't mean we'll have to wait for v5.16 for a fix ] --- In file included from arch/mips/include/asm/sibyte/sb1250.h:28, from drivers/watchdog/sb_wdog.c:58: arch/mips/include/asm/sibyte/bcm1480_scd.h:261: error: "M_SPC_CFG_CLEAR" redefined In file included from arch/mips/include/asm/sibyte/sb1250.h:28, from drivers/watchdog/sb_wdog.c:58: arch/mips/include/asm/sibyte/bcm1480_scd.h:262: error: "M_SPC_CFG_ENABLE" redefined Affected builds: mips:allmodconfig Patch: https://lore.kernel.org/r/20210913073220.1159520-1-liu.yun@linux.dev Status: Waiting for pull request from Wim --- drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c: In function 'nvkm_control_mthd_pstate_info': drivers/gpu/drm/nouveau/nvkm/engine/device/ctrl.c:60:35: error: overflow in conversion from 'int' to '__s8' {aka 'signed char'} changes value from '-251' to '5' [-Werror=overflow] 60 | args->v0.pwrsrc = -ENOSYS; Affected builds: parisc:allmodconfig Background: args->v0.pwrsrc is s8, -ENOSYS is -251 on parisc Patch: https://lore.kernel.org/lkml/20210908190817.1213486-1-linux@roeck-us.net/ Status: No response as of 9/15 (or I missed it) --- drivers/scsi/ncr53c8xx.c:8000:26: error: 'retrieve_from_waiting_list' defined but not used Affected builds: parisc:allmodconfig Patch: https://lore.kernel.org/r/YTfS/LH5vCN6afDW@ls3530 Status: Applied to 5.15/scsi-fixes --- arch/s390/kernel/syscall.c: In function '__do_syscall': arch/s390/kernel/syscall.c:168:1: error: '__do_syscall' uses dynamic stack allocation lib/test_kasan.c: In function 'kasan_alloca_oob_right': lib/test_kasan.c:782:1: error: 'kasan_alloca_oob_right' uses dynamic stack allocation lib/test_kasan.c: In function 'kasan_alloca_oob_left': lib/test_kasan.c:767:1: error: 'kasan_alloca_oob_left' uses dynamic stack allocation Affected builds: s390:allmodconfig Background: s390 defines a configuration flag to mark dynamic stack allocations as warnings. This causes a build failure with -Werror. Patch: https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git/commit/?h=fixes&id=f5711f9df9242446feccf2bdb6fdc06a72ca1010 Status: Queued in https://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git#fixes --- drivers/video/fbdev/omap2/omapfb/dss/dsi.c: In function 'dsi_dump_dsidev_irqs': drivers/video/fbdev/omap2/omapfb/dss/dsi.c:1623:1: error: the frame size of 1104 bytes is larger than 1024 bytes and many similar errors. Seen in xtensa:allmodconfig. Background: xtensa:allmodconfig enables KASAN which in turn increases stack size requirements significantly. Patch: https://lore.kernel.org/lkml/20210912025235.3514761-1-linux@roeck-us.net/ Status: Queued in https://www.ozlabs.org/~akpm/mmotm/
Hi Linus, please pull one parisc architecture warning fix for kernel 5.15-rc2 from: http://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git tags/for-5.15/parisc-4 One patch which fixes a build warning when using the PAGE0 pointer. Thanks, Helge ------------ The following changes since commit ff1ffd71d5f0612cf194f5705c671d6b64bf5f91: Merge tag 'hyperv-fixes-signed-20210915' of git://git.kernel.org/pub/scm/linux/kernel/git/hyperv/linux (2021-09-15 17:18:56 -0700) are available in the Git repository at: http://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux.git parisc-5.15-4 for you to fetch changes up to 90cc7bed1ed19f869ae7221a6b41887fe762a6a3: parisc: Use absolute_pointer() to define PAGE0 (2021-09-16 08:35:42 +0200) ---------------------------------------------------------------- Helge Deller (1): parisc: Use absolute_pointer() to define PAGE0 arch/parisc/include/asm/page.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)