From patchwork Wed Oct 27 09:04:40 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikulas Patocka X-Patchwork-Id: 285122 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by demeter1.kernel.org (8.14.4/8.14.3) with ESMTP id o9R94goY016160 for ; Wed, 27 Oct 2010 09:04:42 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758697Ab0J0JEm (ORCPT ); Wed, 27 Oct 2010 05:04:42 -0400 Received: from artax.karlin.mff.cuni.cz ([195.113.26.195]:37078 "EHLO artax.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755088Ab0J0JEl (ORCPT ); Wed, 27 Oct 2010 05:04:41 -0400 Received: by artax.karlin.mff.cuni.cz (Postfix, from userid 17421) id E0F3B980B5; Wed, 27 Oct 2010 11:04:40 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by artax.karlin.mff.cuni.cz (Postfix) with ESMTP id DF9D5980AE; Wed, 27 Oct 2010 11:04:40 +0200 (CEST) Date: Wed, 27 Oct 2010 11:04:40 +0200 (CEST) From: Mikulas Patocka To: James Bottomley cc: linux-parisc@vger.kernel.org, linux-scsi@vger.kernel.org, matthew@wil.cx Subject: sym53c8xx_2 data corruption In-Reply-To: <1288155041.19649.354.camel@mulgrave.site> Message-ID: References: <20101027012932.3CB6E4FB4@hiauly1.hia.nrc.ca> <1288155041.19649.354.camel@mulgrave.site> User-Agent: Alpine 1.10 (DEB 962 2008-03-14) X-Personality-Disorder: Schizoid MIME-Version: 1.0 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Greylist: IP, sender and recipient auto-whitelisted, not delayed by milter-greylist-4.2.3 (demeter1.kernel.org [140.211.167.41]); Wed, 27 Oct 2010 09:04:43 +0000 (UTC) Index: linux-2.6.36-rc5-fast/drivers/scsi/sym53c8xx_2/sym_hipd.c =================================================================== --- linux-2.6.36-rc5-fast.orig/drivers/scsi/sym53c8xx_2/sym_hipd.c 2010-09-27 10:25:59.000000000 +0200 +++ linux-2.6.36-rc5-fast/drivers/scsi/sym53c8xx_2/sym_hipd.c 2010-09-27 10:26:27.000000000 +0200 @@ -3000,7 +3000,11 @@ sym_dequeue_from_squeue(struct sym_hcb * if ((target == -1 || cp->target == target) && (lun == -1 || cp->lun == lun) && (task == -1 || cp->tag == task)) { +#ifdef SYM_OPT_HANDLE_DEVICE_QUEUEING sym_set_cam_status(cp->cmd, DID_SOFT_ERROR); +#else + sym_set_cam_status(cp->cmd, DID_REQUEUE); +#endif sym_remque(&cp->link_ccbq); sym_insque_tail(&cp->link_ccbq, &np->comp_ccbq); }