From patchwork Wed Jan 22 19:11:40 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikulas Patocka X-Patchwork-Id: 3524731 Return-Path: X-Original-To: patchwork-linux-parisc@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8E63EC02DC for ; Wed, 22 Jan 2014 19:11:53 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C8FED2016C for ; Wed, 22 Jan 2014 19:11:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D6AA020154 for ; Wed, 22 Jan 2014 19:11:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbaAVTLr (ORCPT ); Wed, 22 Jan 2014 14:11:47 -0500 Received: from mx1.redhat.com ([209.132.183.28]:27782 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752868AbaAVTLr (ORCPT ); Wed, 22 Jan 2014 14:11:47 -0500 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s0MJBg6C007770 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 22 Jan 2014 14:11:42 -0500 Received: from file01.intranet.prod.int.rdu2.redhat.com (file01.intranet.prod.int.rdu2.redhat.com [10.11.5.7]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s0MJBgK1029393 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 22 Jan 2014 14:11:42 -0500 Received: from file01.intranet.prod.int.rdu2.redhat.com (localhost [127.0.0.1]) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4) with ESMTP id s0MJBf1U014623; Wed, 22 Jan 2014 14:11:41 -0500 Received: from localhost (mpatocka@localhost) by file01.intranet.prod.int.rdu2.redhat.com (8.14.4/8.14.4/Submit) with ESMTP id s0MJBeMJ014620; Wed, 22 Jan 2014 14:11:41 -0500 X-Authentication-Warning: file01.intranet.prod.int.rdu2.redhat.com: mpatocka owned process doing -bs Date: Wed, 22 Jan 2014 14:11:40 -0500 (EST) From: Mikulas Patocka X-X-Sender: mpatocka@file01.intranet.prod.int.rdu2.redhat.com To: John David Anglin cc: Helge Deller , linux-parisc@vger.kernel.org Subject: [PATCH] parisc: report inequivalent aliases only for writeable mappings Message-ID: User-Agent: Alpine 2.02 (LRH 1266 2009-07-14) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.68 on 10.5.11.23 Sender: linux-parisc-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-parisc@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Here I'm sending a fix for parisc for Debian 5 userspace. I'm just curious - why are those kmap_atomic and kunmap_atomic overrides needed while other architectures with virtually indexed caches (such as sparc) don't override these functions? It is that the other architectures flush cache at differnet points where parisc doesn't flush it? Mikulas From: Mikulas Patocka The patch f8dae00684d678afa13041ef170cecfd1297ed40 breaks Debian 5 userspace. After application of the patch, you get a lot of INEQUIVALENT ALIASES messages on various dynamic libraries - so many that the system is unbootable. This patch changes it so that INEQUIVALENT ALIASES are only reported for writeable mappings. PA-RISC specification allows inequivalent aliases for read-only mappings, so there's no need to report them as an error. Signed-off-by: Mikulas Patocka Cc: stable@vger.kernel.org --- arch/parisc/kernel/cache.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Index: linux-3.13/arch/parisc/kernel/cache.c =================================================================== --- linux-3.13.orig/arch/parisc/kernel/cache.c 2014-01-20 21:40:18.000000000 +0100 +++ linux-3.13/arch/parisc/kernel/cache.c 2014-01-20 21:43:23.000000000 +0100 @@ -325,7 +325,7 @@ void flush_dcache_page(struct page *page flush_tlb_page(mpnt, addr); if (old_addr == 0 || (old_addr & (SHMLBA - 1)) != (addr & (SHMLBA - 1))) { __flush_cache_page(mpnt, addr, page_to_phys(page)); - if (old_addr) + if (old_addr && unlikely(mapping->i_mmap_writable != 0)) printk(KERN_ERR "INEQUIVALENT ALIASES 0x%lx and 0x%lx in file %s\n", old_addr, addr, mpnt->vm_file ? (char *)mpnt->vm_file->f_path.dentry->d_name.name : "(null)"); old_addr = addr; }