| Message ID | 20210824122054.29481-1-joro@8bytes.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | PCI/ACPI: Simplify PCIe _OSC feature negotiation | expand |
On Tue, Aug 24, 2021 at 2:21 PM Joerg Roedel <joro@8bytes.org> wrote: > > From: Joerg Roedel <jroedel@suse.de> > > Hi, > > here is the third version of my patches to simplify the _OSC > negotiation of PCIe features between Linux and the firmware. > > This version is a complete rewrite, so there is no changelog to the > previous version. Patches 1-3 are cleanups and small restructurings of > the code as a preparation for patch 4. > > The last patch gets rid of the dedicated _OSC query to check for _OSC > support and merges that functionality into acpi_pci_osc_control_set(). > > This allows to simplify and/or remove other functions and consilidate > error handling in negotiate_os_control(). > > I have tested the patches with and without 'pcie_ports=compat' and > found no regressions on my test machine. I have reviewed the patches, so if you want me to queue up this series, please let me know. Thanks, Rafael > Joerg Roedel (4): > PCI/ACPI: Remove OSC_PCI_SUPPORT_MASKS and OSC_PCI_CONTROL_MASKS > PCI/ACPI: Move supported and control calculations to separaten > functions > PCI/ACPI: Move _OSC query checks to separate function > PCI/ACPI: Check for _OSC support in acpi_pci_osc_control_set() > > drivers/acpi/pci_root.c | 161 +++++++++++++++++++++------------------- > include/linux/acpi.h | 2 - > 2 files changed, 84 insertions(+), 79 deletions(-) > > -- > 2.32.0 >
On Wed, Sep 1, 2021 at 9:33 PM Rafael J. Wysocki <rafael@kernel.org> wrote: > > On Tue, Aug 24, 2021 at 2:21 PM Joerg Roedel <joro@8bytes.org> wrote: > > > > From: Joerg Roedel <jroedel@suse.de> > > > > Hi, > > > > here is the third version of my patches to simplify the _OSC > > negotiation of PCIe features between Linux and the firmware. > > > > This version is a complete rewrite, so there is no changelog to the > > previous version. Patches 1-3 are cleanups and small restructurings of > > the code as a preparation for patch 4. > > > > The last patch gets rid of the dedicated _OSC query to check for _OSC > > support and merges that functionality into acpi_pci_osc_control_set(). > > > > This allows to simplify and/or remove other functions and consilidate > > error handling in negotiate_os_control(). > > > > I have tested the patches with and without 'pcie_ports=compat' and > > found no regressions on my test machine. > > I have reviewed the patches, so if you want me to queue up this > series, please let me know. Should I assume that Bjorn will be taking it?
On Mon, Sep 13, 2021 at 06:14:38PM +0200, Rafael J. Wysocki wrote:
> Should I assume that Bjorn will be taking it?
No idea, checking git-log on the file shows mixed Signed-off-bys from
both of you. Bjorn?
Joerg
On Tue, Sep 14, 2021 at 8:50 AM Joerg Roedel <joro@8bytes.org> wrote: > > On Mon, Sep 13, 2021 at 06:14:38PM +0200, Rafael J. Wysocki wrote: > > Should I assume that Bjorn will be taking it? > > No idea, checking git-log on the file shows mixed Signed-off-bys from > both of you. Bjorn? I'll merge it, hopefully this week. Thanks! Bjorn
On Tue, Aug 24, 2021 at 02:20:50PM +0200, Joerg Roedel wrote: > From: Joerg Roedel <jroedel@suse.de> > > Hi, > > here is the third version of my patches to simplify the _OSC > negotiation of PCIe features between Linux and the firmware. > > This version is a complete rewrite, so there is no changelog to the > previous version. Patches 1-3 are cleanups and small restructurings of > the code as a preparation for patch 4. > > The last patch gets rid of the dedicated _OSC query to check for _OSC > support and merges that functionality into acpi_pci_osc_control_set(). > > This allows to simplify and/or remove other functions and consilidate > error handling in negotiate_os_control(). > > I have tested the patches with and without 'pcie_ports=compat' and > found no regressions on my test machine. > > Please review. > > Thanks, > > Joerg > > > > Joerg Roedel (4): > PCI/ACPI: Remove OSC_PCI_SUPPORT_MASKS and OSC_PCI_CONTROL_MASKS > PCI/ACPI: Move supported and control calculations to separaten > functions > PCI/ACPI: Move _OSC query checks to separate function > PCI/ACPI: Check for _OSC support in acpi_pci_osc_control_set() > > drivers/acpi/pci_root.c | 161 +++++++++++++++++++++------------------- > include/linux/acpi.h | 2 - > 2 files changed, 84 insertions(+), 79 deletions(-) Applied with Rafael's reviewed-by to pci/acpi for v5.16, thanks!
On Tue, Sep 28, 2021 at 04:21:19PM -0500, Bjorn Helgaas wrote:
> Applied with Rafael's reviewed-by to pci/acpi for v5.16, thanks!
Thanks Bjorn!
From: Joerg Roedel <jroedel@suse.de> Hi, here is the third version of my patches to simplify the _OSC negotiation of PCIe features between Linux and the firmware. This version is a complete rewrite, so there is no changelog to the previous version. Patches 1-3 are cleanups and small restructurings of the code as a preparation for patch 4. The last patch gets rid of the dedicated _OSC query to check for _OSC support and merges that functionality into acpi_pci_osc_control_set(). This allows to simplify and/or remove other functions and consilidate error handling in negotiate_os_control(). I have tested the patches with and without 'pcie_ports=compat' and found no regressions on my test machine. Please review. Thanks, Joerg Joerg Roedel (4): PCI/ACPI: Remove OSC_PCI_SUPPORT_MASKS and OSC_PCI_CONTROL_MASKS PCI/ACPI: Move supported and control calculations to separaten functions PCI/ACPI: Move _OSC query checks to separate function PCI/ACPI: Check for _OSC support in acpi_pci_osc_control_set() drivers/acpi/pci_root.c | 161 +++++++++++++++++++++------------------- include/linux/acpi.h | 2 - 2 files changed, 84 insertions(+), 79 deletions(-)