From patchwork Fri Jun 10 08:25:16 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Serge Semin X-Patchwork-Id: 12876686 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D7275CCA47E for ; Fri, 10 Jun 2022 08:27:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347751AbiFJI1w (ORCPT ); Fri, 10 Jun 2022 04:27:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55194 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347681AbiFJI1S (ORCPT ); Fri, 10 Jun 2022 04:27:18 -0400 Received: from mail.baikalelectronics.com (mail.baikalelectronics.com [87.245.175.230]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4DAAC3632F; Fri, 10 Jun 2022 01:25:39 -0700 (PDT) Received: from mail (mail.baikal.int [192.168.51.25]) by mail.baikalelectronics.com (Postfix) with ESMTP id 405A1BC2; Fri, 10 Jun 2022 11:26:29 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mail.baikalelectronics.com 405A1BC2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baikalelectronics.ru; s=mail; t=1654849589; bh=sSvmEoKnS0Q48Z7+B6sKqRXaTkR30D+sNc3/WMwcAeA=; h=From:To:CC:Subject:Date:From; b=faeDf/bSiSC2BsoOq6zJMRT1k+wuUP04UqKdqJvoT+3CumVqVLGVgfke3gjGvA22U dUlwGJWzvVTwf4dF5bcAvThOFjruUOywWgBI0+539WcJpgz/UKuaZ+qSFohGTBbeNq 0LD+usx1/kECRuH2Y1sMPEGokNyA4zCxjGhuF0mI= Received: from localhost (192.168.53.207) by mail (192.168.51.25) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 10 Jun 2022 11:25:36 +0300 From: Serge Semin To: Rob Herring , Bjorn Helgaas , Lorenzo Pieralisi CC: Serge Semin , Serge Semin , Alexey Malahov , Pavel Parkhomenko , Jingoo Han , Gustavo Pimentel , =?utf-8?q?Krzysztof_Wilcz?= =?utf-8?q?y=C5=84ski?= , Frank Li , Manivannan Sadhasivam , , Subject: [PATCH v4 00/18] PCI: dwc: Various fixes and cleanups Date: Fri, 10 Jun 2022 11:25:16 +0300 Message-ID: <20220610082535.12802-1-Sergey.Semin@baikalelectronics.ru> MIME-Version: 1.0 X-ClientProxiedBy: MAIL.baikal.int (192.168.51.25) To mail (192.168.51.25) Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This patchset is a first one in the series created in the framework of my Baikal-T1 PCIe/eDMA-related work: [1: In-progress v4] PCI: dwc: Various fixes and cleanups Link: ---you are looking at it--- [2: In-progress v2] PCI: dwc: Add hw version and dma-ranges support Link: https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@baikalelectronics.ru/ [3: In-progress v2] PCI: dwc: Add extended YAML-schema and Baikal-T1 support Link: https://lore.kernel.org/linux-pci/20220503214638.1895-1-Sergey.Semin@baikalelectronics.ru/ [4: In-progress v2] dmaengine: dw-edma: Add RP/EP local DMA support Link: https://lore.kernel.org/linux-pci/20220503225104.12108-1-Sergey.Semin@baikalelectronics.ru/ Note it is very recommended to merge the patchsets in the same order as they are placed in the list above in order to prevent possible merge conflicts. Nothing prevents them from being reviewed synchronously though. Any tests are very welcome! As it can be easily inferred from the patchset title, this series is about the DW PCIe Root Port/Endpoint driver fixes and the code cleanups, where fixes come before the cleanup patches. The patchset starts with adding the stop_link() platform-specific method invocation in case of the PCIe host probe procedure errors. It has been missing in the cleanup-on-error path of the DW PCIe Host initialization method. After that the unrolled CSRs layout is added to the iATU disable procedure. In third the disable iATU procedure is fixed to be called only for the internal ATU as being specific for the internal ATU implementation. Then the outbound iATU extended region setup procedure is fixed to have the INCREASE_REGION_SIZE flag set based on the limit-address - not the region size one. The last but not least the CDM-check enabling procedure is fixed to be independent from the non-related num_lanes field state. Afterwards there is a series of cleanups. It concerns the changes like adding braces to the multi-line if-else constructions, trailing new-lines to the print format-string, dropping unnecessary version checking, and various code simplifications and optimizations. New features like adding two-level DT bindings abstraction, adding better structured IP-core version interface, adding iATU regions size detection and the PCIe regions verification procedure, adding dma-ranges support, introducing a set of generic platform clocks and resets and finally adding Baikal-T1 PCIe interface support will be submitted in the next part of the series. Link: https://lore.kernel.org/linux-pci/20220324012524.16784-1-Sergey.Semin@baikalelectronics.ru/ Changelog v2: - Fix the end address of the example in the patch log with the INCREASE_REGION_SIZE flag usage fixup. It should be 0x1000FFFF and not 0x0000FFFF (@Manivannan). - Add the cleanup-on-error path to the dw_pcie_ep_init() function. (@Manivannan) Link: https://lore.kernel.org/linux-pci/20220503212300.30105-1-Sergey.Semin@baikalelectronics.ru/ Changelog v3: - Convert region variable type to u32 in order to fix the implicit type conversion peculiarity. (@kbot) - Rebase onto v5.18-rc6. Link: https://lore.kernel.org/linux-pci/20220517125058.18488-1-Sergey.Semin@baikalelectronics.ru/ Changelog v4: - Move the patch "PCI: dwc: Deallocate EPC memory on EP init error" to being applied before the cleanup patches. - Add a new fixes patch: "PCI: dwc: Enable CDM-check independently from the num_lanes value". - Add a new cleanup patch: "PCI: dwc: Organize local variables usage". - Add a new cleanup patch: "PCI: dwc: Re-use local pointer to the resource data". - Add a new cleanup patch: "PCI: dwc: Add start_link/stop_link inliners". - Add a new cleanup patch: "PCI: dwc: Move io_cfg_atu_shared to the Root Port descriptor". - Add a new cleanup patch: "PCI: dwc: Add dw_ prefix to the pcie_port structure name". - Drop the patch "PCI: dwc: Don't use generic IO-ops for DBI-space access". (@Rob) - Drop Manivannan tested tag from the changed patches. - Rebase onto v5.18. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Pavel Parkhomenko Cc: Jingoo Han Cc: Gustavo Pimentel Cc: "Krzysztof Wilczyński" Cc: Frank Li Cc: Manivannan Sadhasivam Cc: linux-pci@vger.kernel.org Cc: linux-kernel@vger.kernel.org Serge Semin (18): PCI: dwc: Stop link in the host init error and de-initialization PCI: dwc: Add unroll iATU space support to the regions disable method PCI: dwc: Disable outbound windows for controllers with iATU PCI: dwc: Set INCREASE_REGION_SIZE flag based on limit address PCI: dwc: Deallocate EPC memory on EP init error PCI: dwc: Enable CDM-check independently from the num_lanes value PCI: dwc: Add braces to the multi-line if-else statements PCI: dwc: Add trailing new-line literals to the log messages PCI: dwc: Discard IP-core version checking on unrolled iATU detection PCI: dwc: Convert Link-up status method to using dw_pcie_readl_dbi() PCI: dwc: Organize local variables usage PCI: dwc: Re-use local pointer to the resource data PCI: dwc: Add start_link/stop_link inliners PCI: dwc: Move io_cfg_atu_shared to the Root Port descriptor PCI: dwc: Add dw_ prefix to the pcie_port structure name PCI: dwc-plat: Simplify the probe method return value handling PCI: dwc-plat: Discard unused regmap pointer PCI: dwc-plat: Drop dw_plat_pcie_of_match forward declaration drivers/pci/controller/dwc/pci-dra7xx.c | 12 +- drivers/pci/controller/dwc/pci-exynos.c | 6 +- drivers/pci/controller/dwc/pci-imx6.c | 6 +- drivers/pci/controller/dwc/pci-keystone.c | 20 ++-- .../pci/controller/dwc/pci-layerscape-ep.c | 12 -- drivers/pci/controller/dwc/pci-layerscape.c | 2 +- drivers/pci/controller/dwc/pci-meson.c | 2 +- drivers/pci/controller/dwc/pcie-al.c | 6 +- drivers/pci/controller/dwc/pcie-armada8k.c | 4 +- drivers/pci/controller/dwc/pcie-artpec6.c | 4 +- .../pci/controller/dwc/pcie-designware-ep.c | 30 +++-- .../pci/controller/dwc/pcie-designware-host.c | 104 ++++++++++-------- .../pci/controller/dwc/pcie-designware-plat.c | 25 +---- drivers/pci/controller/dwc/pcie-designware.c | 72 +++++++----- drivers/pci/controller/dwc/pcie-designware.h | 46 +++++--- drivers/pci/controller/dwc/pcie-dw-rockchip.c | 4 +- drivers/pci/controller/dwc/pcie-fu740.c | 2 +- drivers/pci/controller/dwc/pcie-histb.c | 10 +- drivers/pci/controller/dwc/pcie-intel-gw.c | 6 +- drivers/pci/controller/dwc/pcie-keembay.c | 4 +- drivers/pci/controller/dwc/pcie-kirin.c | 2 +- drivers/pci/controller/dwc/pcie-qcom.c | 4 +- drivers/pci/controller/dwc/pcie-spear13xx.c | 6 +- drivers/pci/controller/dwc/pcie-tegra194.c | 22 ++-- drivers/pci/controller/dwc/pcie-uniphier.c | 10 +- drivers/pci/controller/dwc/pcie-visconti.c | 6 +- 26 files changed, 225 insertions(+), 202 deletions(-)