From patchwork Tue Oct 25 00:44:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "David E. Box" X-Patchwork-Id: 13018403 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C605C38A2D for ; Tue, 25 Oct 2022 01:19:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230259AbiJYBTw (ORCPT ); Mon, 24 Oct 2022 21:19:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231778AbiJYBT2 (ORCPT ); Mon, 24 Oct 2022 21:19:28 -0400 Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9BAC71016; Mon, 24 Oct 2022 17:44:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666658652; x=1698194652; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=aIsDlS0Elz1Mcqzl683Iegm+ITd+1RVsEuG7flAObfI=; b=hDWXX0dIonP9JPhyULSavvarN/tFMrkQGefalDR5aOTN4tGzP+QtRJRf 8ShtS+LkE/DR50EsuPuQ8niOWnQynUvsKBxUcOi8ZGx3ZhzQjKz1wVvSk QBFRYGOfJ7rWDdqbgE0GSunKSm2nhPc/UkkKxT5IPfkfOc7/IB5PqrgrT hD5Lb4Ox2xMLPperzYtdgZTagkSSInQTgJadsc75tOm2kLXgTqNaE/R9x 0cfaHRVjabs2tyjbnfgZRBpJDy+XNgINw5BwE1IXCC3SfUppzhQEcmRiA Ax+k4pt8SY9JfDdky8xoGx7PgsqDcmf/kdImSsUa7VXjOSaGuKpX7o3ro A==; X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="290858168" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="290858168" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Oct 2022 17:44:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10510"; a="694758215" X-IronPort-AV: E=Sophos;i="5.95,210,1661842800"; d="scan'208";a="694758215" Received: from linux.intel.com ([10.54.29.200]) by fmsmga008.fm.intel.com with ESMTP; 24 Oct 2022 17:44:11 -0700 Received: from debox1-desk4.intel.com (unknown [10.209.125.134]) by linux.intel.com (Postfix) with ESMTP id 4D303580897; Mon, 24 Oct 2022 17:44:11 -0700 (PDT) From: "David E. Box" To: nirmal.patel@linux.intel.com, jonathan.derrick@linux.dev, lorenzo.pieralisi@arm.com, hch@infradead.org, kw@linux.com, robh@kernel.org, bhelgaas@google.com, david.e.box@linux.intel.com, michael.a.bottini@intel.com, rafael@kernel.org, me@adhityamohan.in Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V7 0/4] PCI: vmd: Enable PCIe ASPM and LTR on select hardware Date: Mon, 24 Oct 2022 17:44:07 -0700 Message-Id: <20221025004411.2910026-1-david.e.box@linux.intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org This series adds a work around for enabling PCIe ASPM and for setting PCIe LTR values on VMD reserved root ports on select platforms. While configuration of these capabilities is usually done by BIOS, on these platforms these capabilities will not be configured because the ports are not visible to BIOS. This was part of an initial design that expected the driver to completely handle the ports, including power management. However on Linux those ports are still managed by the PCIe core, which has the expectation that they adhere to device standards including BIOS configuration, leading to this problem. The target platforms are Tiger Lake, Alder Lake, and Raptor Lake though the latter has already implemented support for configuring the LTR values. Meteor Lake is expected add BIOS ASPM support, eliminating the future need for this work around. Note, the driver programs the LTRs because BIOS would also normally do this for devices that do not set them by default. Without this, SoC power management would be blocked on those platform. This SoC specific value is the maximum latency required to allow the SoC to enter the deepest power state. This patch addresses the following open bugzillas on VMD enabled laptops that cannot enter low power states. Link: https://bugzilla.kernel.org/show_bug.cgi?id=212355 Link: https://bugzilla.kernel.org/show_bug.cgi?id=215063 Link: https://bugzilla.kernel.org/show_bug.cgi?id=213717 David E. Box (3): PCI: vmd: Use PCI_VDEVICE in device list PCI: vmd: Add vmd_device_data PCI: vmd: Add quirk to configure PCIe ASPM and LTR Michael Bottini (1): PCI/ASPM: Add pci_enable_link_state() drivers/pci/controller/vmd.c | 158 +++++++++++++++++++++++++++-------- drivers/pci/pcie/aspm.c | 54 ++++++++++++ include/linux/pci.h | 7 ++ 3 files changed, 186 insertions(+), 33 deletions(-) base-commit: 247f34f7b80357943234f93f247a1ae6b6c3a740