From patchwork Fri Jun 23 14:40:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13290746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E8BBBEB64D7 for ; Fri, 23 Jun 2023 14:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231147AbjFWOlU (ORCPT ); Fri, 23 Jun 2023 10:41:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231688AbjFWOlN (ORCPT ); Fri, 23 Jun 2023 10:41:13 -0400 Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BFC51B4 for ; Fri, 23 Jun 2023 07:41:08 -0700 (PDT) Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-763d6e8e286so55852685a.0 for ; Fri, 23 Jun 2023 07:41:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1687531267; x=1690123267; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1qoeaOs3mg4C8x/f28b+enrCuX2UR5msJGKgFyz/FK4=; b=M/lYlfNg0Cdmtk9VHtgpjxWm3wVvK8MA7rPKZb2Kpx7iZl1WN6y13/ZPrtyj8vSvFQ 7b1BI6ny8w56ekeC6d2z0vhUXlrP2kAqXKpl5hTw5HQyjGoybjTBWLq/aGQT8IIR/fNH vcX7f1t+1m0zKdZS4w3NxWMqTMpUhNNCiRfVw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687531267; x=1690123267; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1qoeaOs3mg4C8x/f28b+enrCuX2UR5msJGKgFyz/FK4=; b=lAqAla2ipp7poHTQsv21JEmNyE7zRwe7hHxrcwyRv24Sti/LIYX46BV+TAopOU5pDP RJ71uZo8j5jaEoYdvjSo7fbm8fAfRE1AoD3Dg+XhAsempQz4SR19GOvZcticnI3FccR9 JUHVlUgcCyd82lS06DMuqfEageaqzoz9e2ai2gnZbBPjGj5pyW1IxQxykW2W32mle3j+ DVk3KjCmH1ZJ9pR2rmAjLSAH4Kke4ZXIzC7A8vRL9M7sPgty4dsrm3SYXOnBefDKx7Ri +LBwA5dQtL4ye5By27pF45HoOf/62pmcGANz7DTniclCYm7tt93ERoNjWIaHu8LZ/8TM ZNSw== X-Gm-Message-State: AC+VfDzfqlrOZfsTZ8LhUBIvT+Et7BoBqvvYIP1LFVCktoBw0ZjJL3um tZP47WT1BGl2yOSQ0nFGKavJ+W1EXhfMMLIp9vLoVNowf6Qeit6m2FcfzmGZmN1PYQBrBRF13HX /pfMNkcKJKPjigEFo3kgWMelBw7VgiiBLpf7Avx+IIncX1FT151rCEmSRFOsM3CPx0+HnhRemvB dkBmoGO9uf0A== X-Google-Smtp-Source: ACHHUZ4IhPOL36VKR59tEJb2o3jA3l9pE226IcXVgSMSrQ3gKkdN8Hy1S9e4HdB1zSqef7hIlazxqw== X-Received: by 2002:a05:620a:2b47:b0:75b:23a1:40f with SMTP id dp7-20020a05620a2b4700b0075b23a1040fmr21782878qkb.37.1687531266514; Fri, 23 Jun 2023 07:41:06 -0700 (PDT) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id i18-20020a05620a145200b007625382f4ccsm4564613qkl.69.2023.06.23.07.41.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 07:41:06 -0700 (PDT) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , =?utf-8?q?Krzyszto?= =?utf-8?q?f_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi , Rob Herring Subject: [PATCH v6 0/5] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Date: Fri, 23 Jun 2023 10:40:53 -0400 Message-Id: <20230623144100.34196-1-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org v6 -- No code has been changed. -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) -- Changed sign-off and author email address for all commits. This was due to a change in Broadcom's upstreaming policy. v5 -- Remove DT property "brcm,completion-timeout-us" from "DT bindings" commit. Although this error may be reported as a completion timeout, its cause was traced to an internal bus timeout which may occur even when there is no PCIe access being processed. We set a timeout of four seconds only if we are operating in "L1SS CLKREQ#" mode. -- Correct CEM 2.0 reference provided by HW engineer, s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) -- Add newline to dev_info() string (Stefan) -- Change variable rval to unsigned (Stefan) -- s/implementaion/implementation/ (Bjorn) -- s/superpowersave/powersupersave/ (Bjorn) -- Slightly modify message on "PERST#" commit. -- Rebase to torvalds master v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC driver probe() time. This is done in Raspian Linux and its absence may be the cause of a failing test case. -- New commit that removes stale comment. v3 -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) -- Put binding names in DT commit Subject (Bjorn) -- Add a verb to a commit's subject line (Bjorn) -- s/accomodat(\w+)/accommodat$1/g (Bjorn) -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) v2 -- Changed binding property 'brcm,completion-timeout-msec' to 'brcm,completion-timeout-us'. (StefanW for standard suffix). -- Warn when clamping timeout value, and include clamped region in message. Also add min and max in YAML. (StefanW) -- Qualify description of "brcm,completion-timeout-us" so that it refers to PCIe transactions. (StefanW) -- Remvove mention of Linux specifics in binding description. (StefanW) -- s/clkreq#/CLKREQ#/g (Bjorn) -- Refactor completion-timeout-us code to compare max and min to value given by the property (as opposed to the computed value). v1 -- The current driver assumes the downstream devices can provide CLKREQ# for ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle L1SS-capable devices. -- The Raspian Linux folks have already been using a PCIe RC property "brcm,enable-l1ss". These commits use the same property, in a backward-compatible manner, and the implementaion adds more detail and also automatically identifies devices w/o a clkreq# signal, i.e. most devices plugged into an RPi CM4 IO board. Jim Quinlan (5): dt-bindings: PCI: brcmstb: Add brcm,enable-l1ss property PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device PCI: brcmstb: Set higher value for internal bus timeout PCI: brcmstb: Assert PERST# on BCM2711 PCI: brcmstb: Remove stale comment .../bindings/pci/brcm,stb-pcie.yaml | 9 ++ drivers/pci/controller/pcie-brcmstb.c | 91 ++++++++++++++++--- 2 files changed, 89 insertions(+), 11 deletions(-) base-commit: 8a28a0b6f1a1dcbf5a834600a9acfbe2ba51e5eb