From patchwork Mon Jul 31 16:57:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13335058 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C131C04FE0 for ; Mon, 31 Jul 2023 16:57:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233617AbjGaQ5a (ORCPT ); Mon, 31 Jul 2023 12:57:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54752 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233591AbjGaQ53 (ORCPT ); Mon, 31 Jul 2023 12:57:29 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A922E1729; Mon, 31 Jul 2023 09:57:28 -0700 (PDT) Received: from jupiter.universe (dyndsl-091-248-210-008.ewe-ip-backbone.de [91.248.210.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: sre) by madras.collabora.co.uk (Postfix) with ESMTPSA id 154256606FCD; Mon, 31 Jul 2023 17:57:27 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1690822647; bh=6bj7q3XOaZvPQ3D5Rpuxi1xUU41U8fTcdodRo9gr6cE=; h=From:To:Cc:Subject:Date:From; b=IApEo06CLoOTI/+bDpJ3jlireiem32kItGql8+F4MK6pufskhhq3WdFUR8SmKvKPk s4QgT45kZvAvV984+0JWSFthWTHDx7HKAztaAE6Tbr6H8uZ6rJo/bwS3asLS8/i2/I A/MuaptY26x6o6KPihalOQc1wKOvDUnTZfALpdA+gq1lZQOlaSyC62hDr4KK9nYADm yT02J8Omgsbf/1G14+Yuo3BTfqB5GsGb5PJ1DCSSV2i6eBzSAXA2kfU4iHp0TnGCvf Uq2r2xTz9ohyZUVj5KtYjyBxawoSuTs9jjrAvsBWu+/RjHQ4hGgtxu7Op/B5EB1fGJ PkCDHhpXQH6eA== Received: by jupiter.universe (Postfix, from userid 1000) id 274C9480099; Mon, 31 Jul 2023 18:57:25 +0200 (CEST) From: Sebastian Reichel To: linux-pci@vger.kernel.org, linux-rockchip@lists.infradead.org, Serge Semin Cc: Jingoo Han , Gustavo Pimentel , Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Shawn Lin , Simon Xue , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Sebastian Reichel , kernel@collabora.com Subject: [PATCH v4 0/5] RK3588 PCIe2 support Date: Mon, 31 Jul 2023 18:57:18 +0200 Message-Id: <20230731165723.53069-1-sebastian.reichel@collabora.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org Hi, This adds PCIe v2 support for RK3588. The series has been tested with the onboard RTL8125 network card on Rockchip RK3588 EVB1 (&pcie2x1l1) and Radxa Rock 5B (&pcie2x1l2). Changes since v3: * https://lore.kernel.org/all/20230717172651.64324-1-sebastian.reichel@collabora.com/ * Remove unneeded quotes in patch 1 (msi handling) * Update patch description of patch 2 (interrupt names) adding information about Rockchip specific parts Changes since v2: * https://lore.kernel.org/all/20230713171851.73052-1-sebastian.reichel@collabora.com/ * Removed num-ib-windows/num-ob-windows/num-viewport from DT * Added patch making 'msi' irq optional, if 'msi-map' property is available * Updated binding according two discussion with Serge Semin, I provided two options by adding one extra patch that should be squashed into the main one or dropped depending on preferences from DT binding maintainers. * Collected Reviewed-by/Tested-by from Jagan Teki Changes since v1: * https://lore.kernel.org/all/20230616170022.76107-1-sebastian.reichel@collabora.com/ * Dropped patch adding 'RK3588' (queued by Rob) * Updated patch adding legacy-interrupt-controller according to comments from Rob and Serge - added missing additionalProperties: false - added all properties to new required property - removed useless quotes around interrupt-controller - added Rob's Reviewed-by * Updated patch adding the missing RK356x/RK3588 interrupt names, so that it provides more details about the interrupts * Updated the DT patch according to the comment from Jonas Karlman, so that the addresses are in 32 bit address space starting at 0x40000000 [0] https://lore.kernel.org/all/20230612171337.74576-1-sebastian.reichel@collabora.com/ Thanks, -- Sebastian Sebastian Reichel (5): dt-bindings: PCI: dwc: improve msi handling dt-bindings: PCI: dwc: rockchip: Fix interrupt-names issue dt-bindings: PCI: dwc: rockchip: Use generic binding dt-bindings: PCI: dwc: rockchip: Add missing legacy-interrupt-controller arm64: dts: rockchip: rk3588: add PCIe2 support .../bindings/pci/rockchip-dw-pcie.yaml | 70 ++++++++++++ .../devicetree/bindings/pci/snps,dw-pcie.yaml | 18 +++- arch/arm64/boot/dts/rockchip/rk3588.dtsi | 51 +++++++++ arch/arm64/boot/dts/rockchip/rk3588s.dtsi | 102 ++++++++++++++++++ 4 files changed, 237 insertions(+), 4 deletions(-)