From patchwork Mon Nov 13 18:56:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jim Quinlan X-Patchwork-Id: 13454334 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E18B0C4332F for ; Mon, 13 Nov 2023 18:56:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230116AbjKMS4S (ORCPT ); Mon, 13 Nov 2023 13:56:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50118 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229521AbjKMS4S (ORCPT ); Mon, 13 Nov 2023 13:56:18 -0500 Received: from mail-oi1-x22a.google.com (mail-oi1-x22a.google.com [IPv6:2607:f8b0:4864:20::22a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E977A10F4 for ; Mon, 13 Nov 2023 10:56:14 -0800 (PST) Received: by mail-oi1-x22a.google.com with SMTP id 5614622812f47-3b5714439b3so2114572b6e.3 for ; Mon, 13 Nov 2023 10:56:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1699901773; x=1700506573; darn=vger.kernel.org; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AT3SaAlBCjShcNR1fo0V+zBbHzaXyrr9yH+4swUMbgU=; b=DHoWNFnxyfAIli7Ec/l9fvuiKFT4zXMPm5CXtKVtKRmmOOXJBsfksCvP+DFd4/4qhy 8rmPUEOyD5AttPx82MnHA8rYj8E1ldMdoeO8PQsbtor1ohJHUQbfUEGyjQB53IDMDy85 KgLJth+/X55EY6PQdQ9i+UgtenwTfdjJUyoHM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699901773; x=1700506573; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AT3SaAlBCjShcNR1fo0V+zBbHzaXyrr9yH+4swUMbgU=; b=aCHbTowTu7agGPuSxt0LfwpdMzUoYYfiAoKSRnUe6uc9SjiEYYZkX5/twNf1JYGBS9 FM+1pSkNw1cNg/h7l6JrL+ATCc/2jwMRscS9Dy7Z5BytioPm1Pj2c8RAN92oz+hbhGf1 ubBPgQ6AngFi+W8mcjcbi52RrbqlcV6WQz1XUqtVH1xRi1B3n/O8rqKg9xpGQ7XieMoL 1zD83/Z1WQTMMW0wnAFl5BP9/grZ2s7aTbnHSE+DRdReLUQIz1IA0iQLg3PPr2gywBqs RkXad10m4GsokepiPbzyB4SbC9uwaLsO6OgX8BYW5PVuT5OFIP5i8BpjjE/iWT37RoNL 9wiQ== X-Gm-Message-State: AOJu0YwxKt2al3XNCX+79c9hxLjO4dQadYmQzGkQo1ntqBgy1BDQy8Fo Re4HvmUkcfaefaZ77rBHCplODy0By+OSIdaM/qzY0CaQmgLf89TR0kHygHfNYoV6NbuWg86Fc6W JdN9jQhS7VbkkOSRqMccplXN0KmurAB2koM0f85o014bn5AMJFX/rsrFcWssYPpG4hrkiMY2IkV 7UJvibrj+MlC86 X-Google-Smtp-Source: AGHT+IFS5SasBmECJ/tk7P+h1ZRJrAbM3+XK567jgpWI5zJCovVrs3bsSyr2+G3mVh0uP3aB3TaoHQ== X-Received: by 2002:a05:6808:1413:b0:3b2:dc66:1673 with SMTP id w19-20020a056808141300b003b2dc661673mr9286135oiv.9.1699901773160; Mon, 13 Nov 2023 10:56:13 -0800 (PST) Received: from stbsrv-and-01.and.broadcom.net ([192.19.144.250]) by smtp.gmail.com with ESMTPSA id b187-20020a6334c4000000b0056b27af8715sm4366421pga.43.2023.11.13.10.56.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 13 Nov 2023 10:56:12 -0800 (PST) From: Jim Quinlan To: linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com Cc: Conor Dooley , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), Florian Fainelli , Jim Quinlan , Krzysztof Kozlowski , =?utf-8?q?Krzyszto?= =?utf-8?q?f_Wilczy=C5=84ski?= , linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), linux-kernel@vger.kernel.org (open list), linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE), Lorenzo Pieralisi , Rob Herring Subject: [PATCH v8 0/2] PCI: brcmstb: Configure appropriate HW CLKREQ# mode Date: Mon, 13 Nov 2023 13:56:04 -0500 Message-Id: <20231113185607.1756-1-james.quinlan@broadcom.com> X-Mailer: git-send-email 2.17.1 Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org V8 -- Un-advertise L1SS capability when in "no-l1ss" mode (Bjorn) -- Squashed last two commits of v7 (Bjorn) -- Fix DT binding description text wrapping (Bjorn) -- Fix incorrect Spec reference (Bjorn) s/PCIe Spec/PCIe Express Mini CEM 2.1 specification/ -- Text substitutions (Bjorn) s/WRT/With respect to/ s/Tclron/T_CLRon/ v7 -- Manivannan Sadhasivam suggested (a) making the property look like a network phy-mode and (b) keeping the code simple (not counting clkreq signal appearances, un-advertising capabilites, etc). This is what I have done. The property is now "brcm,clkreq-mode" and the values may be one of "safe", "default", and "no-l1ss". The default setting is to employ the most capable power savings mode. v6 -- No code has been changed. -- Changed commit subject and comment in "#PERST" commit (Bjorn, Cyril) -- Changed sign-off and author email address for all commits. This was due to a change in Broadcom's upstreaming policy. v5 -- Remove DT property "brcm,completion-timeout-us" from "DT bindings" commit. Although this error may be reported as a completion timeout, its cause was traced to an internal bus timeout which may occur even when there is no PCIe access being processed. We set a timeout of four seconds only if we are operating in "L1SS CLKREQ#" mode. -- Correct CEM 2.0 reference provided by HW engineer, s/3.2.5.2.5/3.2.5.2.2/ (Bjorn) -- Add newline to dev_info() string (Stefan) -- Change variable rval to unsigned (Stefan) -- s/implementaion/implementation/ (Bjorn) -- s/superpowersave/powersupersave/ (Bjorn) -- Slightly modify message on "PERST#" commit. -- Rebase to torvalds master v4 -- New commit that asserts PERST# for 2711/RPi SOCs at PCIe RC driver probe() time. This is done in Raspian Linux and its absence may be the cause of a failing test case. -- New commit that removes stale comment. v3 -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) -- Add reference for "400ns of CLKREQ# assertion" blurb (Bjorn) -- Put binding names in DT commit Subject (Bjorn) -- Add a verb to a commit's subject line (Bjorn) -- s/accomodat(\w+)/accommodat$1/g (Bjorn) -- Rewrote commit msgs and comments refering panics if L1SS is enabled/disabled; the code snippet that unadvertises L1SS eliminates the panic scenario. (Bjorn) v2 -- Changed binding property 'brcm,completion-timeout-msec' to 'brcm,completion-timeout-us'. (StefanW for standard suffix). -- Warn when clamping timeout value, and include clamped region in message. Also add min and max in YAML. (StefanW) -- Qualify description of "brcm,completion-timeout-us" so that it refers to PCIe transactions. (StefanW) -- Remvove mention of Linux specifics in binding description. (StefanW) -- s/clkreq#/CLKREQ#/g (Bjorn) -- Refactor completion-timeout-us code to compare max and min to value given by the property (as opposed to the computed value). v1 -- The current driver assumes the downstream devices can provide CLKREQ# for ASPM. These commits accomodate devices w/ or w/o clkreq# and also handle L1SS-capable devices. -- The Raspian Linux folks have already been using a PCIe RC property "brcm,enable-l1ss". These commits use the same property, in a backward-compatible manner, and the implementaion adds more detail and also automatically identifies devices w/o a clkreq# signal, i.e. most devices plugged into an RPi CM4 IO board. Jim Quinlan (2): dt-bindings: PCI: brcmstb: Add property "brcm,clkreq-mode" PCI: brcmstb: Configure HW CLKREQ# mode appropriate for downstream device .../bindings/pci/brcm,stb-pcie.yaml | 18 ++++ drivers/pci/controller/pcie-brcmstb.c | 96 +++++++++++++++++-- 2 files changed, 104 insertions(+), 10 deletions(-) base-commit: 305230142ae0637213bf6e04f6d9f10bbcb74af8 Tested-by: Cyril Brulebois