From patchwork Tue Mar 25 10:25:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Marc Zyngier X-Patchwork-Id: 14028288 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 034591EEA4E; Tue, 25 Mar 2025 10:26:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742898395; cv=none; b=Vu00x35TD8aiqp2WDTTXZL2zrBJ2ijwautdxNHbrOwNY8ohkbqpUAyfVWAHM1OnwEAUAzVsCYkvO8sq/l7QHhZvQ/OncFte0VWK6ln5+bD5dwqJLdAo90qPs53gqxyVOH2I4xjheDWnukpXoPLKdi40TxKlBaER5mtvJTnQj4b8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742898395; c=relaxed/simple; bh=6gx8a7ztb8u3B/u8fPofO/Tuvql7eBwSe4k9mBhaLjc=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=gAIZ7K4iqqaMFbvteeIH9vpCGcA9xPvN4ESJHf84c8Jzq+iCdhTun2W9qlBPXRjTdxPHaPfvQDvG+xjAx+4oxHNH4I91Q07sBeXnx/+iBeijYdqTEDiKuK0LjLrKnTeqZtsWtVUFyT6Hf7uVb/p0J24NDiFPqU5uyCYrnK1/EJ8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rr0YtK1P; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rr0YtK1P" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8030CC4CEE4; Tue, 25 Mar 2025 10:26:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1742898394; bh=6gx8a7ztb8u3B/u8fPofO/Tuvql7eBwSe4k9mBhaLjc=; h=From:To:Cc:Subject:Date:From; b=rr0YtK1PQzC4NSDXu0DSxFUvhd4oVsWJv62czkyG0iVVQ8VuGA5YnDFCqLi1twziZ tPfNakYxPcjcAv2pzkmvMKPJ3+uKM0rs6mUcTdjghbkIV5PvB+jZqh3dqt4R8U86D1 lgnBd6zTLTnEjkj8Z3MXUI8Q1+lchlFLUaCzyhI1DZX25DGP7MBxEvChQPvaJXTrro +hfoE95+lbABCqwmPeY5GCylveZ1xfjSNhSvBbbkCnvRQ/HewS5e+079aANhN7Rc+Z 2URIbNlp7x0rqzE4TIronOOBp9oB/osdXg08TPDB8BxZ4mxuS5/R/nLC+4N6vSZk5c 8+IBZkrVVwpuw== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1tx1UO-00GsRS-28; Tue, 25 Mar 2025 10:26:32 +0000 From: Marc Zyngier To: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev Cc: Alyssa Rosenzweig , Janne Grunau , Hector Martin , Sven Peter , Bjorn Helgaas , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy=C5=84?= =?utf-8?q?ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski Subject: [PATCH v2 00/13] PCI: apple: Add support for t6020 Date: Tue, 25 Mar 2025 10:25:57 +0000 Message-Id: <20250325102610.2073863-1-maz@kernel.org> X-Mailer: git-send-email 2.39.2 Precedence: bulk X-Mailing-List: linux-pci@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: linux-arm-kernel@lists.infradead.org, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, asahi@lists.linux.dev, alyssa@rosenzweig.io, j@jannau.net, marcan@marcan.st, sven@svenpeter.dev, bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com, manivannan.sadhasivam@linaro.org, robh@kernel.org, krzk+dt@kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false As Alyssa didn't have the bandwidth to deal with this series, I have taken it over. All bugs are therefore mine. The initial series [1] stated: "This series adds T6020 support to the Apple PCIe controller. Mostly Apple shuffled registers around (presumably to accommodate the larger configurations on those machines). So there's a bit of churn here but not too much in the way of functional changes." The biggest change is affecting the ECAM layer, allowing an ECAM driver to provide its own probe function instead of relying on the .init() callback to do the work. The ECAM layer can therefore be used as a library instead of a convoluted driver. The rest is a mix of bug fixes, cleanups, and required abstraction. This has been tested on T6020 (M2-Pro mini) and T8102 (M1 mini). * From v1[1]: - Described the PHY registers in the DT binding - Extracted a ecam bridge creation helper from the host-common layer - Moved probing into its own function instead of pci_host_common_probe() - Moved host-specific data to the of_device_id[] table - Added dynamic allocation of the RID/SID bitmap - Fixed latent bug in RC-generated interrupts - Renamed reg_info to hw_info - Dropped useless max_msimap - Dropped code being moved around without justification - Re-split some of the patches to follow a more logical progression - General cleanup to fit my own taste [1] https://lore.kernel.org/r/20250211-pcie-t6-v1-0-b60e6d2501bb@rosenzweig.io Alyssa Rosenzweig (1): dt-bindings: pci: apple,pcie: Add t6020 compatible string Hector Martin (6): PCI: apple: Fix missing OF node reference in apple_pcie_setup_port PCI: apple: Move port PHY registers to their own reg items PCI: apple: Drop poll for CORE_RC_PHYIF_STAT_REFCLK PCI: apple: Use gpiod_set_value_cansleep in probe flow PCI: apple: Abstract register offsets via a SoC-specific structure PCI: apple: Add T602x PCIe support Janne Grunau (1): PCI: apple: Set only available ports up Marc Zyngier (5): PCI: host-generic: Extract an ecam bridge creation helper from pci_host_common_probe() PCI: ecam: Allow cfg->priv to be pre-populated from the root port device PCI: apple: Move over to standalone probing PCI: apple: Dynamically allocate RID-to_SID bitmap PCI: apple: Move away from INTMSK{SET,CLR} for INTx and private interrupts .../devicetree/bindings/pci/apple,pcie.yaml | 11 +- drivers/pci/controller/pci-host-common.c | 24 +- drivers/pci/controller/pcie-apple.c | 241 +++++++++++++----- drivers/pci/ecam.c | 2 + include/linux/pci-ecam.h | 2 + 5 files changed, 204 insertions(+), 76 deletions(-) Reviewed-by: Rob Herring (Arm) Acked-by: Alyssa Rosenzweig Tested-by: Janne Grunau