From patchwork Tue Apr 1 10:30:24 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 3920111 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 996F8BF540 for ; Tue, 1 Apr 2014 10:30:43 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DC6F0203B4 for ; Tue, 1 Apr 2014 10:30:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DF52203B8 for ; Tue, 1 Apr 2014 10:30:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751277AbaDAKa2 (ORCPT ); Tue, 1 Apr 2014 06:30:28 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:13037 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751057AbaDAKa0 (ORCPT ); Tue, 1 Apr 2014 06:30:26 -0400 Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0N3C004XOL6OWP70@mailout1.samsung.com> for linux-pci@vger.kernel.org; Tue, 01 Apr 2014 19:30:24 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.51]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 9E.2B.09028.0459A335; Tue, 01 Apr 2014 19:30:24 +0900 (KST) X-AuditID: cbfee68e-b7f566d000002344-0b-533a9540e1d6 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id F2.C6.28157.0459A335; Tue, 01 Apr 2014 19:30:24 +0900 (KST) Received: from DOJG1HAN03 ([12.36.166.146]) by mmp2.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0N3C00M4EL6O4M30@mmp2.samsung.com>; Tue, 01 Apr 2014 19:30:24 +0900 (KST) From: Jingoo Han To: 'Bjorn Helgaas' Cc: linux-pci@vger.kernel.org, 'Mohit Kumar' , 'Pratyush Anand' , 'Marek Vasut' , 'Richard Zhu' , 'Kishon Vijay Abraham I' , 'Jingoo Han' Subject: [PATCH] PCI: designware: Remove unnecessary RC BAR setting Date: Tue, 01 Apr 2014 19:30:24 +0900 Message-id: <000801cf4d95$64322ef0$2c968cd0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac9NlWP+CsrfdhsGRp2cT18aW1jDvw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrFIsWRmVeSWpSXmKPExsVy+t8zY12HqVbBBqeuKFksacqweHlI0+Ly wkusFhee9rBZnJ13nM3iTVsjo8XGqb8YLdovKVs8niXswOkxb9YJFo9/h/uZPBZsKvXo27KK 0ePpj73MHsdvbGfy+LxJLoA9issmJTUnsyy1SN8ugSvj6+YD7AWrOCq2LWtlamD8y9bFyMkh IWAisf7bCWYIW0ziwr31QHEuDiGBZYwSNz+cY4cputx+mAkiMZ1Rouf0blYI5zejxN+zM1hA qtgE1CS+fDkM1iEioCkxe8UWsA5mgRYmic7T7awgCWEBZ4mV+04wgdgsAqoS/6c/AdvNK2Ar 8WrvRzYIW1Dix+R7YEOZBbQk1u88zgRhy0tsXvMWqJ4D6CR1iUd/dSF26UkcarjCBlEiIrHv xTtGkL0SAi/ZJdp6vzNC7BKQ+Db5EAtEr6zEpgNQL0tKHFxxg2UCo9gsJJtnIdk8C8nmWUhW LGBkWcUomlqQXFCclF5kpFecmFtcmpeul5yfu4kREq99OxhvHrA+xJgMtH4is5Rocj4w3vNK 4g2NzYwsTE1MjY3MLc1IE1YS5130MClISCA9sSQ1OzW1ILUovqg0J7X4ECMTB6dUA2P6S5lr rBemMHQ/D9HxC5rAzbgh6nlS3eaur2+ePeD/vP1fZtFL87fzFZTleGq9Z36edtTfZ2GWTqa/ aGX77gyvP00MlwtE2fcKCH27bp3Dtsb//YKurA1vXaUv9rE71Z+5KPOlUU7VYOuWkIxPTPdb tr1fOs3pDYvz63snJlaf2OndemqDspQSS3FGoqEWc1FxIgBA/Zha7QIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrOKsWRmVeSWpSXmKPExsVy+t9jQV2HqVbBBp/a5SyWNGVYvDykaXF5 4SVWiwtPe9gszs47zmbxpq2R0WLj1F+MFu2XlC0ezxJ24PSYN+sEi8e/w/1MHgs2lXr0bVnF 6PH0x15mj+M3tjN5fN4kF8Ae1cBok5GamJJapJCal5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6k kJeYm2qr5OIToOuWmQN0lpJCWWJOKVAoILG4WEnfDtOE0BA3XQuYxghd35AguB4jAzSQsI4x 4+vmA+wFqzgqti1rZWpg/MvWxcjJISFgInG5/TAThC0mceHeeqA4F4eQwHRGiZ7Tu1khnN+M En/PzmABqWITUJP48uUwO4gtIqApMXvFFiaQImaBFiaJztPtrCAJYQFniZX7ToCNZRFQlfg/ /QkziM0rYCvxau9HNghbUOLH5HtgQ5kFtCTW7zzOBGHLS2xe8xaongPoJHWJR391IXbpSRxq uMIGUSIise/FO8YJjAKzkEyahWTSLCSTZiFpWcDIsopRNLUguaA4KT3XSK84Mbe4NC9dLzk/ dxMjOBk8k97BuKrB4hCjAAejEg+vRbllsBBrYllxZe4hRgkOZiURXpEeq2Ah3pTEyqrUovz4 otKc1OJDjMlAj05klhJNzgcmqrySeENjEzMjSyMzCyMTc3PShJXEeQ+2WgcKCaQnlqRmp6YW pBbBbGHi4JRqYJz7qafS0jd0/dKQlzwfdNLbzxc9LjfMPbxhldaOrA9cXVEVN2d4p3NMPMIc ERN2VsxynrK7wuXCbsst+c+vVgRvEOpKstR9tfx0VfW3bVn7/Ne2nZ6mqPJZ2tW6fUpvZI/N 4gX3lX5NvLn3oFzx8X8FOse1rSy77U4rBt35oRO5WPv5yYkTA5VYijMSDbWYi4oTATkZ07RK AwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP According to the spec, the synopsys core does not implement the optional BARs such as BAR0/1. This is based on the assumption that the RC host probably has registers on some other internal bus and has knowledge and setup access to these registers already. So, remove unnecessary RC BAR setting. Signed-off-by: Jingoo Han --- Tested on Exynos5440. drivers/pci/host/pcie-designware.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/pci/host/pcie-designware.c b/drivers/pci/host/pcie-designware.c index 6d23d8c..7bee01f 100644 --- a/drivers/pci/host/pcie-designware.c +++ b/drivers/pci/host/pcie-designware.c @@ -798,10 +798,6 @@ void dw_pcie_setup_rc(struct pcie_port *pp) } dw_pcie_writel_rc(pp, val, PCIE_LINK_WIDTH_SPEED_CONTROL); - /* setup RC BARs */ - dw_pcie_writel_rc(pp, 0x00000004, PCI_BASE_ADDRESS_0); - dw_pcie_writel_rc(pp, 0x00000000, PCI_BASE_ADDRESS_1); - /* setup interrupt pins */ dw_pcie_readl_rc(pp, PCI_INTERRUPT_LINE, &val); val &= 0xffff00ff;