From patchwork Wed Nov 12 03:25:38 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jingoo Han X-Patchwork-Id: 5283531 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 00E65C11AC for ; Wed, 12 Nov 2014 03:25:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 27BA920155 for ; Wed, 12 Nov 2014 03:25:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4B8C62013D for ; Wed, 12 Nov 2014 03:24:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752135AbaKLDY4 (ORCPT ); Tue, 11 Nov 2014 22:24:56 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:59410 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752126AbaKLDYz (ORCPT ); Tue, 11 Nov 2014 22:24:55 -0500 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout3.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTP id <0NEW00LBWPHHUW30@mailout3.samsung.com> for linux-pci@vger.kernel.org; Wed, 12 Nov 2014 12:24:53 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [203.254.230.48]) by epcpsbgr4.samsung.com (EPCPMTA) with SMTP id 51.AC.18167.503D2645; Wed, 12 Nov 2014 12:24:53 +0900 (KST) X-AuditID: cbfee690-f79ab6d0000046f7-97-5462d305bf7f Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 17.06.09430.503D2645; Wed, 12 Nov 2014 12:24:53 +0900 (KST) Received: from DOJG1HAN03 ([10.89.38.123]) by mmp1.samsung.com (Oracle Communications Messaging Server 7u4-24.01 (7.0.4.24.0) 64bit (built Nov 17 2011)) with ESMTPA id <0NEW00KKDPHHQJ90@mmp1.samsung.com>; Wed, 12 Nov 2014 12:24:53 +0900 (KST) From: Jingoo Han To: 'Bjorn Helgaas' Cc: linux-pci@vger.kernel.org, 'Jingoo Han' Subject: [PATCH] PCI: exynos: Remove unnecessary return statement Date: Wed, 12 Nov 2014 12:25:38 +0900 Message-id: <002901cffe28$544504b0$fccf0e10$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac/+KFQwfcz0hmDQS+CrslgcZZUBjw== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42I5/e+ZgS7r5aQQg1uPVS2WNGVYXF54idXi 7LzjbA7MHgs2lXr0bVnF6PF5k1wAcxSXTUpqTmZZapG+XQJXxq2Wc8wFq4Urli26xdbAuFyg i5GTQ0LARGLamcfsELaYxIV769m6GLk4hASWMUqcODCXHaZo7cVTLBCJRYwSU64vYIRwfjFK dD/cCFbFJqAm8eXLYTBbREBTYvaKLUwgNrOAo8S6lS9ZQWxhIHvp78XMIDaLgKpEx9KfjCA2 r4CtxMW3DSwQtqDEj8n3WCB6tSTW7zwONUdeYvOat0C9HEAXqUs8+qsLsUpPYsaFh1DlIhL7 XrwDu01CYDq7xN49ixkhdglIfJt8iAWiV1Zi0wFmiMckJQ6uuMEygVFsFpLNs5BsnoVk8ywk KxYwsqxiFE0tSC4oTkovMtErTswtLs1L10vOz93ECImnCTsY7x2wPsQowMGoxMObsCYpRIg1 say4MvcQoynQRROZpUST84FRm1cSb2hsZmRhamJqbGRuaaYkzvta6mewkEB6YklqdmpqQWpR fFFpTmrxIUYmDk6pBsbWYrOZL9XWiFwSv1nGU5OX/NT2dkLT0ft9f+1jtD7l/07tEpmdE7fy YdHBjqc770ges8uet1xeUUZhvrOPrcGtJc/fs/7Nbe/x2763uOpEm/Ynbh2ZEzO+HQ29ZO8c n7/S2eLmJ/cPV5r5JnG/vL56m0nxWXNv1lPvJylklXEnpS67suTK3CNKLMUZiYZazEXFiQDB smChogIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t9jAV3Wy0khBl8alSyWNGVYXF54idXi 7LzjbA7MHgs2lXr0bVnF6PF5k1wAc1QDo01GamJKapFCal5yfkpmXrqtkndwvHO8qZmBoa6h pYW5kkJeYm6qrZKLT4CuW2YO0B4lhbLEnFKgUEBicbGSvh2mCaEhbroWMI0Rur4hQXA9RgZo IGEdY8atlnPMBauFK5YtusXWwLhcoIuRk0NCwERi7cVTLBC2mMSFe+vZuhi5OIQEFjFKTLm+ gBHC+cUo0f1wIztIFZuAmsSXL4fBbBEBTYnZK7YwgdjMAo4S61a+ZAWxhYHspb8XM4PYLAKq Eh1LfzKC2LwCthIX3zawQNiCEj8m32OB6NWSWL/zONQceYnNa94C9XIAXaQu8eivLsQqPYkZ Fx5ClYtI7HvxjnECo8AsJJNmIZk0C8mkWUhaFjCyrGIUTS1ILihOSs810itOzC0uzUvXS87P 3cQIjtZn0jsYVzVYHGIU4GBU4uHN2JwUIsSaWFZcmXuIUYKDWUmE98FSoBBvSmJlVWpRfnxR aU5q8SFGU6BHJzJLiSbnAxNJXkm8obGJmZGlkZmFkYm5uZI478FW60AhgfTEktTs1NSC1CKY PiYOTqkGRmkrwxkq/RVzg/wOBMvfzbt8IjE6K4BR0+rM0gKef9XR+lt2S1y6lL0jM2+V1TXh m+da5my8JvjcKn7xpo3+gVOvnxU7wXbd/gfnKjUezscFC11tr1gXum7YZtDnu2yWRWNBrsFN jlVM+cl6qlcOMeRJVNtyzXVVX7t3sfZehZV8e/hjQhRLlViKMxINtZiLihMB+goil+wCAAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.4 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes the following checkpatch warning. WARNING: void function return statements are not generally useful Signed-off-by: Jingoo Han Acked-by: Srikanth Thokala Reviewed-by: Srikanth Thokala Acked-by: is often used by the maintainer of the affected code when that --- drivers/pci/host/pci-exynos.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c index c5d0ca3..41ab139 100644 --- a/drivers/pci/host/pci-exynos.c +++ b/drivers/pci/host/pci-exynos.c @@ -312,7 +312,6 @@ static void exynos_pcie_assert_reset(struct pcie_port *pp) if (exynos_pcie->reset_gpio >= 0) devm_gpio_request_one(pp->dev, exynos_pcie->reset_gpio, GPIOF_OUT_INIT_HIGH, "RESET"); - return; } static int exynos_pcie_establish_link(struct pcie_port *pp) @@ -388,7 +387,6 @@ static void exynos_pcie_clear_irq_pulse(struct pcie_port *pp) val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_PULSE); exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_PULSE); - return; } static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp) @@ -400,7 +398,6 @@ static void exynos_pcie_enable_irq_pulse(struct pcie_port *pp) val = IRQ_INTA_ASSERT | IRQ_INTB_ASSERT | IRQ_INTC_ASSERT | IRQ_INTD_ASSERT, exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_PULSE); - return; } static irqreturn_t exynos_pcie_irq_handler(int irq, void *arg) @@ -429,7 +426,6 @@ static void exynos_pcie_msi_init(struct pcie_port *pp) val = exynos_elb_readl(exynos_pcie, PCIE_IRQ_EN_LEVEL); val |= IRQ_MSI_ENABLE; exynos_elb_writel(exynos_pcie, val, PCIE_IRQ_EN_LEVEL); - return; } static void exynos_pcie_enable_interrupts(struct pcie_port *pp) @@ -438,8 +434,6 @@ static void exynos_pcie_enable_interrupts(struct pcie_port *pp) if (IS_ENABLED(CONFIG_PCI_MSI)) exynos_pcie_msi_init(pp); - - return; } static inline void exynos_pcie_readl_rc(struct pcie_port *pp, @@ -448,7 +442,6 @@ static inline void exynos_pcie_readl_rc(struct pcie_port *pp, exynos_pcie_sideband_dbi_r_mode(pp, true); *val = readl(dbi_base); exynos_pcie_sideband_dbi_r_mode(pp, false); - return; } static inline void exynos_pcie_writel_rc(struct pcie_port *pp, @@ -457,7 +450,6 @@ static inline void exynos_pcie_writel_rc(struct pcie_port *pp, exynos_pcie_sideband_dbi_w_mode(pp, true); writel(val, dbi_base); exynos_pcie_sideband_dbi_w_mode(pp, false); - return; } static int exynos_pcie_rd_own_conf(struct pcie_port *pp, int where, int size,