From patchwork Mon May 11 14:30:11 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Ellerman X-Patchwork-Id: 22995 Received: from vger.kernel.org (vger.kernel.org [209.132.176.167]) by demeter.kernel.org (8.14.2/8.14.2) with ESMTP id n4BEUGcw007336 for ; Mon, 11 May 2009 14:30:16 GMT Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866AbZEKOaN (ORCPT ); Mon, 11 May 2009 10:30:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751826AbZEKOaN (ORCPT ); Mon, 11 May 2009 10:30:13 -0400 Received: from bilbo.ozlabs.org ([203.10.76.25]:46839 "EHLO bilbo.ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750712AbZEKOaM (ORCPT ); Mon, 11 May 2009 10:30:12 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) by bilbo.ozlabs.org (Postfix) with ESMTP id 0AB70B6F56; Tue, 12 May 2009 00:30:12 +1000 (EST) Subject: Re: [PATCH] Fix MSI-X with NIU cards From: Michael Ellerman Reply-To: michael@ellerman.id.au To: David Miller Cc: matthew@wil.cx, jbarnes@virtuousgeek.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20090510.223645.193708481.davem@davemloft.net> References: <20090508131333.GV8112@parisc-linux.org> <1242004911.7767.26.camel@concordia> <20090510.223645.193708481.davem@davemloft.net> Date: Tue, 12 May 2009 00:30:11 +1000 Message-Id: <1242052211.7011.4.camel@concordia> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org On Sun, 2009-05-10 at 22:36 -0700, David Miller wrote: > From: Michael Ellerman > Date: Mon, 11 May 2009 11:21:51 +1000 > > > So I guess this device is just silently ignoring that write? > > No, it signals a fault on the PCI bus, which is how we noticed > this problem in the first place. But the patch doesn't change that? It just removes the readl AFAICS: Or has msix_mask_irq() changed since 413f81eba? cheers diff --git a/drivers/pci/msi.c b/drivers/pci/msi.c index 6f2e629..3627732 100644 --- a/drivers/pci/msi.c +++ b/drivers/pci/msi.c @@ -455,8 +455,6 @@ static int msix_capability_init(struct pci_dev *dev, entry->msi_attrib.default_irq = dev->irq; entry->msi_attrib.pos = pos; entry->mask_base = base; - entry->masked = readl(base + j * PCI_MSIX_ENTRY_SIZE + - PCI_MSIX_ENTRY_VECTOR_CTRL_OFFSET); msix_mask_irq(entry, 1);