From patchwork Tue Apr 29 12:58:07 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 4087361 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6C9C29F485 for ; Tue, 29 Apr 2014 13:00:50 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9EEED201F7 for ; Tue, 29 Apr 2014 13:00:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D5419201F5 for ; Tue, 29 Apr 2014 13:00:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751778AbaD2NAh (ORCPT ); Tue, 29 Apr 2014 09:00:37 -0400 Received: from [207.46.163.144] ([207.46.163.144]:33026 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1753702AbaD2NAY (ORCPT ); Tue, 29 Apr 2014 09:00:24 -0400 Received: from BLUPR03CA032.namprd03.prod.outlook.com (10.141.30.25) by BLUPR03MB247.namprd03.prod.outlook.com (10.255.213.21) with Microsoft SMTP Server (TLS) id 15.0.929.12; Tue, 29 Apr 2014 12:58:31 +0000 Received: from BL2FFO11FD051.protection.gbl (2a01:111:f400:7c09::193) by BLUPR03CA032.outlook.office365.com (2a01:111:e400:879::25) with Microsoft SMTP Server (TLS) id 15.0.934.12 via Frontend Transport; Tue, 29 Apr 2014 12:58:31 +0000 Received: from az84smr01.freescale.net (192.88.158.246) by BL2FFO11FD051.mail.protection.outlook.com (10.173.161.213) with Microsoft SMTP Server (TLS) id 15.0.929.8 via Frontend Transport; Tue, 29 Apr 2014 12:58:31 +0000 Received: from fabio-Latitude-E6410.am.freescale.net ([10.29.244.91]) by az84smr01.freescale.net (8.14.3/8.14.0) with ESMTP id s3TCwRTe026927; Tue, 29 Apr 2014 05:58:28 -0700 From: Fabio Estevam To: CC: , , , Fabio Estevam Subject: [PATCH v3] pci: pci-mvebu: Use '%pa' for printing 'phys_addr_t' type Date: Tue, 29 Apr 2014 09:58:07 -0300 Message-ID: <1398776287-14229-1-git-send-email-fabio.estevam@freescale.com> X-Mailer: git-send-email 1.8.3.2 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:192.88.158.246; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009001)(6009001)(428001)(189002)(199002)(20776003)(83322001)(79102001)(46102001)(4396001)(6806004)(80022001)(83072002)(92566001)(77982001)(101416001)(81342001)(47776003)(85852003)(44976005)(31966008)(33646001)(19580395003)(92726001)(89996001)(19580405001)(50986999)(50226001)(50466002)(88136002)(93916002)(81542001)(86362001)(87286001)(99396002)(48376002)(62966002)(77096999)(74502001)(76482001)(80976001)(36756003)(77156001)(74662001)(87936001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB247; H:az84smr01.freescale.net; FPR:8EEAF749.9C26D9E9.7BF5AB45.5826B2C1.20201; MLV:sfv; PTR:gate-az5.freescale.com; MX:1; A:1; LANG:en; MIME-Version: 1.0 X-Forefront-PRVS: 0196A226D1 Received-SPF: None (: freescale.com does not designate permitted sender hosts) X-OriginatorOrg: freescale.com Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fix the following build warning that happens when building multi_v7_defconfig with CONFIG_ARM_LPAE=y: drivers/pci/host/pci-mvebu.c:334:5: warning: format '%x' expects argument of type 'unsigned int', but argument 3 has type 'phys_addr_t' [-Wformat=] Fix the warning by using '%pa' to printing 'phys_addr_t' type. While at it, also use the more standard notation [mem 0x - 0x] for memory region. Signed-off-by: Fabio Estevam --- Changes since v2: - Introduce variable 'end' for printing the memory range Changes since v1: - use the [mem 0x - 0x] notation drivers/pci/host/pci-mvebu.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/host/pci-mvebu.c b/drivers/pci/host/pci-mvebu.c index e384e25..8329592 100644 --- a/drivers/pci/host/pci-mvebu.c +++ b/drivers/pci/host/pci-mvebu.c @@ -329,9 +329,11 @@ static void mvebu_pcie_add_windows(struct mvebu_pcie_port *port, ret = mvebu_mbus_add_window_remap_by_id(target, attribute, base, sz, remap); if (ret) { + phys_addr_t end = base + sz; + dev_err(&port->pcie->pdev->dev, - "Could not create MBus window at 0x%x, size 0x%x: %d\n", - base, sz, ret); + "Could not create MBus window at [mem %pa - %pa] :%d\n", + &base, &end, ret); mvebu_pcie_del_windows(port, base - size_mapped, size_mapped); return;