From patchwork Wed May 28 09:48:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 4254101 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork1.web.kernel.org (Postfix) with ESMTP id BBD639F358 for ; Wed, 28 May 2014 09:51:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBB1120176 for ; Wed, 28 May 2014 09:51:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D1DC0201FA for ; Wed, 28 May 2014 09:51:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752791AbaE1JvJ (ORCPT ); Wed, 28 May 2014 05:51:09 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:41701 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752787AbaE1JvH (ORCPT ); Wed, 28 May 2014 05:51:07 -0400 Received: by mail-pa0-f45.google.com with SMTP id ey11so10743188pad.32 for ; Wed, 28 May 2014 02:51:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=QO9fTBLxmoygk4lW22hYv8DLadOfcku1Dfuq1DSBrO4=; b=Bw7fNLxxMYrRu4FU24u+8gq/oXmdqQ3KLq4xfMrDz7ILfhztr07edQT5w5veUeoFmJ vYEnw1e//avwbJEyk09/YpjZVLEiMUQXhfjq/r1AJFMy3ReiBFW9P3eVdZd4PWSZhb4R wJtXDD0eShpmyU2ZE/gWpElfw7uBVtmHiX0v9kFaiFBBVx300sESGFuwQj//0N/r52Qp J981OLcbZ3LsNabjlJSitk+MA0GaVV8pxHkNhYTlPxxgpKeeTmYl7/dLyoxPHckGFVkQ RWAcTRSabdhkZNFXv9D/qAm/TfdP341rdsL4bG1hx5LCDEgcy4n5oRRV28rKbGGU0Jif K2+w== X-Gm-Message-State: ALoCoQk1urHr2RNYrHFnXjLW5JqiRn6xlAe/CP2rCKWlDEJG3my0MTbcBKFy+yiqT9Kgv+bCE9ac X-Received: by 10.68.226.105 with SMTP id rr9mr27160124pbc.161.1401270667046; Wed, 28 May 2014 02:51:07 -0700 (PDT) Received: from linaro.sisodomain.com ([14.140.216.146]) by mx.google.com with ESMTPSA id yl9sm86439498pac.25.2014.05.28.02.51.04 for (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 28 May 2014 02:51:06 -0700 (PDT) From: Sachin Kamat To: linux-pci@vger.kernel.org Cc: linux-samsung-soc@vger.kernel.org, jg1.han@samsung.com, bhelgaas@google.com, sachin.kamat@linaro.org Subject: [PATCH 1/1] PCI: exynos: Fix section mismatch warning Date: Wed, 28 May 2014 15:18:45 +0530 Message-Id: <1401270525-27139-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP add_pcie_port is called from probe which is annotated with __init. add_pcie_port calls dw_pcie_host_init which is also annotated with __init. Thus it makes sense to annotate add_pcie_port with __init to avoid the following section mismatch warning: WARNING: drivers/pci/built-in.o(.text.unlikely+0xf8): Section mismatch in reference from the function add_pcie_port() to the function .init.text:dw_pcie_host_init() The function add_pcie_port() references the function __init dw_pcie_host_init(). This is often because add_pcie_port lacks a __init annotation or the annotation of dw_pcie_host_init is wrong. Reported-by: kbuild test robot Signed-off-by: Sachin Kamat Acked-by: Jingoo Han --- drivers/pci/host/pci-exynos.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/host/pci-exynos.c b/drivers/pci/host/pci-exynos.c index 3de6bfbbe8e9..3c1ff89829ec 100644 --- a/drivers/pci/host/pci-exynos.c +++ b/drivers/pci/host/pci-exynos.c @@ -511,7 +511,8 @@ static struct pcie_host_ops exynos_pcie_host_ops = { .host_init = exynos_pcie_host_init, }; -static int add_pcie_port(struct pcie_port *pp, struct platform_device *pdev) +static int __init add_pcie_port(struct pcie_port *pp, + struct platform_device *pdev) { int ret;