From patchwork Tue Mar 4 19:27:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arvind Kumar X-Patchwork-Id: 3765681 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id F158CBF40C for ; Tue, 4 Mar 2014 19:30:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 292FF2022A for ; Tue, 4 Mar 2014 19:30:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4827D2022F for ; Tue, 4 Mar 2014 19:30:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754872AbaCDT1q (ORCPT ); Tue, 4 Mar 2014 14:27:46 -0500 Received: from smtp-outbound-2.vmware.com ([208.91.2.13]:48056 "EHLO smtp-outbound-2.vmware.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754847AbaCDT1p (ORCPT ); Tue, 4 Mar 2014 14:27:45 -0500 Received: from sc9-mailhost3.vmware.com (sc9-mailhost3.vmware.com [10.113.161.73]) by smtp-outbound-2.vmware.com (Postfix) with ESMTP id 27DF1280A8; Tue, 4 Mar 2014 11:27:45 -0800 (PST) Received: from zcs-prod-mta-2.vmware.com (zcs-prod-mta-2.vmware.com [10.113.163.64]) by sc9-mailhost3.vmware.com (Postfix) with ESMTP id 23409402C9; Tue, 4 Mar 2014 11:27:45 -0800 (PST) Received: from zcs-prod-mta-2.vmware.com (localhost.localdomain [127.0.0.1]) by zcs-prod-mta-2.vmware.com (Postfix) with ESMTP id 0C6CFE003B; Tue, 4 Mar 2014 11:27:45 -0800 (PST) Received: from zcs-prod-mbox-7.vmware.com (lbv-sc9-t2prod2-int.vmware.com [10.113.160.246]) by zcs-prod-mta-2.vmware.com (Postfix) with ESMTP; Tue, 4 Mar 2014 11:27:44 -0800 (PST) Date: Tue, 4 Mar 2014 11:27:44 -0800 (PST) From: Arvind Kumar To: Alexander Gordeev Cc: linux-kernel@vger.kernel.org, pv-drivers@vmware.com, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Message-ID: <1412188603.36940054.1393961264565.JavaMail.root@vmware.com> In-Reply-To: References: Subject: Re: [PATCH v2 23/23] vmw_pvscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() MIME-Version: 1.0 X-Originating-IP: [10.113.163.68] X-Mailer: Zimbra 8.0.3_GA_5664 (ZimbraWebClient - FF26 (Linux)/8.0.3_GA_5664) Thread-Topic: vmw_pvscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() Thread-Index: NbRkHCe0N0jHGv6oT+qIPOqpPcdhig== Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Alexander, This looks fine to me. Acked-by: Arvind Kumar Thanks! Arvind ----- Original Message ----- From: "Alexander Gordeev" To: linux-kernel@vger.kernel.org Cc: "Alexander Gordeev" , "Arvind Kumar" , pv-drivers@vmware.com, linux-scsi@vger.kernel.org, linux-pci@vger.kernel.org Sent: Monday, February 24, 2014 12:02:23 AM Subject: [PATCH v2 23/23] vmw_pvscsi: Use pci_enable_msix_exact() instead of pci_enable_msix() As result of deprecation of MSI-X/MSI enablement functions pci_enable_msix() and pci_enable_msi_block() all drivers using these two interfaces need to be updated to use the new pci_enable_msi_range() or pci_enable_msi_exact() and pci_enable_msix_range() or pci_enable_msix_exact() interfaces. Signed-off-by: Alexander Gordeev Cc: Arvind Kumar Cc: pv-drivers@vmware.com Cc: linux-scsi@vger.kernel.org Cc: linux-pci@vger.kernel.org --- drivers/scsi/vmw_pvscsi.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/drivers/scsi/vmw_pvscsi.c index b9755ec..a046618 100644 --- a/drivers/scsi/vmw_pvscsi.c +++ b/drivers/scsi/vmw_pvscsi.c @@ -1078,7 +1078,7 @@ static int pvscsi_setup_msix(const struct pvscsi_adapter *adapter, struct msix_entry entry = { 0, PVSCSI_VECTOR_COMPLETION }; int ret; - ret = pci_enable_msix(adapter->dev, &entry, 1); + ret = pci_enable_msix_exact(adapter->dev, &entry, 1); if (ret) return ret;