From patchwork Fri Oct 17 08:53:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huang Rui X-Patchwork-Id: 5096201 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.19.201]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 178FFC11AC for ; Fri, 17 Oct 2014 09:18:02 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3F327201EF for ; Fri, 17 Oct 2014 09:18:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 687F1201ED for ; Fri, 17 Oct 2014 09:18:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752566AbaJQJPE (ORCPT ); Fri, 17 Oct 2014 05:15:04 -0400 Received: from mail-bn1bon0138.outbound.protection.outlook.com ([157.56.111.138]:57888 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751254AbaJQJPA (ORCPT ); Fri, 17 Oct 2014 05:15:00 -0400 X-Greylist: delayed 915 seconds by postgrey-1.27 at vger.kernel.org; Fri, 17 Oct 2014 05:15:00 EDT Received: from BY2PR02MB202.namprd02.prod.outlook.com (10.242.232.22) by BY2PR02MB090.namprd02.prod.outlook.com (10.242.43.153) with Microsoft SMTP Server (TLS) id 15.0.1054.13; Fri, 17 Oct 2014 09:00:15 +0000 Received: from BY1PR0201CA0005.namprd02.prod.outlook.com (25.160.191.143) by BY2PR02MB202.namprd02.prod.outlook.com (10.242.232.22) with Microsoft SMTP Server (TLS) id 15.0.1049.19; Fri, 17 Oct 2014 09:00:14 +0000 Received: from BY2FFO11FD032.protection.gbl (2a01:111:f400:7c0c::145) by BY1PR0201CA0005.outlook.office365.com (2a01:111:e400:4814::15) with Microsoft SMTP Server (TLS) id 15.0.1054.13 via Frontend Transport; Fri, 17 Oct 2014 09:00:14 +0000 Received: from atltwp02.amd.com (165.204.84.222) by BY2FFO11FD032.mail.protection.outlook.com (10.1.14.210) with Microsoft SMTP Server id 15.0.1039.16 via Frontend Transport; Fri, 17 Oct 2014 09:00:14 +0000 X-WSS-ID: 0NDKZOA-08-TNG-02 X-M-MSG: Received: from satlvexedge02.amd.com (satlvexedge02.amd.com [10.177.96.29]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by atltwp02.amd.com (Axway MailGate 5.3.1) with ESMTPS id 2CCECD16001; Fri, 17 Oct 2014 04:00:10 -0500 (CDT) Received: from SATLEXDAG05.amd.com (10.181.40.11) by SATLVEXEDGE02.amd.com (10.177.96.29) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 17 Oct 2014 04:00:17 -0500 Received: from SCYBEXDAG03.amd.com (10.34.11.13) by satlexdag05.amd.com (10.181.40.11) with Microsoft SMTP Server (TLS) id 14.3.195.1; Fri, 17 Oct 2014 05:00:13 -0400 Received: from hr-ub.amd.com (10.237.75.143) by SCYBEXDAG03.amd.com (10.34.11.13) with Microsoft SMTP Server id 14.3.195.1; Fri, 17 Oct 2014 17:00:09 +0800 From: Huang Rui To: Felipe Balbi , Alan Stern , "Bjorn Helgaas" , Greg Kroah-Hartman CC: Paul Zimmerman , Heikki Krogerus , Vincent Wan , Tony Li , , , , Huang Rui Subject: [PATCH v2 12/16] usb: dwc3: add delay phy power change quirk Date: Fri, 17 Oct 2014 16:53:37 +0800 Message-ID: <1413536021-4886-13-git-send-email-ray.huang@amd.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1413536021-4886-1-git-send-email-ray.huang@amd.com> References: <1413536021-4886-1-git-send-email-ray.huang@amd.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:165.204.84.222; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10019020)(6009001)(428002)(199003)(189002)(21056001)(48376002)(44976005)(19580395003)(19580405001)(53416004)(80022003)(50466002)(99396003)(76482002)(120916001)(102836001)(84676001)(31966008)(50986999)(62966002)(64706001)(104166001)(86362001)(93916002)(76176999)(20776003)(89996001)(85852003)(47776003)(2171001)(87936001)(85306004)(101416001)(87286001)(92566001)(77156001)(88136002)(4396001)(50226001)(33646002)(95666004)(92726001)(46102003)(36756003)(68736004)(229853001)(97736003)(77096002)(106466001)(105586002)(107046002); DIR:OUT; SFP:1102; SCL:1; SRVR:BY2PR02MB202; H:atltwp02.amd.com; FPR:; MLV:sfv; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Antispam: UriScan:;UriScan:; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB202; X-Exchange-Antispam-Report-Test: UriScan:; X-Forefront-PRVS: 0367A50BB1 Received-SPF: None (protection.outlook.com: amd.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is 165.204.84.222) smtp.mailfrom=Ray.Huang@amd.com; X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:;SRVR:BY2PR02MB090; X-OriginatorOrg: amd4.onmicrosoft.com Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP AMD NL needs to delay PHY power change from P0 to P1/P2/P3 when link state changing from U0 to U1/U2/U3 respectively. Signed-off-by: Huang Rui --- drivers/usb/dwc3/core.c | 3 +++ drivers/usb/dwc3/core.h | 1 + drivers/usb/dwc3/dwc3-pci.c | 3 ++- drivers/usb/dwc3/platform_data.h | 1 + 4 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index a9f1d4c..920a8ab 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -383,6 +383,9 @@ static void dwc3_phy_setup(struct dwc3 *dwc) if (dwc->quirks & DWC3_QUIRK_DEPP1P2P3) reg |= DWC3_GUSB3PIPECTL_DEP1P2P3(1); + if (dwc->quirks & DWC3_QUIRK_DEPOCHANGE) + reg |= DWC3_GUSB3PIPECTL_DEPOCHANGE; + dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg); mdelay(100); diff --git a/drivers/usb/dwc3/core.h b/drivers/usb/dwc3/core.h index cf70fa6..4c0200f 100644 --- a/drivers/usb/dwc3/core.h +++ b/drivers/usb/dwc3/core.h @@ -180,6 +180,7 @@ #define DWC3_GUSB3PIPECTL_REQP1P2P3 (1 << 24) #define DWC3_GUSB3PIPECTL_DEP1P2P3_MASK DWC3_GUSB3PIPECTL_DEP1P2P3(7) #define DWC3_GUSB3PIPECTL_DEP1P2P3(n) ((n) << 19) +#define DWC3_GUSB3PIPECTL_DEPOCHANGE (1 << 18) #define DWC3_GUSB3PIPECTL_SUSPHY (1 << 17) /* Global TX Fifo Size Register */ diff --git a/drivers/usb/dwc3/dwc3-pci.c b/drivers/usb/dwc3/dwc3-pci.c index 23ae6a7..0eb8b2a 100644 --- a/drivers/usb/dwc3/dwc3-pci.c +++ b/drivers/usb/dwc3/dwc3-pci.c @@ -153,7 +153,8 @@ static int dwc3_pci_probe(struct pci_dev *pci, | DWC3_QUIRK_U2EXIT_LFPS | DWC3_QUIRK_U2SSINP3OK | DWC3_QUIRK_REQP1P2P3 - | DWC3_QUIRK_DEPP1P2P3; + | DWC3_QUIRK_DEPP1P2P3 + | DWC3_QUIRK_DEPOCHANGE; } ret = platform_device_add_resources(dwc3, res, ARRAY_SIZE(res)); diff --git a/drivers/usb/dwc3/platform_data.h b/drivers/usb/dwc3/platform_data.h index e668c1f..934c5e1 100644 --- a/drivers/usb/dwc3/platform_data.h +++ b/drivers/usb/dwc3/platform_data.h @@ -34,5 +34,6 @@ struct dwc3_platform_data { #define DWC3_QUIRK_U2SSINP3OK (1 << 3) #define DWC3_QUIRK_REQP1P2P3 (1 << 4) #define DWC3_QUIRK_DEPP1P2P3 (1 << 5) +#define DWC3_QUIRK_DEPOCHANGE (1 << 6) };