From patchwork Sat Jan 10 02:34:37 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Rob Herring (Arm)" X-Patchwork-Id: 5604011 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 369E3C058D for ; Sat, 10 Jan 2015 02:39:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 6A5672061C for ; Sat, 10 Jan 2015 02:39:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8FCCA204A9 for ; Sat, 10 Jan 2015 02:39:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758607AbbAJCjc (ORCPT ); Fri, 9 Jan 2015 21:39:32 -0500 Received: from mail-oi0-f44.google.com ([209.85.218.44]:36406 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754111AbbAJCfe (ORCPT ); Fri, 9 Jan 2015 21:35:34 -0500 Received: by mail-oi0-f44.google.com with SMTP id a141so14470042oig.3; Fri, 09 Jan 2015 18:35:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=+drHYgAkPpJFaVHJ5L4v2diAJZsL/a37bzURAbF4HfA=; b=LJM203LSluQWUDLexhGn3o9iiLDLVkHxpuJaPI42W2RArEWxGOnsZYFr5tfQeSRIJ1 Ywcqpxc0cW4PUCJKA36CDI85xkhLqErBDOkhcZWE7iIoD0GwHSGHqc41oAASsxFuLyQk PcMYk69q1VdzSqJ8+wAltXb5MENfgxBSWEwQ0uBh10wydO2EZ2mJQIsqaO634HojajSE hEsS0pUmO9QFEQdIAfCLceyv+zUW4d0FA8AePFiyn/00rtMtar8eyD8dGZF0dv2aKgi+ MaHf/dIUaLLtBddnQyuN0WYOt6bM7nskk6DGPVkK/itgZ1F9ToIh+tsf+Jttdfv0E2dC hyMw== X-Received: by 10.202.83.139 with SMTP id h133mr10557455oib.90.1420857333253; Fri, 09 Jan 2015 18:35:33 -0800 (PST) Received: from rob-laptop.herring.priv (72-48-98-129.dyn.grandenetworks.net. [72.48.98.129]) by mx.google.com with ESMTPSA id b192sm5326257oih.4.2015.01.09.18.35.30 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 09 Jan 2015 18:35:32 -0800 (PST) From: Rob Herring To: linux-kernel@vger.kernel.org Cc: Arnd Bergmann , linux-pci@vger.kernel.org, Bjorn Helgaas , Rob Herring , David Howells , Koichi Yasutake , linux-am33-list@redhat.com Subject: [PATCH 03/16] mn10300: add struct pci_ops member names to initialization Date: Fri, 9 Jan 2015 20:34:37 -0600 Message-Id: <1420857290-8373-4-git-send-email-robh@kernel.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1420857290-8373-1-git-send-email-robh@kernel.org> References: <1420857290-8373-1-git-send-email-robh@kernel.org> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Some instances of pci_ops initialization rely on the read/write members' location in the struct. This is fragile and may break when adding new members to the beginning of the struct. Signed-off-by: Rob Herring Cc: David Howells Cc: Koichi Yasutake Cc: linux-am33-list@redhat.com --- arch/mn10300/unit-asb2305/pci.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mn10300/unit-asb2305/pci.c b/arch/mn10300/unit-asb2305/pci.c index 6b4339f..406cbe0 100644 --- a/arch/mn10300/unit-asb2305/pci.c +++ b/arch/mn10300/unit-asb2305/pci.c @@ -228,8 +228,8 @@ static int pci_ampci_write_config(struct pci_bus *bus, unsigned int devfn, } static struct pci_ops pci_direct_ampci = { - pci_ampci_read_config, - pci_ampci_write_config, + .read = pci_ampci_read_config, + .write = pci_ampci_write_config, }; /*