From patchwork Mon Aug 24 19:13:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Luis R. Rodriguez" X-Patchwork-Id: 7066431 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6B1959F344 for ; Mon, 24 Aug 2015 19:17:36 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 470CE205F3 for ; Mon, 24 Aug 2015 19:17:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2D138206F4 for ; Mon, 24 Aug 2015 19:17:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755352AbbHXTOA (ORCPT ); Mon, 24 Aug 2015 15:14:00 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:35463 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751179AbbHXTN5 (ORCPT ); Mon, 24 Aug 2015 15:13:57 -0400 Received: by pacdd16 with SMTP id dd16so103446260pac.2; Mon, 24 Aug 2015 12:13:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=wQvBJqb58vwMp9CQ5r0XZL/O8S+OJuo9BgjHC74h+uI=; b=J+snrL2lqGFXz9LYWlzMKAg5AS0LBZa65vAoTXGNjA3VJbnrIo4RzwXUV9SvvPpWlJ +tmWsE986sblP9XnjYjwXMY/CVFxKRLUMAqn5cJRKQPQqEYk5kumJoR57rpTQpq2xEgD wsVIXVCVGWrURtvfFXv0hgjSUz95CEv0NWcRAX81JAh0upyPrmXp9k+OVjqCJxpCqkn6 g5OAQfnxQ3Tq/ywcurCXPVpXK7x/1E0ObW7TJVA+AJTaf5yNdv0waaZvsAWRSNVt3ZWH zyyg+M02xWsj+E43UMCjLptXjBK/jX52J/uV9EH47sqxKSZ9/G//4qv9Zhgc0B95UscO zQuQ== X-Received: by 10.68.218.104 with SMTP id pf8mr48424236pbc.31.1440443636989; Mon, 24 Aug 2015 12:13:56 -0700 (PDT) Received: from mcgrof@gmail.com ([2601:646:200:bc5b:ca60:ff:feda:57a7]) by smtp.gmail.com with ESMTPSA id m2sm18285139pdr.64.2015.08.24.12.13.53 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 24 Aug 2015 12:13:56 -0700 (PDT) Received: by mcgrof@gmail.com (sSMTP sendmail emulation); Mon, 24 Aug 2015 12:13:53 -0700 From: "Luis R. Rodriguez" To: mingo@kernel.org Cc: bp@suse.de, bhelgaas@google.com, tomi.valkeinen@ti.com, airlied@linux.ie, linux-fbdev@vger.kernel.org, luto@amacapital.net, vinod.koul@intel.com, dan.j.williams@intel.com, toshi.kani@hp.com, benh@kernel.crashing.org, mst@redhat.com, akpm@linux-foundation.org, daniel.vetter@ffwll.ch, konrad.wilk@oracle.com, x86@kernel.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, xen-devel@lists.xensource.com, "Luis R. Rodriguez" , Antonino Daplas , Arnd Bergmann , Dave Airlie , Geert Uytterhoeven , "H. Peter Anvin" , Jean-Christophe Plagniol-Villard , Juergen Gross , Laurent Pinchart , Rob Clark , Suresh Siddha , Thomas Gleixner Subject: [PATCH v4 04/11] drivers/video/fbdev/gxt4500: Use pci_ioremap_wc_bar() to map framebuffer Date: Mon, 24 Aug 2015 12:13:26 -0700 Message-Id: <1440443613-13696-5-git-send-email-mcgrof@do-not-panic.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1440443613-13696-1-git-send-email-mcgrof@do-not-panic.com> References: <1440443613-13696-1-git-send-email-mcgrof@do-not-panic.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: "Luis R. Rodriguez" The driver doesn't use mtrr_add() or arch_phys_wc_add() but since we know the framebuffer is isolated already on an ioremap() we can take advantage of write combining for performance where possible. In this case there are a few motivations for this: a) Take advantage of PAT when available. b) Help with the goal of eventually using _PAGE_CACHE_UC over _PAGE_CACHE_UC_MINUS on x86 on ioremap_nocache() (see commit de33c442e titled "x86 PAT: fix performance drop for glx, use UC minus for ioremap(), ioremap_nocache() and pci_mmap_page_range()"). Signed-off-by: Luis R. Rodriguez Acked-by: Tomi Valkeinen Cc: Andrew Morton Cc: Andy Lutomirski Cc: Antonino Daplas Cc: Arnd Bergmann Cc: benh@kernel.crashing.org Cc: bhelgaas@google.com Cc: Daniel Vetter Cc: Dave Airlie Cc: Geert Uytterhoeven Cc: H. Peter Anvin Cc: Ingo Molnar Cc: Jean-Christophe Plagniol-Villard Cc: Juergen Gross Cc: Laurent Pinchart Cc: linux-fbdev@vger.kernel.org Cc: linux-pci@vger.kernel.org Cc: mst@redhat.com Cc: Rob Clark Cc: Suresh Siddha Cc: Thomas Gleixner Cc: toshi.kani@hp.com Link: http://lkml.kernel.org/r/1435195342-26879-5-git-send-email-mcgrof@do-not-panic.com Signed-off-by: Borislav Petkov --- drivers/video/fbdev/gxt4500.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/gxt4500.c b/drivers/video/fbdev/gxt4500.c index 135d78a02588..f19133a80e8c 100644 --- a/drivers/video/fbdev/gxt4500.c +++ b/drivers/video/fbdev/gxt4500.c @@ -662,7 +662,7 @@ static int gxt4500_probe(struct pci_dev *pdev, const struct pci_device_id *ent) info->fix.smem_start = fb_phys; info->fix.smem_len = pci_resource_len(pdev, 1); - info->screen_base = pci_ioremap_bar(pdev, 1); + info->screen_base = pci_ioremap_wc_bar(pdev, 1); if (!info->screen_base) { dev_err(&pdev->dev, "gxt4500: cannot map framebuffer\n"); goto err_unmap_regs;