From patchwork Mon Sep 7 08:51:04 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Stach X-Patchwork-Id: 7133301 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 001259F1CD for ; Mon, 7 Sep 2015 08:51:09 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0A3E5204B5 for ; Mon, 7 Sep 2015 08:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E22B5204A0 for ; Mon, 7 Sep 2015 08:51:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752543AbbIGIvG (ORCPT ); Mon, 7 Sep 2015 04:51:06 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:37417 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753588AbbIGIvG (ORCPT ); Mon, 7 Sep 2015 04:51:06 -0400 Received: from weser.hi.pengutronix.de ([2001:67c:670:100:fa0f:41ff:fe58:4010]) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1ZYs8m-00062Z-Uf; Mon, 07 Sep 2015 10:51:04 +0200 Message-ID: <1441615864.3174.2.camel@pengutronix.de> Subject: Re: [pci:pci-4.4/host-designware 4/5] drivers/pci/host/pci-keystone-dw.c:73:13: error: conflicting types for 'ks_dw_pcie_get_msi_addr' From: Lucas Stach To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org Date: Mon, 07 Sep 2015 10:51:04 +0200 In-Reply-To: <201509050132.BtjF0zsN%fengguang.wu@intel.com> References: <201509050132.BtjF0zsN%fengguang.wu@intel.com> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:fa0f:41ff:fe58:4010 X-SA-Exim-Mail-From: l.stach@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pci@vger.kernel.org Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Bjorn, Am Samstag, den 05.09.2015, 01:38 +0800 schrieb kbuild test robot: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git pci-4.4/host-designware > head: 59f6d039d7eaa0c851b712bc0aa1c804c727de61 > commit: ec8d33e0c5ade5d6d2c0ececff44a0ad5ed35df1 [4/5] PCI: designware: Make get_msi_addr() return phys_addr_t, not u32 > config: arm-keystone_defconfig (attached as .config) > reproduce: > wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > git checkout ec8d33e0c5ade5d6d2c0ececff44a0ad5ed35df1 > # save the attached .config to linux build tree > make.cross ARCH=arm > > All error/warnings (new ones prefixed by >>): > > >> drivers/pci/host/pci-keystone-dw.c:73:13: error: conflicting types for 'ks_dw_pcie_get_msi_addr' > phys_addr_t ks_dw_pcie_get_msi_addr(struct pcie_port *pp) > ^ > In file included from drivers/pci/host/pci-keystone-dw.c:24:0: > drivers/pci/host/pci-keystone.h:40:5: note: previous declaration of 'ks_dw_pcie_get_msi_addr' was here > u32 ks_dw_pcie_get_msi_addr(struct pcie_port *pp); > ^ > -- > >> drivers/pci/host/pci-keystone.c:287:2: warning: initialization from incompatible pointer type > .get_msi_addr = ks_dw_pcie_get_msi_addr, > ^ > >> drivers/pci/host/pci-keystone.c:287:2: warning: (near initialization for 'keystone_pcie_host_ops.get_msi_addr') > > vim +/ks_dw_pcie_get_msi_addr +73 drivers/pci/host/pci-keystone-dw.c > > 67 u32 *bit_pos) > 68 { > 69 *reg_offset = offset % 8; > 70 *bit_pos = offset >> 3; > 71 } > 72 > > 73 phys_addr_t ks_dw_pcie_get_msi_addr(struct pcie_port *pp) > 74 { > 75 struct keystone_pcie *ks_pcie = to_keystone_pcie(pp); > 76 > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation Totally my fault for not properly building all affected platforms. Can you squash in the following? Regards, Lucas --------------------------------->8------------------------------- void ks_dw_pcie_enable_legacy_irqs(struct keystone_pcie *ks_pcie); diff --git a/drivers/pci/host/pci-keystone.h b/drivers/pci/host/pci-keystone.h index 478d932b602d..f0944e8c4b02 100644 --- a/drivers/pci/host/pci-keystone.h +++ b/drivers/pci/host/pci-keystone.h @@ -37,7 +37,7 @@ struct keystone_pcie { /* Keystone DW specific MSI controller APIs/definitions */ void ks_dw_pcie_handle_msi_irq(struct keystone_pcie *ks_pcie, int offset); -u32 ks_dw_pcie_get_msi_addr(struct pcie_port *pp); +phys_addr_t ks_dw_pcie_get_msi_addr(struct pcie_port *pp); /* Keystone specific PCI controller APIs */