From patchwork Thu Dec 3 11:17:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ley Foon Tan X-Patchwork-Id: 7758451 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C01F39F30B for ; Thu, 3 Dec 2015 11:18:44 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id E97AB20574 for ; Thu, 3 Dec 2015 11:18:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 07D1820511 for ; Thu, 3 Dec 2015 11:18:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760152AbbLCLSS (ORCPT ); Thu, 3 Dec 2015 06:18:18 -0500 Received: from mail-bl2on0077.outbound.protection.outlook.com ([65.55.169.77]:14037 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1759905AbbLCLSP (ORCPT ); Thu, 3 Dec 2015 06:18:15 -0500 Received: from BY2PR03CA010.namprd03.prod.outlook.com (10.255.93.27) by CY1PR0301MB2074.namprd03.prod.outlook.com (10.164.2.144) with Microsoft SMTP Server (TLS) id 15.1.337.19; Thu, 3 Dec 2015 11:18:13 +0000 Received: from BY2FFO11OLC011.protection.gbl (10.255.93.4) by BY2PR03CA010.outlook.office365.com (10.255.93.27) with Microsoft SMTP Server (TLS) id 15.1.331.20 via Frontend Transport; Thu, 3 Dec 2015 11:18:13 +0000 Authentication-Results: spf=softfail (sender IP is 66.35.236.227) smtp.mailfrom=altera.com; vger.kernel.org; dkim=none (message not signed) header.d=none; vger.kernel.org; dmarc=none action=none header.from=altera.com; Received-SPF: SoftFail (protection.outlook.com: domain of transitioning altera.com discourages use of 66.35.236.227 as permitted sender) Received: from sj-itexedge03.altera.priv.altera.com (66.35.236.227) by BY2FFO11OLC011.mail.protection.outlook.com (10.1.15.22) with Microsoft SMTP Server (TLS) id 15.1.337.8 via Frontend Transport; Thu, 3 Dec 2015 11:18:12 +0000 Received: from sj-mail01.altera.com (137.57.1.6) by webmail.altera.com (66.35.236.227) with Microsoft SMTP Server (TLS) id 14.3.174.1; Thu, 3 Dec 2015 03:17:26 -0800 Received: from leyfoon-vm (pg-lftan-l.altera.com [137.57.103.123]) by sj-mail01.altera.com (8.13.7+Sun/8.13.7) with SMTP id tB3BI96G003420; Thu, 3 Dec 2015 03:18:09 -0800 (PST) Received: by leyfoon-vm (sSMTP sendmail emulation); Thu, 03 Dec 2015 19:18:08 +0800 From: Ley Foon Tan To: Bjorn Helgaas CC: , , Ley Foon Tan , Subject: [PATCH 3/3] PCI: altera: fix error when INTX is 4 Date: Thu, 3 Dec 2015 19:17:54 +0800 Message-ID: <1449141474-3378-4-git-send-email-lftan@altera.com> X-Mailer: git-send-email 1.8.3.2 In-Reply-To: <1449141474-3378-1-git-send-email-lftan@altera.com> References: <1449141474-3378-1-git-send-email-lftan@altera.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1; BY2FFO11OLC011; 1:h3SNA4mt8EQc/1AAr2ROcQ9s66RCwDXuaDVATme1cY0UwfnBUObSnutBMaF6RZU5qTTUp+aOMrfe9tD/nuGL5a2FGM+lecGRheVQYTQg94EO0RHDmxaof4npTd46cZD/0Gw8qZ/OJCd9lg877LGfdEf8AZomClvz/AURvDkHp/zAeRhUykNXXe7QbXbwQyCgPmEpGjV52F/pOndbwmJ6y/v5UEtAn7xxOpvyUHDXepCUpCnt1YAPaujCnQruFGYLWF6eBl2L8Rk9sBCq8flWVGx89/+CGoG2mUO+3UGcEEzUyKgHuZuVysdauND7gooUQcFeBk01R906fJHvBxKKwAmM63mRIl3uRMh2Gc7PeUGBQmScPgGpPCN/LmLx1gCbILAN4IcooOiVJqsL+r/2hA== X-Forefront-Antispam-Report: CIP:66.35.236.227; CTRY:US; IPV:NLI; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(2980300002)(199003)(189002)(97736004)(5008740100001)(36756003)(105596002)(189998001)(87936001)(33646002)(106466001)(6806005)(586003)(1096002)(1220700001)(50226001)(81156007)(92566002)(86362001)(50466002)(11100500001)(76176999)(19580395003)(110136002)(48376002)(5001960100002)(50986999)(2950100001)(5003940100001)(47776003)(42186005)(19580405001)(229853001)(7099028); DIR:OUT; SFP:1101; SCL:1; SRVR:CY1PR0301MB2074; H:sj-itexedge03.altera.priv.altera.com; FPR:; SPF:SoftFail; PTR:InfoDomainNonexistent; A:1; MX:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2074; 2:c0bWyUlQ63Sps+yMMDDm1wDwt60lvmpxKQRAK1r/T+eEeY3pbrHDr6A2brs6jrREva/Ds2eSAa929f8B53SGv5eSUWYn+tN88kcXtzhSb1VVGYDdCLZwMg4lyRgnJ37xUgUPHJf0qrLMjcDi83fG8g==; 3:4CEgEycoOpZtpny29z0S+2wXx2RZ7GFSkRI0gx2jco8BjeJQsaorDo6xLwfmpCLym6lXAq6Ian7Y1BpKhedqNrZySdXYdiezrZ3evJGFCWbm4oJKBC6Cx04y5TyLOP3B1feWe2/M6TvH5GAYmibuAqXwNG7wtfZdkgZpkDlKB39WWzaFUbFo+Jl9npBpQxuMBvzO8e1tDvCGN2wWgatecrZFR3hUCpm4DAEZyDVgmwU=; 25:Vejr34wzsUF7LqyCUPa6k8Bb1dTUvk3WOZ7fRbswc8RZlX7/31G/M69a9P0L/qP929c5i14XjssZshmPsuLaEojTsosTfMATFqLW8g2f3M1u2x0+e6m79EplNzZSrYHOoKLREdIuHGp11v++Q3Z/g5OjksoKUSD7YHZvJ5nUeD9OCGVH2MLhQvtS0TLH9zA711l2SSzpoGhJn/2V/4trpTXUWaYCSjBoWk1M7pt36IG3HN9WbrfeCQL+wJloTXb4jRDfvCfebn6hRLnOJLeDUw==; 20:qItBaAMKcjHeMxAka/Cd/O/NGDBY8u1uJP7BfCqFEvOsCrs78JZqT4dbThsdCQg3OvD1jaUWmqS1ZmNWrEl+6FA54orLX/WT/0FlfZeDa4fGSQQWHgC8KQahuJWY1r3jdSnGe8GgIBFU7p3WAtyiI9LyLoBw3VV7CBw9fbE6tsU= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB2074; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(80048183373757); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(601004)(2401047)(520078)(5005006)(8121501046)(3002001)(10201501046); SRVR:CY1PR0301MB2074; BCL:0; PCL:0; RULEID:; SRVR:CY1PR0301MB2074; X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2074; 4:268Glr4VTijwKb57eGKbWdYzt8koGkqnPxa/1C0DZxxuub865X5woWGZjdu8r2q6BeGsmrzv/dt5DcocNT5M5yT5A+CdDJGH8w/hg5P+ppCMLT2hsoWGJCiit3JdRLTeRMMa/tOKd4uxEWndnNo8VT5O9XqXzTPS5ewOeaPI/9hHHJLCBP1Zsqp2ZIxamhKELRoMzmLXeJoDvx4Ai0YcZ/1SJrqbQ73i1XdcJs7dgkXKrWuGl8JPpU59aIW0hBGRCjAsxDi1gvR8qs29A637g1ZH5z3c28TInoTwsZ+sCqOy9COvV6mu8Q+3YASN2+gQMV0seWUcIgbQpWBI/nG1AOCKa+/bsmVxWQxJiSe8SFSHKAXJYoAlynxp12KpSYmG5YSlqRsOoR40gnUFyCQZ2vXs7vE5JPkijk6IzucKdZp47USN1RQeh5iLR/8UNmSP X-Forefront-PRVS: 077929D941 X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2074; 23:edAJCyV7S37OA3ylPx5GNSiEsuV8p0ioIeQyHrUE2/1gVVMvo0Ei11h0V4/i5GUo9TW2CriSGPEZtS+jAZ31BplR0jwW4q78JyA1mY6hI4j0Q2Exj3xYXu1DN6ncU0D/toMmw2mTzf0uV62GpAgodfDLIu+BdDei4blGE8GAJTuXAXbREO5rqPtPhVbxxKhDtRusllr5M1EtqwdgUtLM24yP8cepILvZq9sM9gQUC0kGMfZ6hLIO3aYz1g9j1oJGarlixfC8ABb9chxhDYvt8dJtuI5TsSd+GBewzvaT/Z5rnE70u0lw+r54Z32D1X+RP9GR41eNkg07yrWmxRThE/uJvcsbBUhqJVhzl6VMrZyjfOlrpz61fVXTIQxt/EWZ5lh4G5teGAc5tLXAXmMzCG3s6ZAD5622dO3YsNnmXB6qermoQdEUjf6UCm7d3S+His1YPgBagaoL1CxvpK9JTbK5iKDoaTQVjRlveaXwbmOfkYGf8bukqp9ID18r79qus+EsLVUBCSkomYv/w6pE5V2+DVpmlwOLMvG60kQRC7nUjj/CTgICDG2ptpE9ubEHtTvCCIofi3RdSI+YAjuaaXe6FEMzxaeSbNt7QMKoLAkv1cCvgqtYUmAj932Yqzy/ZaVVK5/N8BJyLeqDkwGGYQaS1yXC4X+7rqeiEGNhjA6sZZFk8agsPP0nKGc+BgIFEE4ZXLTsVV20PpPARC+bJ16VAyGzcMoPfmltEdupsiHcUXVqAQET3L+g7Hv4qc5SKwzeL8GXmc0TxnvGbaZtsHMb/BEE4aV6HS3eTv/m8BfAlq9pC2YC/3gKb73mUMkEHfjMONVcf7aC9MrBPVW7pPe6//btaKR+4fcxkfPIvtNVbBONoqY/1SGPkPLGFeM5mLY8nngwgQ5OqL/Pyw+lMbP8GS+mVcMm+9EQlnt +I2Z+orVtrYDr+Lu/FoMIvxqc X-Microsoft-Exchange-Diagnostics: 1; CY1PR0301MB2074; 5:ncJKYaQhG5rgUgwvhQJEtetep7J9c6NqCYlYQfoCFUpVhkZJQ8xLDvjRbYrHo/dGvjCU9ISC7K3N6dgQC3zxzP8jGtUPa89Be4KO30hJzoNciOAsqw6eHr28sSbT+qs+xU6iRm5hFdNvMDcNWk3slw==; 24:AzfVxxOe8Lzs7aFVTTjl2Wr2CQ57IXCSwTTkeVyiDfrZuxk4AdhBveM4PTg5VKvSZ04ka7sHs1Ji3rsAgq2FDL26aIDDMSEB6yj764Hl2gU=; 20:BBbPi0dp4eNjpgEwS7tyjnleOPDjVQcJ3JwkgIrqbeCIlk4qvDTTcqSXy8wgwphCMR8/1bQS7ggf5QETiZTGaOJNvmn7YZhQcPnlEQWVfgO/s53mR96CAn4MhsXaJOB0JRlbZaZFEnqKYqO85FM4MV4ailMbXzp5scDmClkvUQg= SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: altera.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Dec 2015 11:18:12.9628 (UTC) X-MS-Exchange-CrossTenant-Id: fbd72e03-d4a5-4110-adce-614d51f2077a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fbd72e03-d4a5-4110-adce-614d51f2077a; Ip=[66.35.236.227]; Helo=[sj-itexedge03.altera.priv.altera.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB2074 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP PCI interrupt lines start at 1, not at 0. So, creates additional one interrupt when register for irq domain. Error when PCIe devices have 4 INTX: WARNING: CPU: 1 PID: 1 at kernel/irq/irqdomain.c:280 irq_domain_associate+0x17c/0x1cc() error: hwirq 0x4 is too large for dummy Tested on Ethernet adapter card with multi-functions. Signed-off-by: Ley Foon Tan --- drivers/pci/host/pcie-altera.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index e4176b3..1a2d4a6 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -467,7 +467,7 @@ static int altera_pcie_init_irq_domain(struct altera_pcie *pcie) struct device_node *node = dev->of_node; /* Setup INTx */ - pcie->irq_domain = irq_domain_add_linear(node, INTX_NUM, + pcie->irq_domain = irq_domain_add_linear(node, INTX_NUM + 1, &intx_domain_ops, pcie); if (!pcie->irq_domain) { dev_err(dev, "Failed to get a INTx IRQ domain\n");