From patchwork Wed Dec 16 15:16:26 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 7862601 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: X-Original-To: patchwork-linux-pci@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 310049F1C2 for ; Wed, 16 Dec 2015 15:21:37 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4B3AB202FE for ; Wed, 16 Dec 2015 15:21:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 584622035E for ; Wed, 16 Dec 2015 15:21:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753582AbbLPPVQ (ORCPT ); Wed, 16 Dec 2015 10:21:16 -0500 Received: from mail-wm0-f52.google.com ([74.125.82.52]:34404 "EHLO mail-wm0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965813AbbLPPSJ (ORCPT ); Wed, 16 Dec 2015 10:18:09 -0500 Received: by mail-wm0-f52.google.com with SMTP id l126so44180913wml.1 for ; Wed, 16 Dec 2015 07:18:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=U2RmdoQypTfgnkS55VkS7cgOv3Ks+hwhPLh9zo24lFI=; b=hI1RkSsI86sUfUcX36lIAFgTOBnRVsB7pqr+mR3kBC5YEpqkCw2nfrduNC+Zd8M1FI gD++njW1KROwX3V6aYI1B9bquI0Pbz+4oSrm/73g3RK5WsMHiKaYF5KpTE7sPzdL9V2I htgTKkrK70qZMVEaYCXF9Ut9UFY9/YmG+mwwySjOS/gOwCBjVo7rbUANaZdzA5Sv5vBb F0zlNT/O0REUxRSAIoNdHveIhVsvoUm9OXtkcBdue3QuferzkNJPznvsZgnYMjRyrA5m +lBUO+KbxFXMSdgxkrqRIzYt2hk27PbKbzJg1tY207fzOckM0kcXC63YifG6k6V//cyA k13A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=U2RmdoQypTfgnkS55VkS7cgOv3Ks+hwhPLh9zo24lFI=; b=gIgQFCeldLjYGHchyrIxFLJenjY2Lo++5Tz9fTu5U9UTTS35OOSc7A0HqWrglJsvz/ yUSk4hVflthEs1bw/fLg/+xlkuwFRDgJ04tK8hTV8Z+2Wb+HHgp5xHh5IIwZ42WQnCau HMY+7bNnXPe6Pa5uWLsOpXnvcRWvXFolN29FZwhUO3esZvmLtVXNfvJEjKh0NjZ1pyaB YZn/9JKoj4GjSgNI1uR9STQDNpKrCgKpt/WwZjfdCzKpuA1Y6TyOo8u0zXy10MXoMuI7 o34eS0PRvfm+PKQfJqB+n9wLwXRNIoIY7JyPggNz/3xNrKw0E7JUGDRS7yECotWHilhq rolg== X-Gm-Message-State: ALoCoQlcyyF7YVdu5RUgnFtzvRQNzMgQJb3/bZDqEPfsZaaGv/Y3riDuHmyO6LLjIrpdC0D+QSVTGqtC6tDXmC4akqfJVj80vA== X-Received: by 10.194.158.73 with SMTP id ws9mr18998212wjb.40.1450279088239; Wed, 16 Dec 2015 07:18:08 -0800 (PST) Received: from tn-HP-4.semihalf.local ([80.82.22.190]) by smtp.gmail.com with ESMTPSA id z17sm6438761wjq.1.2015.12.16.07.18.06 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 16 Dec 2015 07:18:07 -0800 (PST) From: Tomasz Nowicki To: bhelgaas@google.com, arnd@arndb.de, will.deacon@arm.com, catalin.marinas@arm.com, rjw@rjwysocki.net, hanjun.guo@linaro.org, Lorenzo.Pieralisi@arm.com, okaya@codeaurora.org, jiang.liu@linux.intel.com, Stefano.Stabellini@eu.citrix.com Cc: robert.richter@caviumnetworks.com, mw@semihalf.com, Liviu.Dudau@arm.com, ddaney@caviumnetworks.com, tglx@linutronix.de, wangyijing@huawei.com, Suravee.Suthikulpanit@amd.com, msalter@redhat.com, linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linaro-acpi@lists.linaro.org, jchandra@broadcom.com, jcm@redhat.com, Tomasz Nowicki Subject: [PATCH V2 16/23] x86, ia64: Include acpi_pci_{add|remove}_bus to the default pcibios_{add|remove}_bus implementation. Date: Wed, 16 Dec 2015 16:16:26 +0100 Message-Id: <1450278993-12664-17-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1450278993-12664-1-git-send-email-tn@semihalf.com> References: <1450278993-12664-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID,T_RP_MATCHES_RCVD,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Arches in subject are the only one who use pcibios_{add|remove}_bus hooks and implement it in the same way. Moreover ARM64 is going to do the same. So it seams that acpi_pci_{add|remove}_bus is generic enough to be default option for pcibios_{add|remove}_bus hooks. Also, it is always safe to run acpi_pci_{add|remove}_bus as they have empty stubs for !ACPI case and return if ACPI has been switched off in run time. After all we can remove x86 and ia64 pcibios_{add|remove}_bus implementation. Signed-off-by: Tomasz Nowicki --- arch/ia64/pci/pci.c | 10 ---------- arch/x86/pci/common.c | 10 ---------- drivers/pci/probe.c | 3 +++ 3 files changed, 3 insertions(+), 20 deletions(-) diff --git a/arch/ia64/pci/pci.c b/arch/ia64/pci/pci.c index fe96bc9..c1e8ed5 100644 --- a/arch/ia64/pci/pci.c +++ b/arch/ia64/pci/pci.c @@ -357,16 +357,6 @@ void pcibios_fixup_bus(struct pci_bus *b) platform_pci_fixup_bus(b); } -void pcibios_add_bus(struct pci_bus *bus) -{ - acpi_pci_add_bus(bus); -} - -void pcibios_remove_bus(struct pci_bus *bus) -{ - acpi_pci_remove_bus(bus); -} - void pcibios_set_master (struct pci_dev *dev) { /* No special bus mastering setup handling */ diff --git a/arch/x86/pci/common.c b/arch/x86/pci/common.c index eccd4d9..ed3236d 100644 --- a/arch/x86/pci/common.c +++ b/arch/x86/pci/common.c @@ -171,16 +171,6 @@ void pcibios_fixup_bus(struct pci_bus *b) pcibios_fixup_device_resources(dev); } -void pcibios_add_bus(struct pci_bus *bus) -{ - acpi_pci_add_bus(bus); -} - -void pcibios_remove_bus(struct pci_bus *bus) -{ - acpi_pci_remove_bus(bus); -} - /* * Only use DMI information to set this if nothing was passed * on the kernel command line (which was parsed earlier). diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c index cad836f..2fbf840 100644 --- a/drivers/pci/probe.c +++ b/drivers/pci/probe.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include #include @@ -2067,10 +2068,12 @@ int __weak pcibios_root_bridge_prepare(struct pci_host_bridge *bridge) void __weak pcibios_add_bus(struct pci_bus *bus) { + acpi_pci_add_bus(bus); } void __weak pcibios_remove_bus(struct pci_bus *bus) { + acpi_pci_remove_bus(bus); } struct pci_bus *pci_create_root_bus(struct device *parent, int bus,