diff mbox

PCI: host-generic: select IRQ_DOMAIN

Message ID 1463581000-983246-1-git-send-email-arnd@arndb.de (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Arnd Bergmann May 18, 2016, 2:15 p.m. UTC
The generic PCI host controller calls of_irq_parse_and_map_pci
in its IRQ fixup, but that function is only available when
CONFIG_IRQ_DOMAIN is set:

drivers/pci/built-in.o: In function `pci_host_common_probe':
drivers/pci/host/pci-host-common.c:181: undefined reference to `of_irq_parse_and_map_pci'

There is no downside in enabling the domains here, so let's
use a Kconfig select statement to ensure it's always available
to this driver.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/pci/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Helgaas June 11, 2016, midnight UTC | #1
On Wed, May 18, 2016 at 04:15:53PM +0200, Arnd Bergmann wrote:
> The generic PCI host controller calls of_irq_parse_and_map_pci
> in its IRQ fixup, but that function is only available when
> CONFIG_IRQ_DOMAIN is set:
> 
> drivers/pci/built-in.o: In function `pci_host_common_probe':
> drivers/pci/host/pci-host-common.c:181: undefined reference to `of_irq_parse_and_map_pci'
> 
> There is no downside in enabling the domains here, so let's
> use a Kconfig select statement to ensure it's always available
> to this driver.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Applied to pci/host-generic for v4.8, thanks, Arnd.

> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index 66329b932e29..64734ba070a2 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -87,6 +87,7 @@ config PCI_HOST_GENERIC
>  	bool "Generic PCI host controller"
>  	depends on (ARM || ARM64) && OF
>  	select PCI_HOST_COMMON
> +	select IRQ_DOMAIN
>  	help
>  	  Say Y here if you want to support a simple generic PCI host
>  	  controller, such as the one emulated by kvmtool.
> -- 
> 2.7.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index 66329b932e29..64734ba070a2 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -87,6 +87,7 @@  config PCI_HOST_GENERIC
 	bool "Generic PCI host controller"
 	depends on (ARM || ARM64) && OF
 	select PCI_HOST_COMMON
+	select IRQ_DOMAIN
 	help
 	  Say Y here if you want to support a simple generic PCI host
 	  controller, such as the one emulated by kvmtool.