From patchwork Mon Jun 13 14:41:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Nowicki X-Patchwork-Id: 9173241 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 69CAD60573 for ; Mon, 13 Jun 2016 14:42:27 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5923A27AC2 for ; Mon, 13 Jun 2016 14:42:27 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4DCB126861; Mon, 13 Jun 2016 14:42:27 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A23DF27C0C for ; Mon, 13 Jun 2016 14:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424397AbcFMOmI (ORCPT ); Mon, 13 Jun 2016 10:42:08 -0400 Received: from mail-lf0-f54.google.com ([209.85.215.54]:35925 "EHLO mail-lf0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424358AbcFMOmE (ORCPT ); Mon, 13 Jun 2016 10:42:04 -0400 Received: by mail-lf0-f54.google.com with SMTP id q132so48139714lfe.3 for ; Mon, 13 Jun 2016 07:42:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vw2LF7KUw6IBSpMQG4NCsiagbggc7LOi1sRgkCFvUuQ=; b=ml/cUqRl1MCNDTyogM/YVwHuRl6QSCE+L2uFxryfOQPdrmVPqCL80fQK5Zbl19y6Qe Iz8Igvn9NPjHHMQx1ylckLkvq87Yq2XXQibIpE4o0HoXHHiwLhIG5EV0rEfURMT4IbS5 dCeNS/IN6b4hwaW0QXzn+z6af6DrgkdFRsdj9kVaPoPF1Q/x6HkuyT98QAviZD9XXJY7 tFO16oIeM3VHNSJU04fvphCb6xXy9XHQiBTkS7+jqW6iHbvCh9hF54+KfNSkL7GRpP+q IpMX448Mi3jAQt9BKY6prEYvYm1Xa7XHR+BCwbF89M4GdlndEOq1NTn2Ft8/DCCYnNQ9 hqYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vw2LF7KUw6IBSpMQG4NCsiagbggc7LOi1sRgkCFvUuQ=; b=RcAXQ4ReU58xpjZOvSLHDW46Eefmttewyj8WosBjQcp1dlXkI5Om7ogTvesvqj9MZ7 usTOuEJgHJ28FBE64gnriVC1TsLirbgXmyZe89SXywGYb5gq9ehf+IyZYZyUJqC4gbk+ 7GXiK8+r1YuyNOgng4WGgxbc4yLpt4vRLh6vTQIEklsiH/LI9nj6V/MV1CjCg60pyIH5 LHyebVQSyqARmk/XcKoS9l7Lrccp49TKn92nTN8vLcUQnkvV0BxhitJUB+WFrK/6QQLl IoNSAwBMeV5m0+Wijb9+IlNwSZ0gWrv0xWGVoteYd0C71i3DN8qQ7eUea62+XivUPO3o /gFw== X-Gm-Message-State: ALyK8tKFVLrqnMYFkd6qyDhL3Fwoswyqjy1r4AApMN3zJncK96lTtihvopFI7cXAYT9BKg== X-Received: by 10.25.209.71 with SMTP id i68mr442204lfg.20.1465828917041; Mon, 13 Jun 2016 07:41:57 -0700 (PDT) Received: from tn-HP-4.semihalf.local (31-172-191-173.noc.fibertech.net.pl. [31.172.191.173]) by smtp.gmail.com with ESMTPSA id l79sm394242lfi.40.2016.06.13.07.41.54 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 13 Jun 2016 07:41:56 -0700 (PDT) From: Tomasz Nowicki To: marc.zyngier@arm.com, tglx@linutronix.de, jason@lakedaemon.net, rjw@rjwysocki.net, bhelgaas@google.com, lorenzo.pieralisi@arm.com, robert.richter@caviumnetworks.com, shijie.huang@arm.com, Suravee.Suthikulpanit@amd.com, hanjun.guo@linaro.org Cc: al.stone@linaro.org, mw@semihalf.com, graeme.gregory@linaro.org, Catalin.Marinas@arm.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org, ddaney.cavm@gmail.com, okaya@codeaurora.org, andrea.gallo@linaro.org, linux-pci@vger.kernel.org, Tomasz Nowicki Subject: [PATCH V6 6/7] irqchip/gicv3-its: Factor out code that might be reused for ACPI Date: Mon, 13 Jun 2016 16:41:12 +0200 Message-Id: <1465828873-23498-7-git-send-email-tn@semihalf.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1465828873-23498-1-git-send-email-tn@semihalf.com> References: <1465828873-23498-1-git-send-email-tn@semihalf.com> Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Firmware agnostic code lands in common functions which do necessary domain initialization based on unique domain handler. DT specific code goes to DT specific init call. Signed-off-by: Tomasz Nowicki Acked-by: Marc Zyngier --- drivers/irqchip/irq-gic-v3-its-pci-msi.c | 44 +++++++++++++++++++++----------- 1 file changed, 29 insertions(+), 15 deletions(-) diff --git a/drivers/irqchip/irq-gic-v3-its-pci-msi.c b/drivers/irqchip/irq-gic-v3-its-pci-msi.c index aee60ed..23679ae 100644 --- a/drivers/irqchip/irq-gic-v3-its-pci-msi.c +++ b/drivers/irqchip/irq-gic-v3-its-pci-msi.c @@ -106,34 +106,48 @@ static struct of_device_id its_device_id[] = { {}, }; -static int __init its_pci_msi_init(void) +static int __init its_pci_msi_init_one(struct fwnode_handle *handle, + const char *name) { - struct device_node *np; struct irq_domain *parent; + parent = irq_find_matching_fwnode(handle, DOMAIN_BUS_NEXUS); + if (!parent || !msi_get_domain_info(parent)) { + pr_err("%s: Unable to locate ITS domain\n", name); + return -ENXIO; + } + + if (!pci_msi_create_irq_domain(handle, &its_pci_msi_domain_info, + parent)) { + pr_err("%s: Unable to create PCI domain\n", name); + return -ENOMEM; + } + + return 0; +} + +static int __init its_pci_of_msi_init(void) +{ + struct device_node *np; + for (np = of_find_matching_node(NULL, its_device_id); np; np = of_find_matching_node(np, its_device_id)) { if (!of_property_read_bool(np, "msi-controller")) continue; - parent = irq_find_matching_host(np, DOMAIN_BUS_NEXUS); - if (!parent || !msi_get_domain_info(parent)) { - pr_err("%s: unable to locate ITS domain\n", - np->full_name); + if (its_pci_msi_init_one(of_node_to_fwnode(np), np->full_name)) continue; - } - - if (!pci_msi_create_irq_domain(of_node_to_fwnode(np), - &its_pci_msi_domain_info, - parent)) { - pr_err("%s: unable to create PCI domain\n", - np->full_name); - continue; - } pr_info("PCI/MSI: %s domain created\n", np->full_name); } return 0; } + +static int __init its_pci_msi_init(void) +{ + its_pci_of_msi_init(); + return 0; +} + early_initcall(its_pci_msi_init);