diff mbox

pciehp: Clear attention LED on device add

Message ID 1470266985-28906-1-git-send-email-keith.busch@intel.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Keith Busch Aug. 3, 2016, 11:29 p.m. UTC
This patch clears the LED attention status after a successful device
add. It is possible the attention LED was on from a previous power fault
or link failure, and a subsequent successful device inserted in the slot
should clear it.

Signed-off-by: Keith Busch <keith.busch@intel.com>
---
 drivers/pci/hotplug/pciehp_ctrl.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Bjorn Helgaas Aug. 22, 2016, 4:59 p.m. UTC | #1
On Wed, Aug 03, 2016 at 05:29:45PM -0600, Keith Busch wrote:
> This patch clears the LED attention status after a successful device
> add. It is possible the attention LED was on from a previous power fault
> or link failure, and a subsequent successful device inserted in the slot
> should clear it.
> 
> Signed-off-by: Keith Busch <keith.busch@intel.com>

Applied to pci/hotplug for v4.9, thanks, Keith!

> ---
>  drivers/pci/hotplug/pciehp_ctrl.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
> index 880978b..7ea3e61 100644
> --- a/drivers/pci/hotplug/pciehp_ctrl.c
> +++ b/drivers/pci/hotplug/pciehp_ctrl.c
> @@ -120,6 +120,7 @@ static int board_added(struct slot *p_slot)
>  	}
>  
>  	pciehp_green_led_on(p_slot);
> +	pciehp_set_attention_status(p_slot, 0);
>  	return 0;
>  
>  err_exit:
> -- 
> 2.7.2
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/hotplug/pciehp_ctrl.c b/drivers/pci/hotplug/pciehp_ctrl.c
index 880978b..7ea3e61 100644
--- a/drivers/pci/hotplug/pciehp_ctrl.c
+++ b/drivers/pci/hotplug/pciehp_ctrl.c
@@ -120,6 +120,7 @@  static int board_added(struct slot *p_slot)
 	}
 
 	pciehp_green_led_on(p_slot);
+	pciehp_set_attention_status(p_slot, 0);
 	return 0;
 
 err_exit: