From patchwork Mon Oct 17 14:56:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Wei Yongjun X-Patchwork-Id: 9379521 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 514F3607D4 for ; Mon, 17 Oct 2016 14:56:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 43486292D8 for ; Mon, 17 Oct 2016 14:56:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 38012292F9; Mon, 17 Oct 2016 14:56:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 392FC292D8 for ; Mon, 17 Oct 2016 14:56:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934706AbcJQO4e (ORCPT ); Mon, 17 Oct 2016 10:56:34 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34599 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933745AbcJQO4e (ORCPT ); Mon, 17 Oct 2016 10:56:34 -0400 Received: by mail-pf0-f194.google.com with SMTP id 128so12957618pfz.1 for ; Mon, 17 Oct 2016 07:56:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1Z0I2+VmZrO1hzn++6E9dHggzB5/INje1KuhIPosuxg=; b=rRRI1zTVaYA2C+7s7dbynKnOHqNx61QdmGnWDKJ3YaCUh5snuKJKsdqum8ylKjAZNJ va5pyL6N78STbDOsf5jtqQBe6ET9/KadUohNxvM39cB5Jb/iw9F85NTJFaGhvozWFeHd qQSkrdrGNIPblBazVhAuJ0bmGWgJ9Ekt3e8DH1eWPet6lOYtRaP6PxopaIqVw9V+l86s zh3uOil7Ctb69FY9kYTDZq+XE1mOAFD29Hi7ryJKxHM0Q7m1hAHi5JzRajCVFNU13+Ks w6glLF+953OyKq4Ja+NsKts0OPSJszh+ogZAyT/IZJ3X0oA9EWtrvquBO79O37ueIldE wr6A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=1Z0I2+VmZrO1hzn++6E9dHggzB5/INje1KuhIPosuxg=; b=dHyoepsHT8SooeYKKbnauqJ9mjsaCdLfdUtYuudMUasE73ld7SfKm78uKgrinjpHQ4 MF0UGKKFqVx0hsb/4m6MvynVr/qoXBortClQw17xnTAPUUZUBS9i59Nqmrg/iOhLnVvX CEmw0YrrJV/nHhXPkz13kKDrC0gqNC6GP03dimUWbntkj4gnS+rJ0hvP7hhkd9TviHSe 6Oghs6uL0PSimEDdzMBlfAMFJKY17xxCF8ux+WclW/5wF1yKmN/JgoAZQ3eys6N5vw6w 0UWSUI6/2VsWPwOUc3Y4KZ7Y77GUuqSwcWWe+2qMn0HGS7JYM7vfMrs3sPljGKR6zkyJ r0bg== X-Gm-Message-State: AA6/9RmY5caqRc//qR/mQZPapoTt93FomY7dsfXAVrgkFt1od/CAMXNq4FLndQ7K587nNw== X-Received: by 10.98.66.149 with SMTP id h21mr24526132pfd.32.1476716193393; Mon, 17 Oct 2016 07:56:33 -0700 (PDT) Received: from 192.168.0.37 (ec2-52-192-197-227.ap-northeast-1.compute.amazonaws.com. [52.192.197.227]) by smtp.gmail.com with ESMTPSA id u17sm48799246pfa.83.2016.10.17.07.56.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Oct 2016 07:56:33 -0700 (PDT) From: Wei Yongjun To: Ley Foon Tan , Bjorn Helgaas Cc: Wei Yongjun , rfi@lists.rocketboards.org, linux-pci@vger.kernel.org Subject: [PATCH -next] PCI: altera: Remove redundant dev_err call in altera_pcie_parse_dt() Date: Mon, 17 Oct 2016 14:56:13 +0000 Message-Id: <1476716173-31310-1-git-send-email-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Wei Yongjun There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun Acked-by: Ley Foon Tan --- drivers/pci/host/pcie-altera.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff --git a/drivers/pci/host/pcie-altera.c b/drivers/pci/host/pcie-altera.c index b0ac4df..8be45a8 100644 --- a/drivers/pci/host/pcie-altera.c +++ b/drivers/pci/host/pcie-altera.c @@ -550,10 +550,8 @@ static int altera_pcie_parse_dt(struct altera_pcie *pcie) cra = platform_get_resource_byname(pdev, IORESOURCE_MEM, "Cra"); pcie->cra_base = devm_ioremap_resource(dev, cra); - if (IS_ERR(pcie->cra_base)) { - dev_err(dev, "failed to map cra memory\n"); + if (IS_ERR(pcie->cra_base)) return PTR_ERR(pcie->cra_base); - } /* setup IRQ */ pcie->irq = platform_get_irq(pdev, 0);