From patchwork Tue Nov 8 08:14:14 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 9416703 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CF2AA6022E for ; Tue, 8 Nov 2016 06:32:16 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BEE7A200E7 for ; Tue, 8 Nov 2016 06:32:16 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B1C7128C39; Tue, 8 Nov 2016 06:32:16 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 19585200E7 for ; Tue, 8 Nov 2016 06:32:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752837AbcKHGcO (ORCPT ); Tue, 8 Nov 2016 01:32:14 -0500 Received: from p3plsmtps2ded02.prod.phx3.secureserver.net ([208.109.80.59]:41956 "EHLO p3plsmtps2ded02.prod.phx3.secureserver.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752380AbcKHGcN (ORCPT ); Tue, 8 Nov 2016 01:32:13 -0500 X-Greylist: delayed 675 seconds by postgrey-1.27 at vger.kernel.org; Tue, 08 Nov 2016 01:32:13 EST Received: from linuxonhyperv.com ([72.167.245.219]) by : HOSTING RELAY : with SMTP id 3zlFc5gu2fa3y3zlFclgVP; Mon, 07 Nov 2016 23:19:57 -0700 x-originating-ip: 72.167.245.219 Received: by linuxonhyperv.com (Postfix, from userid 511) id A37CD19028C; Tue, 8 Nov 2016 00:14:21 -0800 (PST) From: Long Li To: "K. Y. Srinivasan" , Haiyang Zhang , Bjorn Helgaas Cc: devel@linuxdriverproject.org, linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Long Li Subject: [Resend] [PATCH] pci-hyperv: use kmalloc to allocate hypercall params buffer Date: Tue, 8 Nov 2016 00:14:14 -0800 Message-Id: <1478592854-17303-1-git-send-email-longli@exchange.microsoft.com> X-Mailer: git-send-email 1.7.4.1 X-CMAE-Envelope: MS4wfD84wl841oXbJKqKsWnVgWs5Vg/ie2GSxy2wfm8iNi5xzCpKYtP+lH7x/3dP9s6t0SVsrQWumji33BBSzAo7hkHHZQBjNEo7yK7dFXMnwHjeiJQoQYGS AQfxmyZjp+bt3E+Ws7Tr+6KWu7mLpcR11FFbq7a5LgPJ9dyDQhqfMTBD30BVu7cwM82Sy6pIrqfk2H1n3XItozth5fnZ4gEtqDiBv8G2UPjiq4vjZYnydg5G PQmJHrxEtu8yV1ZPY2EHvyDkdrvdsI0VZoTrd01swiYZXTLqFAFzBmob06dKHKBCQgz2uX/aq1Toe8t+vZohLNzAU7IBqInrEsiDSWfuedGksV6MYeNSFG6t h7aH+WfD5g/U2ePV53V0MFrUgY4yDxGuRneDkv336QEoDVnkqog= Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Long Li hv_do_hypercall assumes that we pass a segment from a physically continuous buffer. Buffer allocated on the stack may not work if CONFIG_VMAP_STACK=y is set. Use kmalloc to allocate this buffer. Signed-off-by: Long Li Reported-by: Haiyang Zhang --- drivers/pci/host/pci-hyperv.c | 24 +++++++++++++----------- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/drivers/pci/host/pci-hyperv.c b/drivers/pci/host/pci-hyperv.c index 763ff87..97e6daf 100644 --- a/drivers/pci/host/pci-hyperv.c +++ b/drivers/pci/host/pci-hyperv.c @@ -378,6 +378,7 @@ struct hv_pcibus_device { struct msi_domain_info msi_info; struct msi_controller msi_chip; struct irq_domain *irq_domain; + struct retarget_msi_interrupt retarget_msi_interrupt_params; }; /* @@ -774,7 +775,7 @@ void hv_irq_unmask(struct irq_data *data) { struct msi_desc *msi_desc = irq_data_get_msi_desc(data); struct irq_cfg *cfg = irqd_cfg(data); - struct retarget_msi_interrupt params; + struct retarget_msi_interrupt *params; struct hv_pcibus_device *hbus; struct cpumask *dest; struct pci_bus *pbus; @@ -785,23 +786,24 @@ void hv_irq_unmask(struct irq_data *data) pdev = msi_desc_to_pci_dev(msi_desc); pbus = pdev->bus; hbus = container_of(pbus->sysdata, struct hv_pcibus_device, sysdata); - - memset(¶ms, 0, sizeof(params)); - params.partition_id = HV_PARTITION_ID_SELF; - params.source = 1; /* MSI(-X) */ - params.address = msi_desc->msg.address_lo; - params.data = msi_desc->msg.data; - params.device_id = (hbus->hdev->dev_instance.b[5] << 24) | + params = &hbus->retarget_msi_interrupt_params; + + memset(params, 0, sizeof(*params)); + params->partition_id = HV_PARTITION_ID_SELF; + params->source = 1; /* MSI(-X) */ + params->address = msi_desc->msg.address_lo; + params->data = msi_desc->msg.data; + params->device_id = (hbus->hdev->dev_instance.b[5] << 24) | (hbus->hdev->dev_instance.b[4] << 16) | (hbus->hdev->dev_instance.b[7] << 8) | (hbus->hdev->dev_instance.b[6] & 0xf8) | PCI_FUNC(pdev->devfn); - params.vector = cfg->vector; + params->vector = cfg->vector; for_each_cpu_and(cpu, dest, cpu_online_mask) - params.vp_mask |= (1ULL << vmbus_cpu_number_to_vp_number(cpu)); + params->vp_mask |= (1ULL << vmbus_cpu_number_to_vp_number(cpu)); - hv_do_hypercall(HVCALL_RETARGET_INTERRUPT, ¶ms, NULL); + hv_do_hypercall(HVCALL_RETARGET_INTERRUPT, params, NULL); pci_msi_unmask_irq(data); }