diff mbox

[2/2] PCI/VMD: Select SRCU

Message ID 1478904657-11342-2-git-send-email-jonathan.derrick@intel.com (mailing list archive)
State New, archived
Delegated to: Bjorn Helgaas
Headers show

Commit Message

Jon Derrick Nov. 11, 2016, 10:50 p.m. UTC
VMD now uses SRCU, so we must qualify that it is part of the kernel.

Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
---
 drivers/pci/host/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Keith Busch Nov. 11, 2016, 11:10 p.m. UTC | #1
On Fri, Nov 11, 2016 at 03:50:57PM -0700, Jon Derrick wrote:
> VMD now uses SRCU, so we must qualify that it is part of the kernel.
> 
> Signed-off-by: Jon Derrick <jonathan.derrick@intel.com>
> ---
>  drivers/pci/host/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
> index d7e7c0a..80ffa66 100644
> --- a/drivers/pci/host/Kconfig
> +++ b/drivers/pci/host/Kconfig
> @@ -287,6 +287,7 @@ config PCIE_ROCKCHIP
>  
>  config VMD
>  	depends on PCI_MSI && X86_64
> +	select SRCU
>  	tristate "Intel Volume Management Device Driver"
>  	default N
>  	---help---

I think it'd be better to squash this patch with the first in this series,
and append SRCU to the 'depends on' section rather than select it.

I get the feeling that having both 'select' and 'depends on' in the
Kconfig syntax is not a well loved feature:
 https://www.linuxplumbersconf.org/2016/ocw/proposals/4605
--
To unsubscribe from this list: send the line "unsubscribe linux-pci" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/pci/host/Kconfig b/drivers/pci/host/Kconfig
index d7e7c0a..80ffa66 100644
--- a/drivers/pci/host/Kconfig
+++ b/drivers/pci/host/Kconfig
@@ -287,6 +287,7 @@  config PCIE_ROCKCHIP
 
 config VMD
 	depends on PCI_MSI && X86_64
+	select SRCU
 	tristate "Intel Volume Management Device Driver"
 	default N
 	---help---