From patchwork Tue Dec 27 14:40:43 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9489297 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 8DAB560838 for ; Tue, 27 Dec 2016 14:41:22 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 745411FFD6 for ; Tue, 27 Dec 2016 14:41:22 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6505625F31; Tue, 27 Dec 2016 14:41:22 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.3 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC2C71FFD6 for ; Tue, 27 Dec 2016 14:41:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932525AbcL0OlO (ORCPT ); Tue, 27 Dec 2016 09:41:14 -0500 Received: from mail-qt0-f194.google.com ([209.85.216.194]:33603 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932451AbcL0OlN (ORCPT ); Tue, 27 Dec 2016 09:41:13 -0500 Received: by mail-qt0-f194.google.com with SMTP id 41so15682870qtn.0 for ; Tue, 27 Dec 2016 06:40:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id; bh=UZtmGrEPmkNzqrLPFo2VCYITGWY5GgCblkXE6ZgnqoE=; b=cJQ+9G13B+ouXzkKVXGkqdXf7eqfopHtwa1r7lDkT64QLZmHaCA3bRpggI+b9muZS2 jrr8prEw4oTp4hvv3h4Z4QwA186Y45HyREiNWYYi2QskSmxjVBFy6XTolWqVLj2Vg6a4 bWmofxSkSgQK+ivinopzlYgwqRONV6EaCVhR100O93opRghM7cuYjRfRSvM0HZa+L8k0 BPqp/fj4FoolYPdZ23icDeqkBJF5jlHR3POfauvMfpu1wMjocgx2x0rtm5GbjLtBm5Oe h2czAYLfc3VoGs8clYScMdfI5M0vAyRHCTILAhRboUEm/Qa38222wnjG0vJV+zgaVJfz wlvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=UZtmGrEPmkNzqrLPFo2VCYITGWY5GgCblkXE6ZgnqoE=; b=OX11fqLxJh1+7byuM2TeTsH/ayNjNuX99UKf26jy5jhxRT4PtpGQ8VT8svABM/GP5A /uA2qMYHArTn6VXfmFCySYrs4+FDlZhtKTAazHbiq5VuZMZ4jTtcBF0AlDleItODvRex hXk8Xk+iD/H5dSxu7bLihPafT1QkXwc05icV1NLCG7Ihxsm0M/GgfKmf9OycI4CA3yDa IIsQYhrL8NpinKn87kRnZ+ToBcrRWvJw2gEAtKAG0Un1bAI2JrbsYVQazpew5MmVRbxg a7Hp3DzO+uAL61EQE30U/O7SNG9z/f18LF97aTBKkLM5eRqmNz1O+t6BVbPK6nik6dOP nUOQ== X-Gm-Message-State: AIkVDXLR5oVLKDx1DmHC7IOWLkYd9tUkc/qUj+MmPI5AIe7Z669jq+ZswgVxIgnS7dikZg== X-Received: by 10.237.40.38 with SMTP id r35mr30123809qtd.0.1482849645170; Tue, 27 Dec 2016 06:40:45 -0800 (PST) Received: from localhost.localdomain ([187.180.187.205]) by smtp.gmail.com with ESMTPSA id 14sm28567700qtp.19.2016.12.27.06.40.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 27 Dec 2016 06:40:44 -0800 (PST) From: Fabio Estevam To: bhelgaas@google.com Cc: hongxing.zhu@nxp.com, l.stach@pengutronix.de, linux-pci@vger.kernel.org, Fabio Estevam Subject: [PATCH] PCI: imx6: Remove redundant message Date: Tue, 27 Dec 2016 12:40:43 -0200 Message-Id: <1482849643-1861-1-git-send-email-festevam@gmail.com> X-Mailer: git-send-email 2.7.4 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Fabio Estevam When a PCI card is not connected, the following messages are seen on mx6: imx6q-pcie 1ffc000.pcie: phy link never came up imx6q-pcie 1ffc000.pcie: Link never came up The first one comes from the pcie-designware.c core file, so remove the redundant one from the imx6 driver. Signed-off-by: Fabio Estevam Reviewed-by: Lucas Stach --- drivers/pci/host/pci-imx6.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/pci/host/pci-imx6.c b/drivers/pci/host/pci-imx6.c index c8cefb0..66c3b84 100644 --- a/drivers/pci/host/pci-imx6.c +++ b/drivers/pci/host/pci-imx6.c @@ -502,10 +502,8 @@ static int imx6_pcie_establish_link(struct imx6_pcie *imx6_pcie) IMX6Q_GPR12_PCIE_CTL_2, 1 << 10); ret = imx6_pcie_wait_for_link(imx6_pcie); - if (ret) { - dev_info(dev, "Link never came up\n"); + if (ret) goto err_reset_phy; - } if (imx6_pcie->link_gen == 2) { /* Allow Gen2 mode after the link is up. */