From patchwork Fri Apr 7 14:32:18 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joerg Roedel X-Patchwork-Id: 9669611 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id A772C6021C for ; Fri, 7 Apr 2017 14:32:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9930F27CF9 for ; Fri, 7 Apr 2017 14:32:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D3C327DA4; Fri, 7 Apr 2017 14:32:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 702EB27CF9 for ; Fri, 7 Apr 2017 14:32:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756643AbdDGOcY (ORCPT ); Fri, 7 Apr 2017 10:32:24 -0400 Received: from 8bytes.org ([81.169.241.247]:48921 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756579AbdDGOcX (ORCPT ); Fri, 7 Apr 2017 10:32:23 -0400 Received: by theia.8bytes.org (Postfix, from userid 1000) id 3A7A7433; Fri, 7 Apr 2017 16:32:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1491575542; bh=tnPGior81rV7Oo84dIYJDInpxSl0IJ2hluGFC/fZMYw=; h=From:To:Cc:Subject:Date:From; b=Up18t1QOyWXwM6xYKce2kMcilghteKxpJ6hYgwnUMAEROtcIbWc4w74Vm5O9kLhzy vpuvmfHH3UnaeoRXlyM0Cys11hFS4Hi0ND5/sOkuKaSIrkxFBeeyksSgLKSv6QL8Cl YaXKIyhG48YFBpLo19pk6uhc2xHyDfl1gNkYYIYGooZh0Eb3FEsrpw4TzT0QyBsmV7 yijqNxjrThjcSkYJjBVeUUAcITzeSGHXs3UZCzv+SZbshJx8Se8zZin5qB1tEQoGEj hH2OIQ9nQnL2N2S9l+8W6ekdTwlZtxFg8xMgWIFrQeiSlHnrEQfg2F7SzlDUgX1870 FFwcS8Vqhy7OQ== From: Joerg Roedel To: Bjorn Helgaas Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake , Alexander Deucher , Samuel Sieb , David Woodhouse , Joerg Roedel Subject: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Date: Fri, 7 Apr 2017 16:32:18 +0200 Message-Id: <1491575538-22694-1-git-send-email-joro@8bytes.org> X-Mailer: git-send-email 1.9.1 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Joerg Roedel ATS is broken on this hardware and causes IOMMU stalls and system failure. Disable ATS on these devices to make them usable again with IOMMU enabled. Note that the commit in the Fixes-tag is not buggy, it just uncovers the problem in the hardware by increasing the ATS-flush rate. Fixes: b1516a14657a ('iommu/amd: Implement flush queue') Signed-off-by: Joerg Roedel Acked-by: Alex Deucher --- drivers/pci/quirks.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 6736836..7cbe316 100644 --- a/drivers/pci/quirks.c +++ b/drivers/pci/quirks.c @@ -4634,3 +4634,22 @@ static void quirk_no_aersid(struct pci_dev *pdev) DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2031, quirk_no_aersid); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2032, quirk_no_aersid); DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2033, quirk_no_aersid); + +#ifdef CONFIG_PCI_ATS +/* + * Some devices have a broken ATS implementation causing IOMMU stalls. + * Don't use ATS for those devices. + */ +static void quirk_disable_ats(struct pci_dev *pdev) +{ + /* + * Set pdev->ats_cap = 0 to make pci_enable_ats() bail out + * early. + */ + dev_info(&pdev->dev, "QUIRK: Disabling ATS"); + pdev->ats_cap = 0; +} + +/* AMD Stoney platform GPU */ +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x98e4, quirk_disable_ats); +#endif /* CONFIG_PCI_ATS */