From patchwork Thu Aug 31 17:52:02 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabio Estevam X-Patchwork-Id: 9932665 X-Patchwork-Delegate: bhelgaas@google.com Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 7DF1A603FB for ; Thu, 31 Aug 2017 17:53:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6F28928A41 for ; Thu, 31 Aug 2017 17:53:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 6E01328A4A; Thu, 31 Aug 2017 17:53:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BD0BB28A49 for ; Thu, 31 Aug 2017 17:53:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751406AbdHaRw5 (ORCPT ); Thu, 31 Aug 2017 13:52:57 -0400 Received: from mail-cys01nam02on0052.outbound.protection.outlook.com ([104.47.37.52]:23168 "EHLO NAM02-CY1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751375AbdHaRwl (ORCPT ); Thu, 31 Aug 2017 13:52:41 -0400 Received: from BN6PR03CA0024.namprd03.prod.outlook.com (2603:10b6:404:23::34) by MWHSPR01MB180.namprd03.prod.outlook.com (2603:10b6:301:7b::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10; Thu, 31 Aug 2017 17:52:40 +0000 Received: from BN1BFFO11FD030.protection.gbl (2a01:111:f400:7c10::1:133) by BN6PR03CA0024.outlook.office365.com (2603:10b6:404:23::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.13.10 via Frontend Transport; Thu, 31 Aug 2017 17:52:39 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11FD030.mail.protection.outlook.com (10.58.144.93) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.1385.11 via Frontend Transport; Thu, 31 Aug 2017 17:52:39 +0000 Received: from r49496.am.freescale.net (r49496.am.freescale.net [10.29.244.202]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v7VHqajJ026181; Thu, 31 Aug 2017 10:52:38 -0700 From: Fabio Estevam To: CC: , Fabio Estevam , Kishon Vijay Abraham I Subject: [PATCH 02/10] PCI: dra7xx: Fix platform_get_irq() error handling Date: Thu, 31 Aug 2017 14:52:02 -0300 Message-ID: <1504201930-3617-2-git-send-email-fabio.estevam@nxp.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1504201930-3617-1-git-send-email-fabio.estevam@nxp.com> References: <1504201930-3617-1-git-send-email-fabio.estevam@nxp.com> X-EOPAttributedMessage: 0 X-Matching-Connectors: 131486755599205445; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(39380400002)(39860400002)(2980300002)(1109001)(1110001)(339900001)(189002)(199003)(106466001)(8676002)(5003940100001)(76176999)(105606002)(50986999)(81166006)(81156014)(68736007)(86362001)(575784001)(36756003)(5660300001)(8656003)(305945005)(110136004)(498600001)(104016004)(33646002)(2351001)(47776003)(189998001)(53936002)(356003)(54906002)(77096006)(4326008)(48376002)(50466002)(85426001)(626005)(6916009)(2950100002)(97736004)(6666003)(8936002)(50226002)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHSPR01MB180; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11FD030; 1:TEXcUVuGCLjiIheCoR6PCwE3IQnCYVu0Y3ewHujNw3c1XtLgsZsV+2qj8K2UwvcdYp8w7dQeQ8Ed0A3XY9tWgHzb9gZZRQZfMja9ywrXI5ojpBt+8JFabPK8332dN8XU MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ee6fd338-c4b3-4c98-62e4-08d4f099129d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(300000502095)(300135100095)(22001)(300000503095)(300135400095)(2017052603199)(201703131430075)(201703131517081)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095); SRVR:MWHSPR01MB180; X-Microsoft-Exchange-Diagnostics: 1; MWHSPR01MB180; 3:Xbpaogtrq3wXM/QxzpuU9RC0ltX1PiQVDQXv7dZnApjF34/r5C+k2JMzXZvh4fKLHMa3akaHjPduU6NQR8Eujs8VEr2Dg8ALy4Rmj8X2ln3K2aSyoIwMJYGrJI357/h21NmYFCT8s4NpI9qo3u7MXRYLKPRO3TF4VnpbDUXz8gXsLKRPSlcbcX+SXuu7eWtUSSIuX39MmQsFkIfFBn6NqSC06ajCEj2qUPOi5YH3NEc+y0GQluaXZgTFecnphLR/ST2RLggqrVMQzalxb/nbh+w38rB6AmI3UHfInl3z8KN0GE3fFLCGZOTylkDIzDEQqiAhdLaEQo7jiM/RUP7MJp4S8LQU/wlWf6PNDGnfDXE=; 25:kIRGGUHTvUa/wWUtrQG9jQydBikx5u+FC3HypJ9w8QToq4aQ/pN44q5pkvueq7xvHurcGGhktF/IC0c/zsF9WPBl2LAUXtJLe4mo6a5EPwT/HLSA5NVXJiUU6SpEDLSdHq7cLFga0r4j3EyM1nU/WC6ft84m2R1wPZBmvPKt0McHw+129t98HMu8tzUSQCFrt5gdLrx4/VmJ8LE8/CuphLi2qB5zukGUGBvGCvmdxQ9xpy3738+31OCux3wBJdYB/WoRthCronTHy/BN1unOR5mOCIqUY6Y38GM4KNyu3ICOO13Kdq85KT9gLznFtlF92c4sT/0P47ecz6/MDbfjUw== X-MS-TrafficTypeDiagnostic: MWHSPR01MB180: X-Microsoft-Exchange-Diagnostics: 1; MWHSPR01MB180; 31:zPLnVfCdvCbn+Uc+KqgdG7BO1rmgYDBabDJrSYFQrGDi5r3aoWk5canUc/qgmBfTOW8Nhp/aNMRPuH2EcIX7+dec8UZ6wScLG07WrT5pXSDUU2zOJFJQMayf9ZRFXEHs4q8Ei/j+/DvpVomMhmOpFZeUMH70SVl6fWnp/3bol2LJCUM9KtH6XwcagqfSl5isJI8/PchOuqRvfT2FGPVk7somPKEthdWgK5O+aatsKBE=; 4:TjgWY6Wr9wvfQiDyiKTGxXBM6vECqY7QwtWFdGMUxLMP6iw8JV7GCjGxKSwpHFJRzKLZGLeI+JmRY1xQ4GCiGsG9tU0dlNlFM0L5p3NdhAB/ipltuR9l52MgcTe7fu9DgsEIXMVyEVycx5HatSRtqAJp+TRyDFNptzhH3APeokB16b88L2mdmKm9OOuE9gLQlL62cjy1ufdqABxi/cc4W9F75jAr+HtBku7ZNB66UJgLt88R6LBnlflTMWN/hEvjMF2SPE9Chb+KrldoCDncPiblmgDmyMoTC8mV0ZaVXZRxlvoyecshwfg2+qZae+J9Rg8xgBu9A9hN0u8E3clUUg== X-Exchange-Antispam-Report-Test: UriScan:(31051911155226)(185117386973197); X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6095135)(601004)(2401047)(13018025)(8121501046)(5005006)(13016025)(93006095)(93001095)(100000703101)(100105400095)(3002001)(10201501046)(6055026)(6096035)(20161123556025)(20161123563025)(20161123561025)(20161123565025)(201703131430075)(201703131433075)(201703131448075)(201703161259150)(201703151042153)(20161123559100)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095); SRVR:MWHSPR01MB180; BCL:0; PCL:0; RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(400006)(100000804101)(100110200095)(100000805101)(100110500095); SRVR:MWHSPR01MB180; X-Forefront-PRVS: 04163EF38A X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; MWHSPR01MB180; 23:Jd7S6sNgXWSLmJTRzYG8RUfd+z7TYE7Eqn8sZg0Nf?= =?us-ascii?Q?CnuSOw+YAkibI+PwGtyt4Q8PSw7rigWgXiRlTQdoZoqOFdIGjxRJx4BarFCG?= =?us-ascii?Q?OlI9ur6Y++XbuNo81jrcmMO7oT4aMQl39ygzUQ0E0HMUZaiLAVVTaJBvHhid?= =?us-ascii?Q?SvlJRvtv1oyrHQuW6QeOhUtIeB7/0DJskPNfoCllj5n3nIgtXOl7l2kzr1nZ?= =?us-ascii?Q?rp4xmzt8UQBAArfMhwuKR/GElwyIxifXsPgMII8vD+r3z+UEIUoxeRQp5M44?= =?us-ascii?Q?/mIU1qMW4MGRPB/aKA9vNqUcPPmQiiBwPzVHOdjDLbKoDuB0IMYM3b0ogqO7?= =?us-ascii?Q?UQuksav9EL4eNdyzXWE0Tss7p4EF+n12MQri8cALpk4PP9DjaXUn1QUSMudK?= =?us-ascii?Q?UowIkrt/XKJsbLNL/BcrxCd8CXoyRW1mKbhM2MCCjbbrXhXkwqh2KbLxlVX1?= =?us-ascii?Q?PtCBnIJZrrVIRxCh0+3ywpdXTsiRZeeA75M4B+hgCAzokdrfxGlGn56m5/t+?= =?us-ascii?Q?JJ4G+qtxwuTSmo5gda7kXmGbGomdpQrcSWc/ca7tttXT/UWykyreMcPT/kFn?= =?us-ascii?Q?t7we9afaWGR0FNvRrnknL/sLIZG6DQmZht/BWzQ2m85FXFq2VOTI4C5QY8wt?= =?us-ascii?Q?Vf2KbWv9+hFE1wuA//aD/RR6mZL4BPng0rwOfNv7EmM4uMQ0Dt2RcyrbIJSR?= =?us-ascii?Q?mGiKF1cmOdoCrhC6B/IHsRwcU6bS1ohOTT4poSG0D4kbBDkASFMADB7n3KeH?= =?us-ascii?Q?d/CgDQuPxzKnIye1kFsaMba3v8stDgVgnk7VwhvcYx2XyLEMjrGO32LYqode?= =?us-ascii?Q?mawlagt68G5hPkJ7ZHJzI3xBWDJVys6pAn1KXQ9sc0tOxnt+lUQJGgGOa1rK?= =?us-ascii?Q?Nfk6KKT+zXixLYR5DeRXa4geHFvBrXyZE0mWyZYba0zdpjcZAAlPtf/mgZV1?= =?us-ascii?Q?ugp7Hs0iff2Z/UjS0truEO3enIxi6RpT+YbD3iavo42UIZ70QJSmjkk+AoEx?= =?us-ascii?Q?YlI1GHqbgxS/TMMAaGqoYEuDU2Dh7cJOCZUXVkywo3euRU/ImcUrlKtj0TtT?= =?us-ascii?Q?v7gt82kfkmX7FY022G+q3+g6YWpTpna59uWzsuc/JtnGhX3vtwXeAb1jnX3a?= =?us-ascii?Q?QkdXivznGqCOcc8hTbpYvxS4/UQlL7WpmbT64enyPQV4YWmbwpMag=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHSPR01MB180; 6:A2fWVQi0w4uViw+4emZRPt6HRCHkFX1K+6gUo7Gw601WQJIdKQtatW9Gut+bh7VPsuqwTIZdAi0Ayu6ycUnnRnadIzNeM1lVS2jBaJEsJHNkrd/J+0JWIg7fd/JtPhZiYVRVF6Y7qSjSVxU+uvgxOGfYqQrzqGACTkLQMAeVkSrorcF0AEVVi4+QJ79uh+n0f2QTUNNzWpTcmXVAtW61vrl4AV3VznGGj45PcvwAX6F8SQOg3Enx4J9Wx3ITwoTDUzITMV83IVSiMIUA0E0+Xu9jK4TXCvo2U/gpGA73v0f5r+VkLzF7lNJ5J0OxHP63WjXDkpKuabP09Ebt5kZVSg==; 5:eX4H0fuSw6gVXeQI7Lz78gagAIn+uY3sYEbWXoAvgZRR/2+LNO2hmJ1nopyEDkhxIsDqcV7Fzcl7YvFbg1nzy1t9Xm46qjcm8Zr92Tzw5MGm8rLD0PrEtYnVBFwZjzBsHyD9UQ8TeNRxbSdRQJzDPg==; 24:Vcu8IgZcITFJgY4uQLkZXsNH/P0BrTdmb0a5tBV6xH+JU6lm7auca6Xloz7Ly8WB2GyuX+jXb4e/FF0L4lm6BAL1BqGwPzB38nemFVz5g4s=; 7:Z8tze1nSiPTN3pvGskzRvjVu3hUiDWEP8Nw3eycB4etl59l4/XPlsgkmpvotZARu192NQdZzAKAs0pehhAXdnmmYYPa4/dA21L/6SL06MOnHPjwR/OuTBZXLg8Y0UPp9ZEtALAL01SkMISFT4Plk6u2qE9ZnpW6nUaO2rb4wlWrhWXz2KIhD6PM0SmfEWMVaI5z4wXpJQZZiNEM3JIv9MeUbO731G2ToW1DCqjT89zo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Aug 2017 17:52:39.7333 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHSPR01MB180 Sender: linux-pci-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pci@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP When platform_get_irq() fails we should propagate the real error value instead of always returning -EINVAL. Cc: Kishon Vijay Abraham I Signed-off-by: Fabio Estevam Acked-by: Kishon Vijay Abraham I --- drivers/pci/dwc/pci-dra7xx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c index e0dd98d..1e2aaed 100644 --- a/drivers/pci/dwc/pci-dra7xx.c +++ b/drivers/pci/dwc/pci-dra7xx.c @@ -450,7 +450,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie *dra7xx, pp->irq = platform_get_irq(pdev, 1); if (pp->irq < 0) { dev_err(dev, "missing IRQ resource\n"); - return -EINVAL; + return pp->irq; } ret = devm_request_irq(dev, pp->irq, dra7xx_pcie_msi_irq_handler,